magento/magento2#12250: View.xml is inheriting image sizes from paren…

[quisse]

View.xml is inheriting image sizes from parent (so an optional field is replaced by the value of parent)

• Made media attributes nullable and parse them correct

Description

Fixed Issues (if relevant)

1. View.xml is inheriting image sizes from parent (so an optional field is replaced by the value of parent) #12250: View.xml is inheriting image sizes from parent (so an optional field is replaced by the value of parent)

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[sidolov]

Hi @quisse , described behavior is expected, nodes in view.xml file will be overwritten by parent theme if they wasn't defined. For your case with image tag for overriding height field you may define empty height tag, in that case parent height will be ignored. Proposed changes are backward incompatible and may affect all existing themes.

[quisse]

Hi @sidolov, ok i understand. Now I've made it possible to add nulllable attributes.

[quisse]

Any update on this, @sidolov?

[sidolov]

Hi @quisse , fix looks good for me, but I think it would be better review all properties from view.xsd and make nillable all elements that make sense for override in 3d party extensions

[quisse]

I've refactored for more nillable attributes and to me it looks like that's all. Do you agree? If not can you please suggest others?

[quisse]

@sidolov ?

[magento-engcom-team]

Hi @sidolov, thank you for the review.
ENGCOM-2650 has been created to process this Pull Request

[magento-engcom-team]

Hi @quisse. Thank you for your contribution.
We will aim to release these changes as part of 2.2.7.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

[quisse]

Already implemented in 2.3 by magento-architects/MAGETWO-91314-validate-new