Skip to content

[Forwardport] magento/magento2#12250: View.xml is inheriting image sizes from paren…#17725

Merged
magento-engcom-team merged 3 commits intomagento:2.3-developfrom
nmalevanec:2.3-develop-PR-port-14537
Aug 26, 2018
Merged

[Forwardport] magento/magento2#12250: View.xml is inheriting image sizes from paren…#17725
magento-engcom-team merged 3 commits intomagento:2.3-developfrom
nmalevanec:2.3-develop-PR-port-14537

Conversation

@nmalevanec
Copy link
Copy Markdown
Contributor

Original Pull Request

#14537

View.xml is inheriting image sizes from parent (so an optional field is replaced by the value of parent)

  • Made media attributes nullable and parse them correct

Description

Fixed Issues (if relevant)

  1. View.xml is inheriting image sizes from parent (so an optional field is replaced by the value of parent) #12250: View.xml is inheriting image sizes from parent (so an optional field is replaced by the value of parent)

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @nmalevanec. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Aug 22, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-2852 has been created to process this Pull Request

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @nmalevanec. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants