Skip to content

[Backport] magento/magento2#12250: View.xml is inheriting image sizes from paren…#17439

Merged
magento-engcom-team merged 3 commits intomagento:2.1-developfrom
quisse:2.1-develop-PR-port-14537
Aug 8, 2018
Merged

[Backport] magento/magento2#12250: View.xml is inheriting image sizes from paren…#17439
magento-engcom-team merged 3 commits intomagento:2.1-developfrom
quisse:2.1-develop-PR-port-14537

Conversation

@quisse
Copy link
Copy Markdown

@quisse quisse commented Aug 8, 2018

Original Pull Request

#14537

View.xml is inheriting image sizes from parent (so an optional field is replaced by the value of parent)

  • Made media attributes nullable and parse them correct

Description

Fixed Issues (if relevant)

  1. View.xml is inheriting image sizes from parent (so an optional field is replaced by the value of parent) #12250: View.xml is inheriting image sizes from parent (so an optional field is replaced by the value of parent)

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @quisse. Thank you for your contribution.
We will aim to release these changes as part of 2.1.16.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants