-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable product price is not displayed if all children are out of stock and even if Display Out of Stock Products is set to "yes" #16069
Comments
Hello @alexber88, thank you for your report. |
I am working on this #mm18id |
@indraraka thank you for joining. Please accept team invitation here and self-assign the issue. |
#prakashpatel07 |
Looks like the problem is caused by vendor/magento/module-configurable-product/Plugin/Model/ResourceModel/Attribute/InStockOptionSelectBuilder.php Especially by the condition below It should depend on the setting cataloginventory/options/show_out_of_stock |
…ubitems * the current logic is inversed as it will add the filter for stock only elements when the option is activated * this commit fixes magento#16069
You are looking at wrong places. Final price in index table equals zero. Need to fix indexation process. |
No @zhartaunik - it is not an indexation problem. Current behaviour was added as a side effect of this issue "MAGETWO-72582: Configurable product displays the price of "out of stock" configuration". |
…ldren are out of stock and even if Display Out of Stock Products is set to "yes" - allow "out of stock" items to be used for price determination of configurable product ONLY in case all child products are "out of stock".
…ldren are out of stock and even if Display Out of Stock Products is set to "yes" - add blank space. (cherry picked from commit 0b19e04)
…ldren are out of stock and even if Display Out of Stock Products is set to "yes" - remove unneeded usage of the variable. (cherry picked from commit 207e2e1)
…ldren are out of stock and even if Display Out of Stock Products is set to "yes" (cherry picked from commit f4ec67e)
…ubitems * the current logic is inversed as it will add the filter for stock only elements when the option is activated * this commit fixes magento#16069
…ldren are out of stock and even if Display Out of Stock Products is set to "yes" - allow "out of stock" items to be used for price determination of configurable product ONLY in case all child products are "out of stock". (cherry picked from commit 80f6a36) magento#16069: Configurable product price is not displayed if all children are out of stock and even if Display Out of Stock Products is set to "yes" - add strict types. (cherry picked from commit b786871) magento#16069: Configurable product price is not displayed if all children are out of stock and even if Display Out of Stock Products is set to "yes" - refactor variable names. (cherry picked from commit d009296) magento#16069: Configurable product price is not displayed if all children are out of stock and even if Display Out of Stock Products is set to "yes" - add blank space. (cherry picked from commit 0b19e04) magento#16069: Configurable product price is not displayed if all children are out of stock and even if Display Out of Stock Products is set to "yes" - remove unneeded usage of the variable. (cherry picked from commit 207e2e1) magento#16069: Configurable product price is not displayed if all children are out of stock and even if Display Out of Stock Products is set to "yes" (cherry picked from commit f4ec67e) magento#16069: Configurable product price is not displayed if all children are out of stock - change request magento#16069: Configurable product price is not displayed if all children are out of stock - change request magento#16069: Configurable product price is not displayed if all children are out of stock - change request magento#16069: Configurable product price is not displayed if all children are out of stock - change request
Hello @alexber88 This issue was investigated by internal Magento team in the scop of related Jira ticket. Unfortunately, I have to close this issue as well because such changes will not be approved. To help at least somehow I would recommend having a look at this topic on the Magento Community Forum. Possibly it has a custom solution for this issue |
This cant be right - as it is duplicate of #23196 |
I just created a small module to show the price of out-of-stock items based on this answer at stackexchange. Feel free to fork: Composer install should work, if you add the repo to your dependencies. Be aware, that I set the required php version to "^7.1" - you may need to reconfigure that in the cmposer.json file, if you use another version. |
Thanks for this, but in list page not show, you can fix this? Thanks. |
Hey @vitormcsi, Normally, the extension shows prices also on the category and search result pages. |
Sorry @nordcomputer, I reindex and fix all, Many Thanks. |
Preconditions
Steps to reproduce
Expected result
Actual result
Seems like in \Magento\ConfigurableProduct\Model\ResourceModel\Product\StockStatusBaseSelectProcessor::process() there is incorrect condition.
It should be:
if (!$this->stockConfig->isShowOutOfStock()) {
The text was updated successfully, but these errors were encountered: