Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configurable product price is not shown for out-of-stock subproducts, even if it is configured to #17897

Closed
brosenberger opened this issue Sep 3, 2018 · 6 comments
Labels
Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@brosenberger
Copy link
Contributor

Preconditions

  1. magento2 2.2.3
  2. enable option in stores -> configuration -> catalog -> inventory -> stock options -> display out of stock products

Steps to reproduce

  1. create a configurable product, all simple products are out of stock
  2. go to detail page of the configurable product

Expected result

  1. the lowest price of the configurable product is shown as it is with in stock products

Actual result

  1. no price at all is shown

I think the problem lies within https://github.com/magento/magento2/blob/2.2-develop/app/code/Magento/ConfigurableProduct/Model/ResourceModel/Product/StockStatusBaseSelectProcessor.php#L48 where the addition of the sql check for stock status should be within the else part of this condition, e.g.

public function process(Select $select) 
{
  if (**!**$this->stockConfig->isShowOutOfStock()) {
@magento-engcom-team
Copy link
Contributor

Hi @brosenberger. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me {$VERSION} instance

where {$VERSION} is version tags (starting from 2.2.0+) or develop branches (2.2-develop +).
For more details, please, review the Magento Contributor Assistant documentation.

@brosenberger do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Sep 3, 2018
@brosenberger
Copy link
Contributor Author

@magento-engcom-team give me 2.2.3 instance

@magento-engcom-team
Copy link
Contributor

Hi @brosenberger. Thank you for your request. I'm working on Magento 2.2.3 instance for you

@magento-engcom-team
Copy link
Contributor

Hi @brosenberger, here is your Magento instance.
Admin access: https://i-17897-2-2-3.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@brosenberger
Copy link
Contributor Author

@magento-engcom-team it can be reproduced, see product https://i-17897-2-2-3.engcom.dev.magento.com/myconfigurable.html where no price is shown.

@ghost ghost self-assigned this Sep 3, 2018
@ghost
Copy link

ghost commented Sep 3, 2018

Duplicate of #16069

@ghost ghost marked this as a duplicate of #16069 Sep 3, 2018
@ghost ghost closed this as completed Sep 3, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Development

No branches or pull requests

2 participants