fix inversed logic for adding stock status for configurable product s…

…ubitems * the current logic is inversed as it will add the filter for stock only elements when the option is activated * this commit fixes magento#16069
brosenberger · Nov 15, 2018 · f25080b · f25080b
1 parent e6fee77
commit f25080b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/...agento/ConfigurableProduct/Model/ResourceModel/Product/StockStatusBaseSelectProcessor.php b/...agento/ConfigurableProduct/Model/ResourceModel/Product/StockStatusBaseSelectProcessor.php
@@ -45,7 +45,7 @@ public function __construct(
      */
     public function process(Select $select)
     {
-        if ($this->stockConfig->isShowOutOfStock()) {
+        if (!$this->stockConfig->isShowOutOfStock()) {
             $select->joinInner(
                 ['stock' => $this->stockStatusResource->getMainTable()],
                 sprintf(

diff --git a/...rableProduct/Test/Unit/Model/ResourceModel/Product/StockStatusBaseSelectProcessorTest.php b/...rableProduct/Test/Unit/Model/ResourceModel/Product/StockStatusBaseSelectProcessorTest.php
@@ -73,7 +73,7 @@ public function testProcess($isShowOutOfStock)
             ->disableOriginalConstructor()
             ->getMock();
 
-        if ($isShowOutOfStock) {
+        if (!$isShowOutOfStock) {
             $selectMock->expects($this->once())
                 ->method('joinInner')
                 ->with(