fix(rspeedy/core): output.inlineScripts should defaults to true#915
Merged
colinaaa merged 1 commit intolynx-family:release/rspeedy-0-9-7from May 26, 2025
Conversation
…ynx-family#910) ## Summary <!-- Can you explain the reasoning behind implementing this change? What problem or issue does this pull request resolve? --> Fix a regression of lynx-family#874. We should set `output.inlineScripts` to Rsbuild, so that: - The default value of `environment.config.output.inlineScripts` could be `true` - The `output.inlineScripts` could be set in `lynx.config.js` <!-- It would be helpful if you could provide any relevant context, such as GitHub issues or related discussions. --> ## Checklist <!--- Check and mark with an "x" --> - [x] Tests updated (or not required). - [ ] Documentation updated (or not required).
🦋 Changeset detectedLatest commit: baa92cd The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
colinaaa
pushed a commit
that referenced
this pull request
May 26, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to release/rspeedy-0-9-7, this PR will be updated. # Releases ## @lynx-js/chunk-loading-webpack-plugin@0.3.0 ### Minor Changes - **BREAKING CHANGE**: Requires `@rspack/core` v1.3.10. ([#922](#922)) ## @lynx-js/rspeedy@0.9.7 ### Patch Changes - The default value of `output.inlineScripts` should be `true`. ([#915](#915)) - Updated dependencies \[[`c210b79`](c210b79)]: - @lynx-js/chunk-loading-webpack-plugin@0.3.0 ## @lynx-js/react-rsbuild-plugin@0.10.1 ### Patch Changes - The default value of `output.inlineScripts` should be `true` on `@lynx-js/rspeedy` <= v0.9.6. ([#923](#923)) - Updated dependencies \[]: - @lynx-js/react-alias-rsbuild-plugin@0.10.1 ## create-rspeedy@0.9.7 ## @lynx-js/react-alias-rsbuild-plugin@0.10.1 ## upgrade-rspeedy@0.9.7 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
colinaaa
pushed a commit
to colinaaa/lynx-stack
that referenced
this pull request
May 26, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to release/rspeedy-0-9-7, this PR will be updated. # Releases ## @lynx-js/chunk-loading-webpack-plugin@0.3.0 ### Minor Changes - **BREAKING CHANGE**: Requires `@rspack/core` v1.3.10. ([lynx-family#922](lynx-family#922)) ## @lynx-js/rspeedy@0.9.7 ### Patch Changes - The default value of `output.inlineScripts` should be `true`. ([lynx-family#915](lynx-family#915)) - Updated dependencies \[[`c210b79`](lynx-family@c210b79)]: - @lynx-js/chunk-loading-webpack-plugin@0.3.0 ## @lynx-js/react-rsbuild-plugin@0.10.1 ### Patch Changes - The default value of `output.inlineScripts` should be `true` on `@lynx-js/rspeedy` <= v0.9.6. ([lynx-family#923](lynx-family#923)) - Updated dependencies \[]: - @lynx-js/react-alias-rsbuild-plugin@0.10.1 ## create-rspeedy@0.9.7 ## @lynx-js/react-alias-rsbuild-plugin@0.10.1 ## upgrade-rspeedy@0.9.7 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a cherry-pick of #910 to
release/rspeedy-0-9-7.Fix a regression of #874.
We should set
output.inlineScriptsto Rsbuild, so that:environment.config.output.inlineScriptscould betrueoutput.inlineScriptscould be set inlynx.config.jsChecklist