fix(rspeedy/core): output.inlineScripts should defaults to true#910
Merged
colinaaa merged 1 commit intolynx-family:mainfrom May 26, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
CodSpeed Performance ReportMerging #910 will improve performances by 17.86%Comparing Summary
Benchmarks breakdown
|
2 tasks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
colinaaa
added a commit
to colinaaa/lynx-stack
that referenced
this pull request
May 26, 2025
…ynx-family#910) ## Summary <!-- Can you explain the reasoning behind implementing this change? What problem or issue does this pull request resolve? --> Fix a regression of lynx-family#874. We should set `output.inlineScripts` to Rsbuild, so that: - The default value of `environment.config.output.inlineScripts` could be `true` - The `output.inlineScripts` could be set in `lynx.config.js` <!-- It would be helpful if you could provide any relevant context, such as GitHub issues or related discussions. --> ## Checklist <!--- Check and mark with an "x" --> - [x] Tests updated (or not required). - [ ] Documentation updated (or not required).
2 tasks
colinaaa
added a commit
that referenced
this pull request
May 26, 2025
…915) ## Summary This is a cherry-pick of #910 to `release/rspeedy-0-9-7`. Fix a regression of #874. We should set `output.inlineScripts` to Rsbuild, so that: - The default value of `environment.config.output.inlineScripts` could be `true` - The `output.inlineScripts` could be set in `lynx.config.js` <!-- It would be helpful if you could provide any relevant context, such as GitHub issues or related discussions. --> ## Checklist <!--- Check and mark with an "x" --> - [x] Tests updated (or not required). - [ ] Documentation updated (or not required).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a regression of #874.
We should set
output.inlineScriptsto Rsbuild, so that:environment.config.output.inlineScriptscould betrueoutput.inlineScriptscould be set inlynx.config.jsChecklist