feat: extend inlineScripts type by gaoachao · Pull Request #883 · lynx-family/lynx-stack

gaoachao · 2025-05-22T08:23:22Z

Summary

follow up #874
close #870

Align output.inlineScripts with Rsbuild

type InlineChunkTestFunction = (params: {
  size: number;
  name: string;
}) => boolean;

type InlineChunkTest = RegExp | InlineChunkTestFunction;

type InlineChunkConfig =
  | boolean
  | InlineChunkTest
  | { enable?: boolean | 'auto'; test: InlineChunkTest };

Checklist

Tests updated (or not required).
Documentation updated (or not required).

changeset-bot · 2025-05-22T08:23:25Z

🦋 Changeset detected

Latest commit: 4401025

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages

Name	Type
@lynx-js/rspeedy	Patch
@lynx-js/react-rsbuild-plugin	Patch
@lynx-js/react-webpack-plugin	Patch
@lynx-js/template-webpack-plugin	Patch
create-rspeedy	Patch
upgrade-rspeedy	Patch
@lynx-js/react-alias-rsbuild-plugin	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov · 2025-05-22T08:32:00Z

Codecov Report

Attention: Patch coverage is 92.00000% with 6 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...ck/template-webpack-plugin/src/LynxEncodePlugin.ts	90.62%	6 Missing ⚠️

📢 Thoughts on this report? Let us know!

codspeed-hq · 2025-05-22T08:35:03Z

CodSpeed Performance Report

Merging #883 will not alter performance

_{Comparing feat/extend-inlineScripts-type (4401025) with main (a64333e)}

Summary

✅ 10 untouched benchmarks

relativeci · 2025-05-26T13:27:52Z

React Example

#2224 Bundle Size — 233.19KiB (0%).

4401025(current) vs a64333e main#2199(baseline)

Bundle metrics no changes

	Current #2224	Baseline #2199
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`0%`	`0%`
Chunks	`0`	`0`
Assets	`4`	`4`
Modules	`152`	`152`
Duplicate Modules	`60`	`60`
Duplicate Code	`45.81%`	`45.81%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #2224	Baseline #2199
IMG	`145.76KiB`	`145.76KiB`
Other	`87.43KiB`	`87.43KiB`

Bundle analysis report Branch feat/extend-inlineScripts-type Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2025-06-03T16:42:19Z

Web Explorer

#2214 Bundle Size — 258.15KiB (0%).

4401025(current) vs a64333e main#2189(baseline)

Bundle metrics no changes

	Current #2214	Baseline #2189
Initial JS	`140.17KiB`	`140.17KiB`
Initial CSS	`31.82KiB`	`31.82KiB`
Cache Invalidation	`0%`	`76.84%`
Chunks	`4`	`4`
Assets	`4`	`4`
Modules	`207`	`207`
Duplicate Modules	`15`	`15`
Duplicate Code	`3.41%`	`3.41%`
Packages	`4`	`4`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #2214	Baseline #2189
JS	`226.33KiB`	`226.33KiB`
CSS	`31.82KiB`	`31.82KiB`

Bundle analysis report Branch feat/extend-inlineScripts-type Project dashboard

^{Generated by RelativeCI Documentation Report issue}

packages/webpack/template-webpack-plugin/src/LynxEncodePlugin.ts

packages/webpack/template-webpack-plugin/src/LynxTemplatePlugin.ts

packages/webpack/template-webpack-plugin/src/LynxEncodePlugin.ts

packages/rspeedy/core/src/config/output/index.ts

Co-authored-by: Qingyu Wang <40660121+colinaaa@users.noreply.github.com> Signed-off-by: BitterGourd <91231822+gaoachao@users.noreply.github.com>

## Summary   Remove inlinedAssets from inlinedManifest ## Checklist  - [x] Tests updated (or not required). - [x] Documentation updated (or not required).

packages/rspeedy/plugin-react/src/entry.ts

.changeset/tired-times-glow.md

packages/rspeedy/core/test/config/validate.test.ts

.changeset/tangy-ends-act.md

colinaaa

The current implementation LGTM. But there are more to think about to make it better:

We should not only apply inlineScripts to LynxEncodePlugin, the WebEncodePlugin should also support this.
- We may want a base class and implement some common logic (e.g.: inline script, deleting inline assets)
We may want to allow customize the retry and error handling of external chunks
- In Rsbuild Web, we have https://github.com/rspack-contrib/rsbuild-plugin-assets-retry
We may want to allow injecting external & inlined chunks
- In Rsbuild Web, we have api.modifyHTMLTags that can add <script> to the HTML.

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @lynx-js/qrcode-rsbuild-plugin@0.4.0 ### Minor Changes - Support "Type to search" when switching entries and schema. ([#1115](#1115)) ## @lynx-js/react@0.110.1 ### Patch Changes - Fix a memory leak when using `<list/>`. ([#1144](#1144)) ## @lynx-js/rspeedy@0.9.11 ### Patch Changes - Enable fine-grained control for `output.inlineScripts` ([#883](#883)) ```ts type InlineChunkTestFunction = (params: { size: number; name: string; }) => boolean; type InlineChunkTest = RegExp | InlineChunkTestFunction; type InlineChunkConfig = | boolean | InlineChunkTest | { enable?: boolean | "auto"; test: InlineChunkTest }; ``` ```ts import { defineConfig } from "@lynx-js/rspeedy"; export default defineConfig({ output: { inlineScripts: ({ name, size }) => { return name.includes("foo") && size < 1000; }, }, }); ``` - docs: remove chunks: 'all' in comments ([#1168](#1168)) ## @lynx-js/react-rsbuild-plugin@0.10.5 ### Patch Changes - Avoid IIFE in `main-thread.js` to resolve memory leak when using `<list />`. ([#1176](#1176)) - Enable fine-grained control for `output.inlineScripts` ([#883](#883)) ```ts type InlineChunkTestFunction = (params: { size: number; name: string; }) => boolean; type InlineChunkTest = RegExp | InlineChunkTestFunction; type InlineChunkConfig = | boolean | InlineChunkTest | { enable?: boolean | "auto"; test: InlineChunkTest }; ``` ```ts import { defineConfig } from "@lynx-js/rspeedy"; export default defineConfig({ output: { inlineScripts: ({ name, size }) => { return name.includes("foo") && size < 1000; }, }, }); ``` - Updated dependencies \[[`51cb73d`](51cb73d), [`69fb042`](69fb042), [`a7e8b5b`](a7e8b5b)]: - @lynx-js/runtime-wrapper-webpack-plugin@0.1.2 - @lynx-js/template-webpack-plugin@0.8.1 - @lynx-js/react-webpack-plugin@0.6.17 - @lynx-js/react-alias-rsbuild-plugin@0.10.5 - @lynx-js/use-sync-external-store@1.5.0 - @lynx-js/react-refresh-webpack-plugin@0.3.3 - @lynx-js/css-extract-webpack-plugin@0.6.0 ## @lynx-js/web-constants@0.14.1 ### Patch Changes - feat: support BTS API `lynx.reportError` && `__SetSourceMapRelease`, now you can use it and handle it in lynx-view error event. ([#1059](#1059)) - fix: in lynx-view all-on-ui mode, the input event of input and textarea is triggered twice, and the first e.detail is a string, which does not conform to the expected data format. ([#1179](#1179)) - fix: under the all-on-ui strategy, reload() will add two page elements. ([#1147](#1147)) - Updated dependencies \[]: - @lynx-js/web-worker-rpc@0.14.1 ## @lynx-js/web-core@0.14.1 ### Patch Changes - feat: support BTS API `lynx.reportError` && `__SetSourceMapRelease`, now you can use it and handle it in lynx-view error event. ([#1059](#1059)) - fix: under the all-on-ui strategy, reload() will add two page elements. ([#1147](#1147)) - Updated dependencies \[[`a64333e`](a64333e), [`7751375`](7751375), [`b52a924`](b52a924)]: - @lynx-js/web-worker-runtime@0.14.1 - @lynx-js/web-constants@0.14.1 - @lynx-js/web-mainthread-apis@0.14.1 - @lynx-js/web-worker-rpc@0.14.1 ## @lynx-js/web-elements@0.7.7 ### Patch Changes - fix: the param `index` of list scrollToPosition function should be `position`. ([#1135](#1135)) - fix: in lynx-view all-on-ui mode, the input event of input and textarea is triggered twice, and the first e.detail is a string, which does not conform to the expected data format. ([#1179](#1179)) - Updated dependencies \[]: - @lynx-js/web-elements-template@0.7.7 ## @lynx-js/web-mainthread-apis@0.14.1 ### Patch Changes - fix: under the all-on-ui strategy, reload() will add two page elements. ([#1147](#1147)) - Updated dependencies \[[`a64333e`](a64333e), [`7751375`](7751375), [`b52a924`](b52a924)]: - @lynx-js/web-constants@0.14.1 ## @lynx-js/web-worker-runtime@0.14.1 ### Patch Changes - feat: support BTS API `lynx.reportError` && `__SetSourceMapRelease`, now you can use it and handle it in lynx-view error event. ([#1059](#1059)) - Updated dependencies \[[`a64333e`](a64333e), [`7751375`](7751375), [`b52a924`](b52a924)]: - @lynx-js/web-constants@0.14.1 - @lynx-js/web-mainthread-apis@0.14.1 - @lynx-js/web-worker-rpc@0.14.1 ## @lynx-js/react-webpack-plugin@0.6.17 ### Patch Changes - Enable fine-grained control for `output.inlineScripts` ([#883](#883)) ```ts type InlineChunkTestFunction = (params: { size: number; name: string; }) => boolean; type InlineChunkTest = RegExp | InlineChunkTestFunction; type InlineChunkConfig = | boolean | InlineChunkTest | { enable?: boolean | "auto"; test: InlineChunkTest }; ``` ```ts import { defineConfig } from "@lynx-js/rspeedy"; export default defineConfig({ output: { inlineScripts: ({ name, size }) => { return name.includes("foo") && size < 1000; }, }, }); ``` ## @lynx-js/runtime-wrapper-webpack-plugin@0.1.2 ### Patch Changes - Wrap with IIFE when `output.iife: false` to avoid naming conflict. ([#1176](#1176)) ## @lynx-js/template-webpack-plugin@0.8.1 ### Patch Changes - feat: `::placeholder` will be compiled to `part(input)::placeholder`, which means you can use pseudo-element CSS to add placeholder styles to input and textarea. ([#1158](#1158)) // before <input placeholder-color='red' placeholder-font-weight='bold' placeholder-font-size='20px'> // after <input> input::placeholder { color: red; font-weight: bold; font-size: 20px; } - Enable fine-grained control for `output.inlineScripts` ([#883](#883)) ```ts type InlineChunkTestFunction = (params: { size: number; name: string; }) => boolean; type InlineChunkTest = RegExp | InlineChunkTestFunction; type InlineChunkConfig = | boolean | InlineChunkTest | { enable?: boolean | "auto"; test: InlineChunkTest }; ``` ```ts import { defineConfig } from "@lynx-js/rspeedy"; export default defineConfig({ output: { inlineScripts: ({ name, size }) => { return name.includes("foo") && size < 1000; }, }, }); ``` ## create-rspeedy@0.9.11 ## @lynx-js/react-alias-rsbuild-plugin@0.10.5 ## upgrade-rspeedy@0.9.11 ## @lynx-js/web-core-server@0.14.1 ## @lynx-js/web-elements-template@0.7.7 ## @lynx-js/web-worker-rpc@0.14.1 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

gaoachao force-pushed the feat/extend-inlineScripts-type branch 2 times, most recently from 1a20548 to e8e44bf Compare May 26, 2025 08:32

gaoachao added 3 commits May 27, 2025 17:21

feat: extend inlineScripts type

9554adc

feat: extend inlineScripts type

c3ff162

feat: extend inlineScripts type

30adb2d

gaoachao force-pushed the feat/extend-inlineScripts-type branch from 7170f13 to 30adb2d Compare May 27, 2025 09:21

gaoachao added 2 commits May 27, 2025 17:47

feat: extend inlineScripts type

83f5e68

docs: update inlineScripts remarks

f85e09d

gaoachao marked this pull request as ready for review May 27, 2025 10:07

gaoachao requested a review from colinaaa as a code owner May 27, 2025 10:07

gaoachao requested a review from upupming May 27, 2025 10:10

gaoachao added 2 commits May 29, 2025 16:55

Merge branch 'main' into feat/extend-inlineScripts-type

2f3e0aa

Merge branch 'main' into feat/extend-inlineScripts-type

bee7f5f

Merge branch 'main' into feat/extend-inlineScripts-type

45b572d

colinaaa reviewed Jun 18, 2025

View reviewed changes

gaoachao and others added 9 commits June 18, 2025 22:47

Update packages/webpack/template-webpack-plugin/src/LynxEncodePlugin.ts

243ce04

Co-authored-by: Qingyu Wang <40660121+colinaaa@users.noreply.github.com> Signed-off-by: BitterGourd <91231822+gaoachao@users.noreply.github.com>

Merge origin/main

5a5c885

fix: remove originManifest

5c2983e

fix: changeset and docs

32cf731

fix: remove changes of WebEncodePlugin

2aa690d

fix: externalManifest should only contains background[.hash].js

4e13393

fix: adopt lynx.requireModuleAsync

30db5f5

docs: update

b0b4620

chore: update comments

c96f6d7

gaoachao requested a review from colinaaa June 20, 2025 09:31

chore: update comments

efdcb62

gaoachao added this to the @lynx-js/rspeedy v0.10.0 milestone Jun 25, 2025

gaoachao added 2 commits June 27, 2025 15:30

fix: config test

1ab66ea

colinaaa reviewed Jun 27, 2025

View reviewed changes

packages/rspeedy/plugin-react/src/entry.ts Show resolved Hide resolved

.changeset/tired-times-glow.md Outdated Show resolved Hide resolved

packages/rspeedy/core/test/config/validate.test.ts Show resolved Hide resolved

.changeset/tangy-ends-act.md Outdated Show resolved Hide resolved

gaoachao added 2 commits June 27, 2025 19:06

feat: set 'jsReady' when inlineScripts !== true

1a6c75c

fix: test

4401025

gaoachao enabled auto-merge June 27, 2025 11:21

gaoachao requested a review from colinaaa June 27, 2025 11:22

colinaaa approved these changes Jun 27, 2025

View reviewed changes

gaoachao added this pull request to the merge queue Jun 27, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 27, 2025

gaoachao added this pull request to the merge queue Jun 27, 2025

Merged via the queue into main with commit a7e8b5b Jun 27, 2025
42 checks passed

gaoachao deleted the feat/extend-inlineScripts-type branch June 27, 2025 14:29

github-actions bot mentioned this pull request Jun 27, 2025

chore: Release 2025-06-30 16:18:59 #1137

Merged

gaoachao mentioned this pull request Jun 30, 2025

[Feature]: Support api.modifyLynxManifest #1181

Open

gaoachao mentioned this pull request Jul 7, 2025

[Feature]: apply inlineScripts to WebEncodePlugin #1228

Open

Aditya-PS-05 mentioned this pull request Jul 7, 2025

feat(template-webpack-plugin): apply inlineScripts to WebEncodePlugin #1231

Closed

2 tasks

colinaaa mentioned this pull request Aug 21, 2025

feat: cache events until background thread ready #1370

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: extend inlineScripts type#883

feat: extend inlineScripts type#883
gaoachao merged 22 commits intomainfrom
feat/extend-inlineScripts-type

gaoachao commented May 22, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented May 22, 2025 •

edited

Loading

Uh oh!

codecov bot commented May 22, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented May 22, 2025 •

edited

Loading

Uh oh!

relativeci bot commented May 26, 2025 •

edited

Loading

Uh oh!

relativeci bot commented Jun 3, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

colinaaa left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

gaoachao commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

changeset-bot bot commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

codecov bot commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codspeed-hq bot commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #883 will not alter performance

Summary

Uh oh!

relativeci bot commented May 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React Example

#2224 Bundle Size — 233.19KiB (0%).

Uh oh!

relativeci bot commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Web Explorer

#2214 Bundle Size — 258.15KiB (0%).

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

colinaaa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gaoachao commented May 22, 2025 •

edited

Loading

changeset-bot bot commented May 22, 2025 •

edited

Loading

codecov bot commented May 22, 2025 •

edited

Loading

codspeed-hq bot commented May 22, 2025 •

edited

Loading

relativeci bot commented May 26, 2025 •

edited

Loading

relativeci bot commented Jun 3, 2025 •

edited

Loading