Skip to content

docs: remove chunks: 'all' in splitChunks#1168

Merged
gaoachao merged 2 commits intomainfrom
docs/remove-chunks-all
Jun 26, 2025
Merged

docs: remove chunks: 'all' in splitChunks#1168
gaoachao merged 2 commits intomainfrom
docs/remove-chunks-all

Conversation

@gaoachao
Copy link
Copy Markdown
Collaborator

Summary

When splitChunk is configured with 'chunks: all', the initial chunks of main-thread.js may attempt to load this splitChunk. However, since we don't perform chunk splitting in the main thread, this will result in errors.

This comment could mislead developers, as we're not actually using 'chunks: all' but rather the default value 'async'.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@gaoachao gaoachao requested a review from colinaaa as a code owner June 26, 2025 09:25
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jun 26, 2025

🦋 Changeset detected

Latest commit: ce86158

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@lynx-js/rspeedy Patch
create-rspeedy Patch
upgrade-rspeedy Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gaoachao gaoachao requested a review from upupming June 26, 2025 09:26
Signed-off-by: BitterGourd <91231822+gaoachao@users.noreply.github.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jun 26, 2025

CodSpeed Performance Report

Merging #1168 will not alter performance

Comparing docs/remove-chunks-all (ce86158) with main (b8a1122)

Summary

✅ 10 untouched benchmarks

@relativeci
Copy link
Copy Markdown

relativeci bot commented Jun 26, 2025

React Example

#2171 Bundle Size — 233.19KiB (0%).

ce86158(current) vs b8a1122 main#2157(baseline)

Bundle metrics  no changes
                 Current
#2171
     Baseline
#2157
No change  Initial JS 0B 0B
No change  Initial CSS 0B 0B
No change  Cache Invalidation 0% 0%
No change  Chunks 0 0
No change  Assets 4 4
No change  Modules 152 152
No change  Duplicate Modules 60 60
No change  Duplicate Code 45.81% 45.81%
No change  Packages 2 2
No change  Duplicate Packages 0 0
Bundle size by type  no changes
                 Current
#2171
     Baseline
#2157
No change  IMG 145.76KiB 145.76KiB
No change  Other 87.43KiB 87.43KiB

Bundle analysis reportBranch docs/remove-chunks-allProject dashboard


Generated by RelativeCIDocumentationReport issue

@relativeci
Copy link
Copy Markdown

relativeci bot commented Jun 26, 2025

Web Explorer

#2161 Bundle Size — 257.95KiB (0%).

ce86158(current) vs b8a1122 main#2147(baseline)

Bundle metrics  Change 1 change
                 Current
#2161
     Baseline
#2147
No change  Initial JS 140.07KiB 140.07KiB
No change  Initial CSS 31.82KiB 31.82KiB
No change  Cache Invalidation 0% 0%
No change  Chunks 4 4
No change  Assets 4 4
Change  Modules 206(+0.49%) 205
No change  Duplicate Modules 15 15
No change  Duplicate Code 3.41% 3.41%
No change  Packages 4 4
No change  Duplicate Packages 0 0
Bundle size by type  no changes
                 Current
#2161
     Baseline
#2147
No change  JS 226.13KiB 226.13KiB
No change  CSS 31.82KiB 31.82KiB

Bundle analysis reportBranch docs/remove-chunks-allProject dashboard


Generated by RelativeCIDocumentationReport issue

@gaoachao gaoachao added this pull request to the merge queue Jun 26, 2025
Merged via the queue into main with commit 0ff9eb5 Jun 26, 2025
42 checks passed
@gaoachao gaoachao deleted the docs/remove-chunks-all branch June 26, 2025 11:54
colinaaa pushed a commit that referenced this pull request Jun 30, 2025
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @lynx-js/qrcode-rsbuild-plugin@0.4.0

### Minor Changes

- Support "Type to search" when switching entries and schema.
([#1115](#1115))

## @lynx-js/react@0.110.1

### Patch Changes

- Fix a memory leak when using `<list/>`.
([#1144](#1144))

## @lynx-js/rspeedy@0.9.11

### Patch Changes

- Enable fine-grained control for `output.inlineScripts`
([#883](#883))

    ```ts
    type InlineChunkTestFunction = (params: {
      size: number;
      name: string;
    }) => boolean;

    type InlineChunkTest = RegExp | InlineChunkTestFunction;

    type InlineChunkConfig =
      | boolean
      | InlineChunkTest
      | { enable?: boolean | "auto"; test: InlineChunkTest };
    ```

    ```ts
    import { defineConfig } from "@lynx-js/rspeedy";

    export default defineConfig({
      output: {
        inlineScripts: ({ name, size }) => {
          return name.includes("foo") && size < 1000;
        },
      },
    });
    ```

- docs: remove chunks: 'all' in comments
([#1168](#1168))

## @lynx-js/react-rsbuild-plugin@0.10.5

### Patch Changes

- Avoid IIFE in `main-thread.js` to resolve memory leak when using
`<list />`.
([#1176](#1176))

- Enable fine-grained control for `output.inlineScripts`
([#883](#883))

    ```ts
    type InlineChunkTestFunction = (params: {
      size: number;
      name: string;
    }) => boolean;

    type InlineChunkTest = RegExp | InlineChunkTestFunction;

    type InlineChunkConfig =
      | boolean
      | InlineChunkTest
      | { enable?: boolean | "auto"; test: InlineChunkTest };
    ```

    ```ts
    import { defineConfig } from "@lynx-js/rspeedy";

    export default defineConfig({
      output: {
        inlineScripts: ({ name, size }) => {
          return name.includes("foo") && size < 1000;
        },
      },
    });
    ```

- Updated dependencies
\[[`51cb73d`](51cb73d),
[`69fb042`](69fb042),
[`a7e8b5b`](a7e8b5b)]:
    -   @lynx-js/runtime-wrapper-webpack-plugin@0.1.2
    -   @lynx-js/template-webpack-plugin@0.8.1
    -   @lynx-js/react-webpack-plugin@0.6.17
    -   @lynx-js/react-alias-rsbuild-plugin@0.10.5
    -   @lynx-js/use-sync-external-store@1.5.0
    -   @lynx-js/react-refresh-webpack-plugin@0.3.3
    -   @lynx-js/css-extract-webpack-plugin@0.6.0

## @lynx-js/web-constants@0.14.1

### Patch Changes

- feat: support BTS API `lynx.reportError` && `__SetSourceMapRelease`,
now you can use it and handle it in lynx-view error event.
([#1059](#1059))

- fix: in lynx-view all-on-ui mode, the input event of input and
textarea is triggered twice, and the first e.detail is a string, which
does not conform to the expected data format.
([#1179](#1179))

- fix: under the all-on-ui strategy, reload() will add two page
elements. ([#1147](#1147))

-   Updated dependencies \[]:
    -   @lynx-js/web-worker-rpc@0.14.1

## @lynx-js/web-core@0.14.1

### Patch Changes

- feat: support BTS API `lynx.reportError` && `__SetSourceMapRelease`,
now you can use it and handle it in lynx-view error event.
([#1059](#1059))

- fix: under the all-on-ui strategy, reload() will add two page
elements. ([#1147](#1147))

- Updated dependencies
\[[`a64333e`](a64333e),
[`7751375`](7751375),
[`b52a924`](b52a924)]:
    -   @lynx-js/web-worker-runtime@0.14.1
    -   @lynx-js/web-constants@0.14.1
    -   @lynx-js/web-mainthread-apis@0.14.1
    -   @lynx-js/web-worker-rpc@0.14.1

## @lynx-js/web-elements@0.7.7

### Patch Changes

- fix: the param `index` of list scrollToPosition function should be
`position`.
([#1135](#1135))

- fix: in lynx-view all-on-ui mode, the input event of input and
textarea is triggered twice, and the first e.detail is a string, which
does not conform to the expected data format.
([#1179](#1179))

-   Updated dependencies \[]:
    -   @lynx-js/web-elements-template@0.7.7

## @lynx-js/web-mainthread-apis@0.14.1

### Patch Changes

- fix: under the all-on-ui strategy, reload() will add two page
elements. ([#1147](#1147))

- Updated dependencies
\[[`a64333e`](a64333e),
[`7751375`](7751375),
[`b52a924`](b52a924)]:
    -   @lynx-js/web-constants@0.14.1

## @lynx-js/web-worker-runtime@0.14.1

### Patch Changes

- feat: support BTS API `lynx.reportError` && `__SetSourceMapRelease`,
now you can use it and handle it in lynx-view error event.
([#1059](#1059))

- Updated dependencies
\[[`a64333e`](a64333e),
[`7751375`](7751375),
[`b52a924`](b52a924)]:
    -   @lynx-js/web-constants@0.14.1
    -   @lynx-js/web-mainthread-apis@0.14.1
    -   @lynx-js/web-worker-rpc@0.14.1

## @lynx-js/react-webpack-plugin@0.6.17

### Patch Changes

- Enable fine-grained control for `output.inlineScripts`
([#883](#883))

    ```ts
    type InlineChunkTestFunction = (params: {
      size: number;
      name: string;
    }) => boolean;

    type InlineChunkTest = RegExp | InlineChunkTestFunction;

    type InlineChunkConfig =
      | boolean
      | InlineChunkTest
      | { enable?: boolean | "auto"; test: InlineChunkTest };
    ```

    ```ts
    import { defineConfig } from "@lynx-js/rspeedy";

    export default defineConfig({
      output: {
        inlineScripts: ({ name, size }) => {
          return name.includes("foo") && size < 1000;
        },
      },
    });
    ```

## @lynx-js/runtime-wrapper-webpack-plugin@0.1.2

### Patch Changes

- Wrap with IIFE when `output.iife: false` to avoid naming conflict.
([#1176](#1176))

## @lynx-js/template-webpack-plugin@0.8.1

### Patch Changes

- feat: `::placeholder` will be compiled to `part(input)::placeholder`,
which means you can use pseudo-element CSS to add placeholder styles to
input and textarea.
([#1158](#1158))

        // before
<input placeholder-color='red' placeholder-font-weight='bold'
placeholder-font-size='20px'>

        // after
        <input>

        input::placeholder {
          color: red;
          font-weight: bold;
          font-size: 20px;
        }

- Enable fine-grained control for `output.inlineScripts`
([#883](#883))

    ```ts
    type InlineChunkTestFunction = (params: {
      size: number;
      name: string;
    }) => boolean;

    type InlineChunkTest = RegExp | InlineChunkTestFunction;

    type InlineChunkConfig =
      | boolean
      | InlineChunkTest
      | { enable?: boolean | "auto"; test: InlineChunkTest };
    ```

    ```ts
    import { defineConfig } from "@lynx-js/rspeedy";

    export default defineConfig({
      output: {
        inlineScripts: ({ name, size }) => {
          return name.includes("foo") && size < 1000;
        },
      },
    });
    ```

## create-rspeedy@0.9.11



## @lynx-js/react-alias-rsbuild-plugin@0.10.5



## upgrade-rspeedy@0.9.11



## @lynx-js/web-core-server@0.14.1



## @lynx-js/web-elements-template@0.7.7



## @lynx-js/web-worker-rpc@0.14.1

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants