Conversation
🦋 Changeset detectedLatest commit: ef9672d The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gaoachao
changed the title
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
CodSpeed Performance ReportMerging #658 will create unknown performance changesComparing Summary
Benchmarks breakdown
|
colinaaa
reviewed
Apr 29, 2025
Collaborator
colinaaa
left a comment
colinaaa
left a comment
There was a problem hiding this comment.
We need to add tests for this. For example, some tests will fail without the StartupChunkDependenciesPlugin.
Co-authored-by: Qingyu Wang <40660121+colinaaa@users.noreply.github.com> Signed-off-by: BitterGourd <91231822+gaoachao@users.noreply.github.com>
gaoachao
force-pushed
the
feat/add-startup-chunk-deps-runtime
branch
from
ee9360b to
d48250c
Compare
colinaaa
approved these changes
May 6, 2025
colinaaa
added a commit
that referenced
this pull request
May 6, 2025
…ix chunk splitting" (#705) Reverts #658 This results in a 2% increase in the bundle size of the hello-world project. It seems that the check `if (chunkGraph.hasChunkEntryDependentChunks(chunk))` in webpack is absent. https://github.com/webpack/webpack/blob/0f42dc5b8bbfbc71f5550fe1c2e9b2edf38b4c25/lib/runtime/StartupChunkDependenciesPlugin.js#L59
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 19, 2025
…le to fix chunk splitting" (#798) <!-- Thank you for submitting a pull request! We appreciate the time and effort you have invested in making these changes. Please ensure that you provide enough information to allow others to review your pull request. Upon submission, your pull request will be automatically assigned with reviewers. If you want to learn more about contributing to this project, please visit: https://github.com/lynx-family/lynx-stack/blob/main/CONTRIBUTING.md. --> ## Summary <!-- Can you explain the reasoning behind implementing this change? What problem or issue does this pull request resolve? --> <!-- It would be helpful if you could provide any relevant context, such as GitHub issues or related discussions. --> Rspack now has exposed `hasChunkEntryDependentChunks` on ChunkGraph. Related links: - #658 - #705 - https://github.com/web-infra-dev/rspack/releases/tag/v1.3.10 - web-infra-dev/rspack#10286 ## Checklist <!--- Check and mark with an "x" --> - [x] Tests updated (or not required). - [x] Documentation updated (or not required). --------- Signed-off-by: BitterGourd <91231822+gaoachao@users.noreply.github.com> Co-authored-by: Qingyu Wang <40660121+colinaaa@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
add
StartupChunkDependenciesRuntimeModuleto fix chunk splittingStartupChunkDependenciesRuntimeModulefor handling chunk dependenciesRuntimeGlobals.ensureChunkHandlernot found when using chunk splittingRelated Links:
Checklist