Skip to content

feat: expose hasChunkEntryDependentChunks on ChunkGraph#10286

Merged
SyMind merged 1 commit intoweb-infra-dev:mainfrom
gaoachao:feat/expose-has-chunk-entry-dependent-chunks
May 8, 2025
Merged

feat: expose hasChunkEntryDependentChunks on ChunkGraph#10286
SyMind merged 1 commit intoweb-infra-dev:mainfrom
gaoachao:feat/expose-has-chunk-entry-dependent-chunks

Conversation

@gaoachao
Copy link
Contributor

@gaoachao gaoachao commented May 7, 2025

Summary

While Webpack provides hasChunkEntryDependentChunks method in its ChunkGraph, this functionality is missing in Rspack's JsChunkGraph. Although we have already implemented the underlying logic in chunk_graph_chunk.rs, it hasn't been exposed to the JavaScript interface.

This PR aims to expose this method to support the implementation of StartupChunkDependenciesRuntimeModule, which is crucial for fixing chunk splitting issues in Rspeedy.

Related links:

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented May 7, 2025

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 6e70efd
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/681b1967e5deb2000860ab62

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label May 7, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented May 7, 2025

CodSpeed Performance Report

Merging #10286 will not alter performance

Comparing gaoachao:feat/expose-has-chunk-entry-dependent-chunks (6e70efd) with main (708bfb0)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 11 untouched benchmarks

@chenjiahan chenjiahan requested a review from SyMind May 8, 2025 02:46
@SyMind SyMind merged commit e7ab6e3 into web-infra-dev:main May 8, 2025
39 checks passed
@gaoachao gaoachao deleted the feat/expose-has-chunk-entry-dependent-chunks branch May 8, 2025 05:14
github-merge-queue bot pushed a commit to lynx-family/lynx-stack that referenced this pull request May 19, 2025
…le to fix chunk splitting" (#798)

<!--
  Thank you for submitting a pull request!

We appreciate the time and effort you have invested in making these
changes. Please ensure that you provide enough information to allow
others to review your pull request.

Upon submission, your pull request will be automatically assigned with
reviewers.

If you want to learn more about contributing to this project, please
visit:
https://github.com/lynx-family/lynx-stack/blob/main/CONTRIBUTING.md.
-->

## Summary

<!-- Can you explain the reasoning behind implementing this change? What
problem or issue does this pull request resolve? -->

<!-- It would be helpful if you could provide any relevant context, such
as GitHub issues or related discussions. -->

Rspack now has exposed `hasChunkEntryDependentChunks` on ChunkGraph.

Related links:
- #658
- #705
- https://github.com/web-infra-dev/rspack/releases/tag/v1.3.10
- web-infra-dev/rspack#10286

## Checklist

<!--- Check and mark with an "x" -->

- [x] Tests updated (or not required).
- [x] Documentation updated (or not required).

---------

Signed-off-by: BitterGourd <91231822+gaoachao@users.noreply.github.com>
Co-authored-by: Qingyu Wang <40660121+colinaaa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: feature release: feature related release(mr only)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants