Skip to content

fix(rspeedy/core): should run typia transform on CLI#478

Merged
colinaaa merged 3 commits intolynx-family:mainfrom
colinaaa:colin/0405/typia-transform
Apr 5, 2025
Merged

fix(rspeedy/core): should run typia transform on CLI#478
colinaaa merged 3 commits intolynx-family:mainfrom
colinaaa:colin/0405/typia-transform

Conversation

@colinaaa
Copy link
Copy Markdown
Collaborator

@colinaaa colinaaa commented Apr 5, 2025

Summary

Fix a regression of #475: "Error on typia.createValidateEquals(): no transform has been configured."

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 5, 2025

⚠️ No Changeset found

Latest commit: 22c10cc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 5, 2025

CodSpeed Performance Report

Merging #478 will not alter performance

Comparing colinaaa:colin/0405/typia-transform (22c10cc) with main (d9b705b)

Summary

✅ 1 untouched benchmarks

@colinaaa colinaaa requested a review from Copilot April 5, 2025 09:10
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • packages/rspeedy/core/package.json: Language not supported
Comments suppressed due to low confidence (1)

packages/rspeedy/core/rslib.config.ts:81

  • The use of 'source?.tsconfigPath' might result in an undefined tsconfig path. Consider providing a default value or explicit error handling if 'source.tsconfigPath' is not set.
tsconfig: source?.tsconfigPath,

@colinaaa colinaaa mentioned this pull request Apr 5, 2025
2 tasks
@colinaaa colinaaa merged commit 8eff9dd into lynx-family:main Apr 5, 2025
22 checks passed
colinaaa added a commit that referenced this pull request Apr 5, 2025
<!--
  Thank you for submitting a pull request!

We appreciate the time and effort you have invested in making these
changes. Please ensure that you provide enough information to allow
others to review your pull request.

Upon submission, your pull request will be automatically assigned with
reviewers.

If you want to learn more about contributing to this project, please
visit:
https://github.com/lynx-family/lynx-stack/blob/main/CONTRIBUTING.md.
-->

## Summary

<!-- Can you explain the reasoning behind implementing this change? What
problem or issue does this pull request resolve? -->

Fix an regression of #478: "error TS2307: Cannot find module
'@lynx-js/rspeedy/register' or its corresponding type declarations."

>
https://github.com/lynx-family/lynx-stack/actions/runs/14280496355/job/40029566753

<!-- It would be helpful if you could provide any relevant context, such
as GitHub issues or related discussions. -->

## Checklist

<!--- Check and mark with an "x" -->

- [ ] Tests updated (or not required).
- [ ] Documentation updated (or not required).
colinaaa added a commit that referenced this pull request Apr 5, 2025
<!--
  Thank you for submitting a pull request!

We appreciate the time and effort you have invested in making these
changes. Please ensure that you provide enough information to allow
others to review your pull request.

Upon submission, your pull request will be automatically assigned with
reviewers.

If you want to learn more about contributing to this project, please
visit:
https://github.com/lynx-family/lynx-stack/blob/main/CONTRIBUTING.md.
-->

## Summary

<!-- Can you explain the reasoning behind implementing this change? What
problem or issue does this pull request resolve? -->

A new test `test-publish` has been added.

This test setup a mocked NPM registry using `@pnpm/registry-mock`
([verdaccio](https://verdaccio.org/) underhood) and publish all packages
to that registry. Then a Rspeedy App will be created and tested using
the newly published packages.

This is used to avoid future regression like: #475, #478 and #479.

<!-- It would be helpful if you could provide any relevant context, such
as GitHub issues or related discussions. -->

## Checklist

<!--- Check and mark with an "x" -->

- [x] Tests updated (or not required).
- [ ] Documentation updated (or not required).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants