fix(rspeedy/core): should run typia transform on CLI#478
fix(rspeedy/core): should run typia transform on CLI#478colinaaa merged 3 commits intolynx-family:mainfrom
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
CodSpeed Performance ReportMerging #478 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
Files not reviewed (1)
- packages/rspeedy/core/package.json: Language not supported
Comments suppressed due to low confidence (1)
packages/rspeedy/core/rslib.config.ts:81
- The use of 'source?.tsconfigPath' might result in an undefined tsconfig path. Consider providing a default value or explicit error handling if 'source.tsconfigPath' is not set.
tsconfig: source?.tsconfigPath,
<!-- Thank you for submitting a pull request! We appreciate the time and effort you have invested in making these changes. Please ensure that you provide enough information to allow others to review your pull request. Upon submission, your pull request will be automatically assigned with reviewers. If you want to learn more about contributing to this project, please visit: https://github.com/lynx-family/lynx-stack/blob/main/CONTRIBUTING.md. --> ## Summary <!-- Can you explain the reasoning behind implementing this change? What problem or issue does this pull request resolve? --> Fix an regression of #478: "error TS2307: Cannot find module '@lynx-js/rspeedy/register' or its corresponding type declarations." > https://github.com/lynx-family/lynx-stack/actions/runs/14280496355/job/40029566753 <!-- It would be helpful if you could provide any relevant context, such as GitHub issues or related discussions. --> ## Checklist <!--- Check and mark with an "x" --> - [ ] Tests updated (or not required). - [ ] Documentation updated (or not required).
<!-- Thank you for submitting a pull request! We appreciate the time and effort you have invested in making these changes. Please ensure that you provide enough information to allow others to review your pull request. Upon submission, your pull request will be automatically assigned with reviewers. If you want to learn more about contributing to this project, please visit: https://github.com/lynx-family/lynx-stack/blob/main/CONTRIBUTING.md. --> ## Summary <!-- Can you explain the reasoning behind implementing this change? What problem or issue does this pull request resolve? --> A new test `test-publish` has been added. This test setup a mocked NPM registry using `@pnpm/registry-mock` ([verdaccio](https://verdaccio.org/) underhood) and publish all packages to that registry. Then a Rspeedy App will be created and tested using the newly published packages. This is used to avoid future regression like: #475, #478 and #479. <!-- It would be helpful if you could provide any relevant context, such as GitHub issues or related discussions. --> ## Checklist <!--- Check and mark with an "x" --> - [x] Tests updated (or not required). - [ ] Documentation updated (or not required).
Summary
Fix a regression of #475: "Error on typia.createValidateEquals(): no transform has been configured."
Checklist