Conversation
|
CodSpeed Performance ReportMerging #477 will not alter performanceComparing Summary
|
``` npm error code ENEEDAUTH npm error need auth This command requires you to be logged in to http://localhost:4873/ npm error need auth You need to authorize this machine using `npm adduser` ```
There was a problem hiding this comment.
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
Files not reviewed (1)
- cspell.jsonc: Language not supported
Comments suppressed due to low confidence (2)
.github/workflows/test.yml:146
- The registry mock is started in the background without checking if it is ready before proceeding. Consider adding a wait or health check to ensure the mocked registry is available before publishing.
pnpm dlx @pnpm/registry-mock &
.github/workflows/test.yml:151
- [nitpick] Consider using modern command substitution syntax $(mktemp -d) instead of backticks for improved readability and maintainability.
cd `mktemp -d`
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Summary
A new test
test-publishhas been added.This test setup a mocked NPM registry using
@pnpm/registry-mock(verdaccio underhood) and publish all packages to that registry. Then a Rspeedy App will be created and tested using the newly published packages.This is used to avoid future regression like: #475, #478 and #479.
Checklist