fix(web-core): add ^build to turbo build deps by upupming · Pull Request #2585 · lynx-family/lynx-stack

upupming · 2026-05-08T15:21:16Z

Summary

packages/web-platform/web-core's turbo build task only depended on its local build:wasm, missing ^build. This caused turbo to start web-core's TypeScript build before its workspace deps (@lynx-js/web-elements, @lynx-js/web-worker-rpc, @lynx-js/css-serializer, ...) had finished building, producing partial dist/ output and intermittent CI failures (e.g. repl failing to resolve modules from web-core/dist).

Adding ^build makes turbo wait for upstream workspace builds, matching the convention used by every other package in the repo.

This was extracted from #2584 where the same fix unblocked Build (Ubuntu).

Test plan

Verified Build (Ubuntu) passes with this change applied on top of feat(react): fetchBundle-based lazy bundle loader #2584
Build (Ubuntu) passes on this PR
Build (Windows) passes on this PR

Summary by CodeRabbit

Chores
- Updated build task configuration to improve build process sequencing.

The local task config dropped the root's '^build' when overriding 'dependsOn' to add 'build:wasm'. As a result web-core's build can race ahead of its workspace deps' builds — on a fresh CI checkout, when @lynx-js/web-elements / @lynx-js/web-worker-rpc don't yet have a 'dist/index.js', web-core's rsbuild + rslib produces a partial dist that downstream consumers (e.g. repl) then fail to bundle ('Module not found: Can't resolve @lynx-js/web-worker-rpc' / missing 'dist/client/background/index.js'). Adding '^build' restores the workspace-dep ordering. The hash change also busts the existing poisoned turbo cache.

changeset-bot · 2026-05-08T15:21:24Z

⚠️ No Changeset found

Latest commit: a03803e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-05-08T15:21:32Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0d63b1ba-f472-4497-afe3-f6a347c9eeb5

📥 Commits

Reviewing files that changed from the base of the PR and between 5b6a33d and a03803e.

📒 Files selected for processing (1)

packages/web-platform/web-core/turbo.json

📝 Walkthrough

Walkthrough

The build task in packages/web-platform/web-core/turbo.json now depends on both the upstream ^build task and the local build:wasm task, ensuring builds execute in proper dependency order across the monorepo workspace.

Changes

Build Task Dependency Configuration

Layer / File(s)	Summary
Task Dependency Configuration `packages/web-platform/web-core/turbo.json`	The `build` task's `dependsOn` field now includes `^build` in addition to `build:wasm`, establishing proper task sequencing with upstream workspace dependencies.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

lynx-family/lynx-stack#2538: Updates the same Turbo task dependency by adding the upstream ^build dependency to establish consistent build task ordering across the workspace.

Suggested labels

platform:Web

Suggested reviewers

PupilTong
Sherry-hue

Poem

🐰 A rabbit hops through build chains,
Dependencies align like mane strains,
^build and wasm now dance as one,
Tasks ordered perfect, build is done! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely summarizes the main change: adding the ^build dependency to the turbo build task configuration in web-core.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/web-core-turbo-build-deps

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2026-05-08T15:24:10Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

codspeed-hq · 2026-05-08T15:37:34Z

Merging this PR will degrade performance by 14.76%

⚠️

Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 80 untouched benchmarks
⏩ 26 skipped benchmarks¹

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
❌	`transform 1000 view elements`	40 ms	46.9 ms	-14.76%

_{Comparing fix/web-core-turbo-build-deps (a03803e) with main (5b6a33d)}

26 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

relativeci · 2026-05-08T15:39:22Z

Web Explorer

#9557 Bundle Size — 900.02KiB (0%).

a03803e(current) vs 87c1759 main#9531(baseline)

Bundle metrics no changes

	Current #9557	Baseline #9531
Initial JS	`44.46KiB`	`44.46KiB`
Initial CSS	`2.22KiB`	`2.22KiB`
Cache Invalidation	`0%`	`0%`
Chunks	`9`	`9`
Assets	`11`	`11`
Modules	`229`	`229`
Duplicate Modules	`11`	`11`
Duplicate Code	`27.28%`	`27.28%`
Packages	`10`	`10`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #9557	Baseline #9531
JS	`495.88KiB`	`495.88KiB`
Other	`401.92KiB`	`401.92KiB`
CSS	`2.22KiB`	`2.22KiB`

Bundle analysis report Branch fix/web-core-turbo-build-deps Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2026-05-08T15:39:24Z

React External

#1099 Bundle Size — 690.27KiB (0%).

a03803e(current) vs 87c1759 main#1073(baseline)

Bundle metrics no changes

	Current #1099	Baseline #1073
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`0%`	`0%`
Chunks	`0`	`0`
Assets	`3`	`3`
Modules	`17`	`17`
Duplicate Modules	`5`	`5`
Duplicate Code	`8.59%`	`8.59%`
Packages	`0`	`0`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #1099	Baseline #1073
Other	`690.27KiB`	`690.27KiB`

Bundle analysis report Branch fix/web-core-turbo-build-deps Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2026-05-08T15:39:24Z

React MTF Example

#1115 Bundle Size — 206.69KiB (+0.04%).

a03803e(current) vs 87c1759 main#1089(baseline)

Bundle metrics

1 change

	Current #1115	Baseline #1089
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`46.16%`	`0%`
Chunks	`0`	`0`
Assets	`3`	`3`
Modules	`192`	`192`
Duplicate Modules	`77`	`77`
Duplicate Code	`44.36%`	`44.36%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type

1 change

1 regression

	Current #1115	Baseline #1089
IMG	`111.23KiB`	`111.23KiB`
Other	`95.46KiB` (`+0.09%`)	`95.37KiB`

Bundle analysis report Branch fix/web-core-turbo-build-deps Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2026-05-08T15:39:25Z

React Example with Element Template

#250 Bundle Size — 197.77KiB (-0.01%).

a03803e(current) vs 87c1759 main#224(baseline)

Bundle metrics

3 changes

	Current #250	Baseline #224
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`26.31%`	`26.39%`
Chunks	`0`	`0`
Assets	`4`	`4`
Modules	`79`(`-1.25%`)	`80`
Duplicate Modules	`23`	`23`
Duplicate Code	`40.43%`(`+0.3%`)	`40.31%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type

1 change

1 improvement

	Current #250	Baseline #224
IMG	`145.76KiB`	`145.76KiB`
Other	`52.01KiB` (`-0.04%`)	`52.03KiB`

Bundle analysis report Branch fix/web-core-turbo-build-deps Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2026-05-08T15:39:27Z

React Example

#7985 Bundle Size — 235.77KiB (0%).

a03803e(current) vs 87c1759 main#7959(baseline)

Bundle metrics no changes

	Current #7985	Baseline #7959
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`0%`	`0%`
Chunks	`0`	`0`
Assets	`4`	`4`
Modules	`197`	`197`
Duplicate Modules	`80`	`80`
Duplicate Code	`44.85%`	`44.85%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #7985	Baseline #7959
IMG	`145.76KiB`	`145.76KiB`
Other	`90.01KiB`	`90.01KiB`

Bundle analysis report Branch fix/web-core-turbo-build-deps Project dashboard

^{Generated by RelativeCI Documentation Report issue}

upupming requested review from PupilTong and Sherry-hue as code owners May 8, 2026 15:21

coderabbitai Bot added the platform:Web label May 8, 2026

PupilTong approved these changes May 11, 2026

View reviewed changes

upupming merged commit 4b27356 into main May 11, 2026
83 of 86 checks passed

upupming deleted the fix/web-core-turbo-build-deps branch May 11, 2026 03:40

Conversation

upupming commented May 8, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented May 8, 2026

⚠️ No Changeset found

Uh oh!

coderabbitai Bot commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Uh oh!

codecov Bot commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codspeed-hq Bot commented May 8, 2026

Merging this PR will degrade performance by 14.76%

Performance Changes

Footnotes

Uh oh!

relativeci Bot commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Web Explorer

#9557 Bundle Size — 900.02KiB (0%).

Uh oh!

relativeci Bot commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React External

#1099 Bundle Size — 690.27KiB (0%).

Uh oh!

relativeci Bot commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React MTF Example

#1115 Bundle Size — 206.69KiB (+0.04%).

Uh oh!

relativeci Bot commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React Example with Element Template

#250 Bundle Size — 197.77KiB (-0.01%).

Uh oh!

relativeci Bot commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React Example

#7985 Bundle Size — 235.77KiB (0%).

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

upupming commented May 8, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 8, 2026 •

edited

Loading

codecov Bot commented May 8, 2026 •

edited

Loading

relativeci Bot commented May 8, 2026 •

edited

Loading

relativeci Bot commented May 8, 2026 •

edited

Loading

relativeci Bot commented May 8, 2026 •

edited

Loading

relativeci Bot commented May 8, 2026 •

edited

Loading

relativeci Bot commented May 8, 2026 •

edited

Loading