fix(web): XMarkdown slot created should not have prefix by Sherry-hue · Pull Request #2520 · lynx-family/lynx-stack

Sherry-hue · 2026-04-24T03:44:25Z

Summary by CodeRabbit

Bug Fixes
- XMarkdown inline view slots no longer include the md-inline-view- prefix. Slots are now directly assigned using their identifier for improved clarity and simplified slot targeting when populating inline view content within markdown documents.

Checklist

Tests updated (or not required).
Documentation updated (or not required).
Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

changeset-bot · 2026-04-24T03:44:29Z

🦋 Changeset detected

Latest commit: 409971d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages

Name	Type
@lynx-js/web-elements	Patch
upgrade-rspeedy	Patch
@lynx-js/web-core	Patch
@lynx-js/web-rsbuild-server-middleware	Patch
@lynx-js/template-webpack-plugin	Patch
@lynx-js/react-rsbuild-plugin	Patch
create-rspeedy	Patch
@lynx-js/web-worker-rpc	Patch
@lynx-js/react-alias-rsbuild-plugin	Patch
@lynx-js/rspeedy	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-04-24T03:44:38Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8ab69fa9-37da-4237-afac-595f45447485

📥 Commits

Reviewing files that changed from the base of the PR and between 86fd0e5 and 409971d.

📒 Files selected for processing (4)

.changeset/breezy-sloths-move.md
packages/web-platform/web-elements/src/elements/XMarkdown/XMarkdownAttributes.ts
packages/web-platform/web-elements/tests/fixtures/x-markdown/inlineview-class.html
packages/web-platform/web-elements/tests/fixtures/x-markdown/inlineview.html

📝 Walkthrough

Walkthrough

The PR removes the md-inline-view- prefix from inline-view slot names in XMarkdown, using raw IDs instead. This includes a Changesets entry for the patch and updates test fixtures to reflect the new slot naming convention.

Changes

Cohort / File(s)	Summary
Changesets Entry `.changeset/breezy-sloths-move.md`	New changeset file marking `@lynx-js/web-elements` for a patch release with fix description for XMarkdown slot naming.
Core Implementation `packages/web-platform/web-elements/src/elements/XMarkdown/XMarkdownAttributes.ts`	Removes `md-inline-view-` prefix from inline-view slot assignment, assigning the slot name directly to the inline view identifier instead.
Test Fixtures `packages/web-platform/web-elements/tests/fixtures/x-markdown/inlineview.html`, `packages/web-platform/web-elements/tests/fixtures/x-markdown/inlineview-class.html`	Update slot attribute assignments to use raw inline view IDs instead of prefixed slot names (`content-view`, `badge` instead of `md-inline-view-content-view`, `md-inline-view-badge`).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

fix(web): markdown should pre-set slot #2516: Directly modifies XMarkdown's inline-view slot handling in XMarkdownAttributes.ts and test fixtures with related slot name changes.
feat(x-markdown): add markdown rendering support and tests #2412: Implemented the original inline-view reinjection with prefixed slot names that this PR now refactors to remove the prefix.

Suggested reviewers

PupilTong

Poem

🐰 A slot prefix vanishes, clean and bright,
No more md-inline-view- in sight!
Just raw IDs, simple and true,
XMarkdown's found a cleaner view. ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix(web): XMarkdown slot created should not have prefix' directly and clearly describes the main change across all modified files: removing the prefix from slot names in XMarkdown inline views.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2026-04-24T03:47:02Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

relativeci · 2026-04-24T04:10:30Z

React Example

#7600 Bundle Size — 225.23KiB (-0.04%).

409971d(current) vs d1743f2 main#7592(baseline)

Bundle metrics

1 change

	Current #7600	Baseline #7592
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`35.31%`	`0%`
Chunks	`0`	`0`
Assets	`4`	`4`
Modules	`179`	`179`
Duplicate Modules	`69`	`69`
Duplicate Code	`44.57%`	`44.57%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type

1 change

1 improvement

	Current #7600	Baseline #7592
IMG	`145.76KiB`	`145.76KiB`
Other	`79.47KiB` (`-0.1%`)	`79.55KiB`

Bundle analysis report Branch Sherry-hue:fix/markdown-slot-pre... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2026-04-24T04:10:30Z

React MTF Example

#732 Bundle Size — 196.39KiB (-0.04%).

409971d(current) vs d1743f2 main#724(baseline)

Bundle metrics

1 change

	Current #732	Baseline #724
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`43.38%`	`0%`
Chunks	`0`	`0`
Assets	`3`	`3`
Modules	`173`	`173`
Duplicate Modules	`66`	`66`
Duplicate Code	`44.07%`	`44.07%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type

1 change

1 improvement

	Current #732	Baseline #724
IMG	`111.23KiB`	`111.23KiB`
Other	`85.15KiB` (`-0.1%`)	`85.24KiB`

Bundle analysis report Branch Sherry-hue:fix/markdown-slot-pre... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2026-04-24T04:10:35Z

Web Explorer

#9173 Bundle Size — 900.02KiB (~-0.01%).

409971d(current) vs d1743f2 main#9164(baseline)

Bundle metrics

1 change

	Current #9173	Baseline #9164
Initial JS	`44.46KiB`	`44.46KiB`
Initial CSS	`2.22KiB`	`2.22KiB`
Cache Invalidation	`16.16%`	`0%`
Chunks	`9`	`9`
Assets	`11`	`11`
Modules	`229`	`229`
Duplicate Modules	`11`	`11`
Duplicate Code	`27.28%`	`27.28%`
Packages	`10`	`10`
Duplicate Packages	`0`	`0`

Bundle size by type

1 change

1 improvement

	Current #9173	Baseline #9164
JS	`495.88KiB` (`~-0.01%`)	`495.9KiB`
Other	`401.92KiB`	`401.92KiB`
CSS	`2.22KiB`	`2.22KiB`

Bundle analysis report Branch Sherry-hue:fix/markdown-slot-pre... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

codspeed-hq · 2026-04-24T04:20:12Z

Merging this PR will improve performance by 17.32%

⚡ 1 improved benchmark
✅ 80 untouched benchmarks
⏩ 26 skipped benchmarks¹

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	`transform 1000 view elements`	46.8 ms	39.9 ms	+17.32%

_{Comparing Sherry-hue:fix/markdown-slot-prefix (409971d) with main (86fd0e5)}

26 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

relativeci · 2026-04-24T06:22:54Z

React External

#717 Bundle Size — 679.93KiB (-0.04%).

409971d(current) vs d1743f2 main#709(baseline)

Bundle metrics

1 change

	Current #717	Baseline #709
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`39.69%`	`0%`
Chunks	`0`	`0`
Assets	`3`	`3`
Modules	`17`	`17`
Duplicate Modules	`5`	`5`
Duplicate Code	`8.59%`	`8.59%`
Packages	`0`	`0`
Duplicate Packages	`0`	`0`

Bundle size by type

1 change

1 improvement

	Current #717	Baseline #709
Other	`679.93KiB` (`-0.04%`)	`680.2KiB`

Bundle analysis report Branch Sherry-hue:fix/markdown-slot-pre... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

fix(web): XMarkdown slot created should not have prefix

409971d

Sherry-hue self-assigned this Apr 24, 2026

Sherry-hue added this to Lynx for Web Apr 24, 2026

Sherry-hue added the platform:Web label Apr 24, 2026

Sherry-hue requested a review from PupilTong as a code owner April 24, 2026 03:44

Sherry-hue enabled auto-merge (squash) April 24, 2026 07:18

PupilTong approved these changes Apr 24, 2026

View reviewed changes

Sherry-hue merged commit 647334c into lynx-family:main Apr 24, 2026
215 of 231 checks passed

github-project-automation Bot moved this to Done in Lynx for Web Apr 24, 2026

github-actions Bot mentioned this pull request Apr 24, 2026

chore: Release 2026-04-24 14:53:52 #2477

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(web): XMarkdown slot created should not have prefix#2520

fix(web): XMarkdown slot created should not have prefix#2520
Sherry-hue merged 1 commit intolynx-family:mainfrom
Sherry-hue:fix/markdown-slot-prefix

Sherry-hue commented Apr 24, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

changeset-bot Bot commented Apr 24, 2026

Uh oh!

coderabbitai Bot commented Apr 24, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

codecov Bot commented Apr 24, 2026 •

edited

Loading

Uh oh!

relativeci Bot commented Apr 24, 2026 •

edited

Loading

Uh oh!

relativeci Bot commented Apr 24, 2026 •

edited

Loading

Uh oh!

relativeci Bot commented Apr 24, 2026 •

edited

Loading

Uh oh!

codspeed-hq Bot commented Apr 24, 2026 •

edited

Loading

Uh oh!

relativeci Bot commented Apr 24, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Sherry-hue commented Apr 24, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Checklist

Uh oh!

changeset-bot Bot commented Apr 24, 2026

🦋 Changeset detected

Uh oh!

coderabbitai Bot commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

codecov Bot commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

relativeci Bot commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React Example

#7600 Bundle Size — 225.23KiB (-0.04%).

Uh oh!

relativeci Bot commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React MTF Example

#732 Bundle Size — 196.39KiB (-0.04%).

Uh oh!

relativeci Bot commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Web Explorer

#9173 Bundle Size — 900.02KiB (~-0.01%).

Uh oh!

codspeed-hq Bot commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will improve performance by 17.32%

Performance Changes

Footnotes

Uh oh!

relativeci Bot commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React External

#717 Bundle Size — 679.93KiB (-0.04%).

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Sherry-hue commented Apr 24, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 24, 2026 •

edited

Loading

codecov Bot commented Apr 24, 2026 •

edited

Loading

relativeci Bot commented Apr 24, 2026 •

edited

Loading

relativeci Bot commented Apr 24, 2026 •

edited

Loading

relativeci Bot commented Apr 24, 2026 •

edited

Loading

codspeed-hq Bot commented Apr 24, 2026 •

edited

Loading

relativeci Bot commented Apr 24, 2026 •

edited

Loading