fix(web): markdown should pre-set slot by Sherry-hue · Pull Request #2516 · lynx-family/lynx-stack

Sherry-hue · 2026-04-23T09:11:29Z

Summary by CodeRabbit

Release Notes

Bug Fixes
- Fixed inline view injection in x-markdown: when content changes, the component no longer queries light DOM children. Inline view elements now use slot-based projection and require a slot attribute to be set upfront.

Checklist

Tests updated (or not required).
Documentation updated (or not required).
Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

changeset-bot · 2026-04-23T09:11:35Z

🦋 Changeset detected

Latest commit: 8c2bdfd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages

Name	Type
@lynx-js/web-elements	Patch
upgrade-rspeedy	Patch
@lynx-js/web-core	Patch
@lynx-js/web-rsbuild-server-middleware	Patch
@lynx-js/template-webpack-plugin	Patch
@lynx-js/react-rsbuild-plugin	Patch
create-rspeedy	Patch
@lynx-js/web-worker-rpc	Patch
@lynx-js/react-alias-rsbuild-plugin	Patch
@lynx-js/rspeedy	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-04-23T09:11:44Z

📝 Walkthrough

Walkthrough

This pull request refactors the x-markdown inline-view injection mechanism in @lynx-js/web-elements. The #injectInlineViews method now uses a slot-based approach instead of querying light DOM children. Views intended for inline projection must now have slot="{id}" attributes set explicitly.

Changes

Cohort / File(s)	Summary
Changeset Documentation `.changeset/rich-teams-melt.md`	Patch entry documenting the fix to `@lynx-js/web-elements` inline-view injection behavior.
Core Implementation `packages/web-platform/web-elements/src/elements/XMarkdown/XMarkdownAttributes.ts`	Modified `#injectInlineViews` method to unconditionally replace inline-view `<img>` tags with `span.md-inline-view` containing named slots, removing prior DOM querying and element transfer logic.
Test Fixtures `packages/web-platform/web-elements/tests/fixtures/x-markdown/inlineview.html`, `inlineview-class.html`	Updated fixture markup to include explicit `slot` attribute assignments on `<x-view>` elements to match the new slot-based projection pattern.
Test Specification `packages/web-platform/web-elements/tests/x-markdown.spec.ts`	Test updated to validate slot projection behavior via `assignedElements()` instead of CSS `verticalAlign` property inspection.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

feat(x-markdown): add markdown rendering support and tests #2412: Directly related code-level changes modifying the same x-markdown inline-view injection logic and test fixtures.

Suggested reviewers

PupilTong
HuJean

Poem

🐰 hops with glee
No DOM queries hopping through the night,
Slots align the views so bright,
Markdown's heart beats true and tight,
With names assigned, projections right! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: modifying markdown inline view injection to require pre-set slot attributes instead of querying DOM elements.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2026-04-23T09:14:32Z

Codecov Report

❌ Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...ents/src/elements/XMarkdown/XMarkdownAttributes.ts	33.33%	4 Missing ⚠️

📢 Thoughts on this report? Let us know!

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.changeset/rich-teams-melt.md:
- Line 5: The changeset text documents the wrong slot name: the implementation
generates slots named "md-inline-view-{id}" and fixtures use
slot="md-inline-view-badge" / slot="md-inline-view-content-view", but the
changeset says to set slot="{id}"; update the changeset wording to instruct
consumers to pre-set slot="md-inline-view-{id}" (e.g.,
slot="md-inline-view-badge") so their element projects into inlineview://{id};
reference the generated slot name "md-inline-view-{id}" and the inlineview URI
pattern "inlineview://{id}" in the corrected sentence.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c15c38fd-2485-4242-a5f5-2c06cb16acde

📥 Commits

Reviewing files that changed from the base of the PR and between 13655ac and 8c2bdfd.

📒 Files selected for processing (5)

.changeset/rich-teams-melt.md
packages/web-platform/web-elements/src/elements/XMarkdown/XMarkdownAttributes.ts
packages/web-platform/web-elements/tests/fixtures/x-markdown/inlineview-class.html
packages/web-platform/web-elements/tests/fixtures/x-markdown/inlineview.html
packages/web-platform/web-elements/tests/x-markdown.spec.ts

codspeed-hq · 2026-04-23T09:28:59Z

Merging this PR will improve performance by 17.15%

⚡ 1 improved benchmark
✅ 80 untouched benchmarks
⏩ 26 skipped benchmarks¹

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	`transform 1000 view elements`	46.8 ms	40 ms	+17.15%

_{Comparing Sherry-hue:fix/markdown-slot (8c2bdfd) with main (13655ac)}

26 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

relativeci · 2026-04-23T09:33:55Z

React External

#678 Bundle Size — 679.93KiB (0%).

8c2bdfd(current) vs 13655ac main#674(baseline)

Bundle metrics no changes

	Current #678	Baseline #674
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`0%`	`0%`
Chunks	`0`	`0`
Assets	`3`	`3`
Modules	`17`	`17`
Duplicate Modules	`5`	`5`
Duplicate Code	`8.59%`	`8.59%`
Packages	`0`	`0`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #678	Baseline #674
Other	`679.93KiB`	`679.93KiB`

Bundle analysis report Branch Sherry-hue:fix/markdown-slot Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2026-04-23T09:33:56Z

Web Explorer

#9132 Bundle Size — 899.95KiB (-0.02%).

8c2bdfd(current) vs 13655ac main#9128(baseline)

Bundle metrics

2 changes

	Current #9132	Baseline #9128
Initial JS	`44.46KiB`	`44.46KiB`
Initial CSS	`2.22KiB`	`2.22KiB`
Cache Invalidation	`16.18%`	`0%`
Chunks	`9`	`9`
Assets	`11`	`11`
Modules	`229`	`229`
Duplicate Modules	`11`	`11`
Duplicate Code	`27.28%`(`-0.04%`)	`27.29%`
Packages	`10`	`10`
Duplicate Packages	`0`	`0`

Bundle size by type

1 change

1 improvement

	Current #9132	Baseline #9128
JS	`495.81KiB` (`-0.03%`)	`495.97KiB`
Other	`401.92KiB`	`401.92KiB`
CSS	`2.22KiB`	`2.22KiB`

Bundle analysis report Branch Sherry-hue:fix/markdown-slot Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2026-04-23T09:33:59Z

React MTF Example

#692 Bundle Size — 196.39KiB (0%).

8c2bdfd(current) vs 13655ac main#688(baseline)

Bundle metrics no changes

	Current #692	Baseline #688
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`0%`	`0%`
Chunks	`0`	`0`
Assets	`3`	`3`
Modules	`173`	`173`
Duplicate Modules	`66`	`66`
Duplicate Code	`44.07%`	`44.07%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #692	Baseline #688
IMG	`111.23KiB`	`111.23KiB`
Other	`85.15KiB`	`85.15KiB`

Bundle analysis report Branch Sherry-hue:fix/markdown-slot Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2026-04-23T09:34:01Z

React Example

#7560 Bundle Size — 225.23KiB (0%).

8c2bdfd(current) vs 13655ac main#7556(baseline)

Bundle metrics no changes

	Current #7560	Baseline #7556
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`0%`	`0%`
Chunks	`0`	`0`
Assets	`4`	`4`
Modules	`179`	`179`
Duplicate Modules	`69`	`69`
Duplicate Code	`44.57%`	`44.57%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #7560	Baseline #7556
IMG	`145.76KiB`	`145.76KiB`
Other	`79.47KiB`	`79.47KiB`

Bundle analysis report Branch Sherry-hue:fix/markdown-slot Project dashboard

^{Generated by RelativeCI Documentation Report issue}

fix(web): markdown should pre-set slot

8c2bdfd

Sherry-hue self-assigned this Apr 23, 2026

Sherry-hue requested a review from PupilTong as a code owner April 23, 2026 09:11

Sherry-hue added the platform:Web label Apr 23, 2026

Sherry-hue added this to Lynx for Web Apr 23, 2026

coderabbitai Bot reviewed Apr 23, 2026

View reviewed changes

Comment thread .changeset/rich-teams-melt.md

Sherry-hue enabled auto-merge (squash) April 23, 2026 09:47

PupilTong approved these changes Apr 23, 2026

View reviewed changes

Sherry-hue merged commit 9454dc4 into lynx-family:main Apr 23, 2026
49 of 51 checks passed

github-project-automation Bot moved this to Done in Lynx for Web Apr 23, 2026

github-actions Bot mentioned this pull request Apr 23, 2026

chore: Release 2026-04-24 14:53:52 #2477

Open

coderabbitai Bot mentioned this pull request Apr 24, 2026

fix(web): XMarkdown slot created should not have prefix #2520

Merged

3 tasks

Conversation

Sherry-hue commented Apr 23, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Release Notes

Checklist

Uh oh!

changeset-bot Bot commented Apr 23, 2026

🦋 Changeset detected

Uh oh!

coderabbitai Bot commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

codecov Bot commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codspeed-hq Bot commented Apr 23, 2026

Merging this PR will improve performance by 17.15%

Performance Changes

Footnotes

Uh oh!

relativeci Bot commented Apr 23, 2026

React External

#678 Bundle Size — 679.93KiB (0%).

Uh oh!

relativeci Bot commented Apr 23, 2026

Web Explorer

#9132 Bundle Size — 899.95KiB (-0.02%).

Uh oh!

relativeci Bot commented Apr 23, 2026

React MTF Example

#692 Bundle Size — 196.39KiB (0%).

Uh oh!

relativeci Bot commented Apr 23, 2026

React Example

#7560 Bundle Size — 225.23KiB (0%).

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Sherry-hue commented Apr 23, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 23, 2026 •

edited

Loading

codecov Bot commented Apr 23, 2026 •

edited

Loading