Conversation
🦋 Changeset detectedLatest commit: 260c2e6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
📝 WalkthroughWalkthroughAdds thread-specific JS minification options ( Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merging this PR will improve performance by 17.45%
Performance Changes
Comparing 
Footnotes
|
Web Explorer#8324 Bundle Size — 385.21KiB (0%).260c2e6(current) vs 503ac8f main#8321(baseline) Bundle metrics
|
| Current #8324 |
Baseline #8321 |
|
|---|---|---|
 Initial JS |
155.59KiB |
155.59KiB |
| Initial CSS |
35.1KiB |
35.1KiB |
| Cache Invalidation |
0% |
0% |
| Chunks |
8 |
8 |
| Assets |
8 |
8 |
| Modules |
237 |
237 |
| Duplicate Modules |
16 |
16 |
| Duplicate Code |
2.97% |
2.97% |
| Packages |
4 |
4 |
| Duplicate Packages |
0 |
0 |
Bundle size by type no changes
| Current #8324 |
Baseline #8321 |
|
|---|---|---|
| JS |
254.26KiB |
254.26KiB |
| Other |
95.85KiB |
95.85KiB |
| CSS |
35.1KiB |
35.1KiB |
Bundle analysis report Branch p/minify Project dashboard
Generated by RelativeCI Documentation Report issue
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
upupming
reviewed
Mar 17, 2026
…hread-specific minifier
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/rspeedy/core/src/plugins/minify.plugin.ts`:
- Around line 163-190: The current logic for mainThreadOptions.include and
backgroundOptions.include merges any inherited/user include with thread
patterns, widening scope; change this so the thread minimizers only target
thread bundles by setting mainThreadOptions.include = MAIN_THREAD_JS_PATTERN (or
[MAIN_THREAD_JS_PATTERN]) and backgroundOptions.include = BACKGROUND_JS_PATTERN
(or [BACKGROUND_JS_PATTERN]) instead of concatenating with existing include from
mergeJsOptions; update the blocks where mainThreadOptions and backgroundOptions
are set (refer to mergeJsOptions, mainThreadOptions.include,
backgroundOptions.include and the minimizer registrations
chain.optimization.minimizer('js-main-thread')/.minimizer('js-background') ) to
drop inherited include merging and use the thread pattern only.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: e2cd9ec4-da75-4a95-8479-1abb40f55bf9
⛔ Files ignored due to path filters (1)
packages/rspeedy/core/test/plugins/__snapshots__/minify.plugin.test.ts.snapis excluded by!**/*.snap
📒 Files selected for processing (9)
.changeset/tiny-ants-float.mdpackages/rspeedy/core/etc/rspeedy.api.mdpackages/rspeedy/core/src/config/output/minify.tspackages/rspeedy/core/src/plugins/minify.plugin.tspackages/rspeedy/core/test/config/minify.test-d.tspackages/rspeedy/core/test/config/validate.test.tspackages/rspeedy/core/test/plugins/minify.plugin.test.tspackages/rspeedy/plugin-react/test/config.test.tspackages/rspeedy/plugin-react/test/fixtures/pure-funcs/basic.js
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (2)
packages/rspeedy/plugin-react/test/optimizeBundleSize.test.ts (2)
132-179: Missing snapshot assertion for consistency.Unlike "basic usage" and "optimize background code" tests which call
expect(config?.optimization?.minimizer).toMatchSnapshot(), this test skips the snapshot assertion afterinitConfigs(). For consistency and to verify the minimizer configuration, consider adding the snapshot check.♻️ Suggested fix
], }) + const [config] = await rsbuild.initConfigs() + expect(config?.optimization?.minimizer).toMatchSnapshot() + const { mainThreadCode, backgroundCode } = await getCode(rsbuild)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/rspeedy/plugin-react/test/optimizeBundleSize.test.ts` around lines 132 - 179, Add the same snapshot assertion used in the other tests to verify the minimizer config: after creating rsbuild (or after calling initConfigs() if that returns the config) capture the build config and call expect(config?.optimization?.minimizer).toMatchSnapshot(); locate the "optimize main-thread code" test and add this single-line assertion (referencing config?.optimization?.minimizer) before proceeding to getCode(rsbuild) to keep behavior consistent with the "basic usage" and "optimize background code" tests.
40-79: Consider restoring stubbed environment after test.
vi.stubEnv('NODE_ENV', 'production')modifies the environment but isn't explicitly restored. While vitest may handle cleanup between tests, explicitly usingvi.unstubAllEnvs()in anafterEachor usingvi.stubEnvwithin a scoped context would be more robust and prevent potential test pollution.♻️ Suggested improvement
Add cleanup at the describe level:
import { afterEach, describe, expect, test, vi } from 'vitest' describe('optimizeBundleSize', () => { afterEach(() => { vi.unstubAllEnvs() }) // ... tests })🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/rspeedy/plugin-react/test/optimizeBundleSize.test.ts` around lines 40 - 79, The test stubs NODE_ENV via vi.stubEnv('NODE_ENV', 'production') but never restores it; add a teardown to call vi.unstubAllEnvs() (or vi.unstubEnv('NODE_ENV')) in an afterEach/afterAll for this test suite (e.g., inside the describe that wraps the optimizeBundleSize tests) so that vi.stubEnv is undone after each test and prevents environment leakage.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/rspeedy/plugin-react/test/optimizeBundleSize.test.ts`:
- Around line 132-179: Add the same snapshot assertion used in the other tests
to verify the minimizer config: after creating rsbuild (or after calling
initConfigs() if that returns the config) capture the build config and call
expect(config?.optimization?.minimizer).toMatchSnapshot(); locate the "optimize
main-thread code" test and add this single-line assertion (referencing
config?.optimization?.minimizer) before proceeding to getCode(rsbuild) to keep
behavior consistent with the "basic usage" and "optimize background code" tests.
- Around line 40-79: The test stubs NODE_ENV via vi.stubEnv('NODE_ENV',
'production') but never restores it; add a teardown to call vi.unstubAllEnvs()
(or vi.unstubEnv('NODE_ENV')) in an afterEach/afterAll for this test suite
(e.g., inside the describe that wraps the optimizeBundleSize tests) so that
vi.stubEnv is undone after each test and prevents environment leakage.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: dcf584ba-f97b-487d-882e-59ca5ffd9442
⛔ Files ignored due to path filters (1)
packages/rspeedy/plugin-react/test/__snapshots__/optimizeBundleSize.test.ts.snapis excluded by!**/*.snap
📒 Files selected for processing (4)
.changeset/react-rsbuild-plugin-optimize-bundle-size.mdpackages/rspeedy/plugin-react/src/optimizeBundleSize.tspackages/rspeedy/plugin-react/src/pluginReactLynx.tspackages/rspeedy/plugin-react/test/optimizeBundleSize.test.ts
✅ Files skipped from review due to trivial changes (1)
- .changeset/react-rsbuild-plugin-optimize-bundle-size.md
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/rspeedy/plugin-react/test/optimizeBundleSize.test.ts`:
- Line 222: This test calls getCode(rsbuild) but omits the snapshot assertion
present in tests 1–2; add a snapshot check that captures the merged minimizer
configuration (extract from mainThreadCode and/or backgroundCode returned by
getCode) so regressions are detected — mirror the pattern used in the earlier
tests by asserting the minimizer config (or the full
mainThreadCode/backgroundCode string if those tests do) with
expect(...).toMatchSnapshot().
- Line 168: The test calls getCode(rsbuild) to extract mainThreadCode and
backgroundCode but omits the snapshot assertion used in other tests; add an
assertion like expect(config?.optimization?.minimizer).toMatchSnapshot()
(matching the pattern used in Tests 1 and 2) after obtaining the build output so
the minimizer configuration is captured consistently—look for the
getCode(rsbuild) call and add the snapshot assertion referencing
config?.optimization?.minimizer to the same test.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: b6776a15-8b3e-43d3-aa51-34633089e9c1
⛔ Files ignored due to path filters (1)
packages/rspeedy/plugin-react/test/__snapshots__/optimizeBundleSize.test.ts.snapis excluded by!**/*.snap
📒 Files selected for processing (5)
.changeset/react-rsbuild-plugin-optimize-bundle-size.mdpackages/rspeedy/plugin-react/etc/react-rsbuild-plugin.api.mdpackages/rspeedy/plugin-react/src/optimizeBundleSize.tspackages/rspeedy/plugin-react/src/pluginReactLynx.tspackages/rspeedy/plugin-react/test/optimizeBundleSize.test.ts
✅ Files skipped from review due to trivial changes (1)
- .changeset/react-rsbuild-plugin-optimize-bundle-size.md
🚧 Files skipped from review as they are similar to previous changes (2)
- packages/rspeedy/plugin-react/src/pluginReactLynx.ts
- packages/rspeedy/plugin-react/src/optimizeBundleSize.ts
upupming
reviewed
Mar 23, 2026
…ain-thread and background
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
packages/rspeedy/plugin-react/test/optimizeBundleSize.test.ts (1)
132-179:⚠️ Potential issue | 🟡 MinorAdd minimizer snapshot assertions in the last two tests for consistency.
Line 168 and Line 222 run builds but don’t snapshot
config?.optimization?.minimizer, unlike earlier cases. This reduces regression visibility for config merge behavior.📸 Proposed consistency update
test('optimize main-thread code', async () => { @@ const rsbuild = await createRspeedy({ @@ }) + const [config] = await rsbuild.initConfigs() + expect(config?.optimization?.minimizer).toMatchSnapshot() + const { mainThreadCode, backgroundCode } = await getCode(rsbuild) @@ test('merge backgroundOptions and mainThreadOptions', async () => { @@ const rsbuild = await createRspeedy({ @@ }) + const [config] = await rsbuild.initConfigs() + expect(config?.optimization?.minimizer).toMatchSnapshot() + const { mainThreadCode, backgroundCode } = await getCode(rsbuild)Also applies to: 181-232
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/rspeedy/plugin-react/test/optimizeBundleSize.test.ts` around lines 132 - 179, Add snapshot assertions for the merged minimizer config in the two tests that currently run builds but don’t assert it (including the test titled "optimize main-thread code"); after creating the rsbuild (from createRspeedy) and/or after getCode, capture rsbuild.config?.optimization?.minimizer and add an expectation to matchSnapshot so the merged minimizer options are snapshotted (reference createRspeedy, pluginReactLynx, and getCode to locate where to insert the expect for config?.optimization?.minimizer).
🧹 Nitpick comments (2)
packages/rspeedy/plugin-react/test/optimizeBundleSize.test.ts (2)
14-18: Preserve build error details in the failure path.
getCodecurrently drops the original exception, which makes CI failures harder to debug.🛠️ Proposed tweak
async function getCode(rsbuild: RspeedyInstance) { try { await rsbuild.build() - } catch (_error) { - expect.fail('build should succeed') + } catch (error) { + expect.fail( + `build should succeed: ${ + error instanceof Error ? (error.stack ?? error.message) : String(error) + }`, + ) }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/rspeedy/plugin-react/test/optimizeBundleSize.test.ts` around lines 14 - 18, The test currently swallows the original build exception in the catch for awaiting rsbuild.build() (and getCode appears to drop exceptions elsewhere); modify the catch to preserve and surface the error details by using the caught error (rename _error to error) and include error.message and/or error.stack in the expect.fail call (or rethrow the error) so the full failure details from rsbuild.build() (and from getCode) are available in CI logs.
47-48: UsefileURLToPathinstead of.pathnamefor fixture paths.Using
new URL(...).pathnamecan produce incorrect OS-specific paths (notably Windows and encoded characters). PreferfileURLToPath.🌐 Proposed cross-platform fix
import { existsSync, readFileSync } from 'node:fs' import path from 'node:path' +import { fileURLToPath } from 'node:url' @@ - main: new URL('./fixtures/pure-funcs/basic.js', import.meta.url) - .pathname, + main: fileURLToPath( + new URL('./fixtures/pure-funcs/basic.js', import.meta.url), + ), @@ - main: new URL('./fixtures/pure-funcs/basic.js', import.meta.url) - .pathname, + main: fileURLToPath( + new URL('./fixtures/pure-funcs/basic.js', import.meta.url), + ), @@ - main: new URL('./fixtures/pure-funcs/basic.js', import.meta.url) - .pathname, + main: fileURLToPath( + new URL('./fixtures/pure-funcs/basic.js', import.meta.url), + ), @@ - main: new URL('./fixtures/pure-funcs/basic.js', import.meta.url) - .pathname, + main: fileURLToPath( + new URL('./fixtures/pure-funcs/basic.js', import.meta.url), + ),Also applies to: 89-90, 140-141, 189-190
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/rspeedy/plugin-react/test/optimizeBundleSize.test.ts` around lines 47 - 48, Replace uses of new URL(...).pathname with fileURLToPath(new URL(...)) to ensure correct cross-platform fixture paths; import fileURLToPath from 'node:url' and update each occurrence (the object properties named "main" where fixtures are referenced in optimizeBundleSize.test.ts, e.g., the new URL('./fixtures/pure-funcs/basic.js', import.meta.url).pathname instances and the other two similar occurrences mentioned) so tests use fileURLToPath(new URL(...)) instead of .pathname.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/rspeedy/plugin-react/test/optimizeBundleSize.test.ts`:
- Line 7: Tests in optimizeBundleSize.test.ts call vi.stubEnv('NODE_ENV',
'production') in multiple tests but never restore the environment, causing state
leakage; add an afterEach hook to call vi.unstubAllEnvs() (and import afterEach
from 'vitest' if not already) so each test resets stubbed env vars, e.g. add
afterEach(() => vi.unstubAllEnvs()) alongside existing imports and tests to
ensure clean state between tests that use vi.stubEnv.
---
Duplicate comments:
In `@packages/rspeedy/plugin-react/test/optimizeBundleSize.test.ts`:
- Around line 132-179: Add snapshot assertions for the merged minimizer config
in the two tests that currently run builds but don’t assert it (including the
test titled "optimize main-thread code"); after creating the rsbuild (from
createRspeedy) and/or after getCode, capture
rsbuild.config?.optimization?.minimizer and add an expectation to matchSnapshot
so the merged minimizer options are snapshotted (reference createRspeedy,
pluginReactLynx, and getCode to locate where to insert the expect for
config?.optimization?.minimizer).
---
Nitpick comments:
In `@packages/rspeedy/plugin-react/test/optimizeBundleSize.test.ts`:
- Around line 14-18: The test currently swallows the original build exception in
the catch for awaiting rsbuild.build() (and getCode appears to drop exceptions
elsewhere); modify the catch to preserve and surface the error details by using
the caught error (rename _error to error) and include error.message and/or
error.stack in the expect.fail call (or rethrow the error) so the full failure
details from rsbuild.build() (and from getCode) are available in CI logs.
- Around line 47-48: Replace uses of new URL(...).pathname with
fileURLToPath(new URL(...)) to ensure correct cross-platform fixture paths;
import fileURLToPath from 'node:url' and update each occurrence (the object
properties named "main" where fixtures are referenced in
optimizeBundleSize.test.ts, e.g., the new URL('./fixtures/pure-funcs/basic.js',
import.meta.url).pathname instances and the other two similar occurrences
mentioned) so tests use fileURLToPath(new URL(...)) instead of .pathname.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d7544d4e-f6bb-4d0c-afc7-60d5e98d7d21
⛔ Files ignored due to path filters (1)
packages/rspeedy/plugin-react/test/__snapshots__/optimizeBundleSize.test.ts.snapis excluded by!**/*.snap
📒 Files selected for processing (6)
.changeset/react-rsbuild-plugin-optimize-bundle-size.mdpackages/rspeedy/plugin-config/package.jsonpackages/rspeedy/plugin-react/etc/react-rsbuild-plugin.api.mdpackages/rspeedy/plugin-react/src/optimizeBundleSize.tspackages/rspeedy/plugin-react/src/pluginReactLynx.tspackages/rspeedy/plugin-react/test/optimizeBundleSize.test.ts
✅ Files skipped from review due to trivial changes (3)
- .changeset/react-rsbuild-plugin-optimize-bundle-size.md
- packages/rspeedy/plugin-config/package.json
- packages/rspeedy/plugin-react/src/pluginReactLynx.ts
🚧 Files skipped from review as they are similar to previous changes (2)
- packages/rspeedy/plugin-react/etc/react-rsbuild-plugin.api.md
- packages/rspeedy/plugin-react/src/optimizeBundleSize.ts
upupming
reviewed
Mar 24, 2026
upupming
approved these changes
Mar 24, 2026
Collaborator
|
LGTM, but small questions |
colinaaa
pushed a commit
that referenced
this pull request
Apr 6, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @lynx-js/rspeedy@0.14.0 ### Minor Changes - feat: add `Minify.mainThreadOptions` and `Minify.backgroundOptions` for thread-specific minifier. ([#2336](#2336)) ### Patch Changes - Bump Rsbuild v1.7.4 with Rspack v1.7.10. ([#2384](#2384)) - Updated dependencies \[]: - @lynx-js/web-rsbuild-server-middleware@0.20.0 ## @lynx-js/lynx-bundle-rslib-config@0.3.0 ### Minor Changes - **BREAKING CHANGE**: ([#2370](#2370)) Simplify the API for external bundle builds by `externalsPresets` and `externalsPresetDefinitions`. ### Patch Changes - Preserve the default external-bundle `output.minify.jsOptions` when users set `output.minify: true` in `defineExternalBundleRslibConfig`, so required minifier options are not lost. ([#2390](#2390)) ## @lynx-js/external-bundle-rsbuild-plugin@0.1.0 ### Minor Changes - **BREAKING CHANGE**: ([#2370](#2370)) Simplify the API for external bundle builds by `externalsPresets` and `externalsPresetDefinitions`. ### Patch Changes - Updated dependencies \[[`7b7a0c6`](7b7a0c6)]: - @lynx-js/externals-loading-webpack-plugin@0.1.0 ## @lynx-js/react-rsbuild-plugin@0.14.0 ### Minor Changes - feat: support `optimizeBundleSize` option to remove unused code for main-thread and background. ([#2336](#2336)) - If `optimizeBundleSize` is `true` or `optimizeBundleSize.background` is `true`, `lynx.registerDataProcessors` calls will be marked as pure for the background thread output. - If `optimizeBundleSize` is `true` or `optimizeBundleSize.mainThread` is `true`, `NativeModules.call` and `lynx.getJSModule` calls will be marked as pure for the main-thread output. ### Patch Changes - refactor: remove `modifyWebpackChain` since Rsbuild 2.0 dropped webpack support ([#2397](#2397)) - Updated dependencies \[[`9193711`](9193711)]: - @lynx-js/template-webpack-plugin@0.10.7 - @lynx-js/css-extract-webpack-plugin@0.7.0 - @lynx-js/react-webpack-plugin@0.8.0 - @lynx-js/react-alias-rsbuild-plugin@0.14.0 - @lynx-js/use-sync-external-store@1.5.0 - @lynx-js/react-refresh-webpack-plugin@0.3.5 ## @lynx-js/web-core@0.20.0 ### Minor Changes - **This is a breaking change** ([#2322](#2322)) ## Architectural Upgrade: `web-core-wasm` replaces `web-core` This release marks a major architectural upgrade for the web platform. The experimental, WASM-powered engine formerly known as `web-core-wasm` has been fully stabilized and merged into the main branch, completely replacing the previous pure JS/TS based `web-core` implementation. This consolidation massively improves execution performance and aligns the API boundaries of the Web platform directly with other native Lynx implementations. ### 🎉 Added Features - **Core API Enhancements**: Successfully exposed and supported `__QuerySelector` and `__InvokeUIMethod` methods. - **Security & CSP Compliance**: Added a `nonce` attribute to the iframe's `srcdoc` script execution, strengthening Content Security Policy (CSP) compliance. - **`<lynx-view>` Parameter Enhancements**: - Added the `browser-config` attribute and property to `<lynx-view>`. Development environments can now supply a `BrowserConfig` object (e.g., configuring `pixelRatio`, `pixelWidth`, `pixelHeight`) allowing the `systemInfo` payload to be dynamically configured at the instance level. ### 🔄 Changed Features - **Legacy JSON Backwards Compatibility**: Delivered comprehensive fixes and optimizations to deeply support legacy JSON output templates: - Added support for lazy loading execution mode (`lazy usage`). - Implemented the correct decoding and handling of `@keyframe` animation rules. - Rectified rule scoping matching including scoped CSS, root selectors, and type selectors. - **Ecosystem Migration**: Updated testing and ecosystem applications (such as `web-explorer` and `shell-project`) to migrate away from obsolete fragmented dependencies. The new WASM architecture seamlessly integrates Element APIs and CSS directly inside the core client module, requiring a much simpler initialization footprint. **Before (Legacy `web-core` + `web-elements`):** ```typescript // Required multiple imports to assemble the environment import "@lynx-js/web-core/client"; import type { LynxViewElement as LynxView } from "@lynx-js/web-core"; // Had to manually import separate elements and their CSS import "@lynx-js/web-elements/index.css"; import "@lynx-js/web-elements/all"; const lynxView = document.createElement("lynx-view") as LynxView; // ... ``` **After (New `web-core` unified architecture):** ```typescript // The new engine natively registers Web Components and injects fundamental CSS import "@lynx-js/web-core/client"; import type { LynxViewElement as LynxView } from "@lynx-js/web-core/client"; const lynxView = document.createElement("lynx-view") as LynxView; // ... ``` _(Applications can now drop `@lynx-js/web-elements` entirely from their `package.json` dependencies)._ - **Dependency & Boot Sequence Improvements**: Re-architected module loading pathways. Promoted `wasm-feature-detect` directly to a core dependency, and hardened the web worker count initialization assertions. - **Initialization Optimizations**: Converted `SERVER_IN_SHADOW_CSS` initialization bounds to use compilation-time constant expressions for better optimization. ### 🗑️ Deleted Features & Structural Deprecations - **`<lynx-view>` Parameter Removals**: - Removed the `thread-strategy` property and attribute. Historically, this permitted consumers to toggle between `'multi-thread'` and `'all-on-ui'` modes depending on how they wanted the background logic to be executed. The WASM-driven architecture enforces a consolidated concurrency model, deprecating this `<lynx-view>` attribute entirely. - Removed the `overrideLynxTagToHTMLTagMap` property/attribute. HTML tag overriding mechanism has been deprecated in the new engine. - Removed the `customTemplateLoader` property handler from `<lynx-view>`. - Removed the `inject-head-links` property and attribute (`injectHeadLinks`), which previously was used to automatically inject `<link rel="stylesheet">` tags from the document head into the `lynx-view` shadow root. - **Fragmented Packages Removal**: The new cohesive WASM architecture native to `@lynx-js/web-core` handles cross-thread communication, worker boundaries, and rendering loops uniformly. Consequently, multiple obsolete packages have been completely removed from the workspace: - `@lynx-js/web-mainthread-apis` - `@lynx-js/web-worker-runtime` - `@lynx-js/web-core-server` - `@lynx-js/web-core-wasm-e2e` (transitioned into standard test suites) - Added support for `rpx` unit ([#2377](#2377)) **This is a breaking change** The following Styles has been added to `web-core` ```css lynx-view { width: 100%; container-name: lynx-view; container-type: inline-size; --rpx-unit: 1cqw; } ``` Check MDN for the details about these styles: - <https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Properties/container-name> - <https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Properties/container-type> - <https://developer.mozilla.org/en-US/docs/Web/CSS/Guides/Containment/Container_queries> ### how it works? For the following code ```html <view style="height:1rpx"></view> ``` it will be transformed to ```html <view style="height:calc(1 * var(--rpx-unit))"></view> ``` Therefore you could use any `<length>` value to replace the unit, for example: ```html <lynx-view style="--rpx-unit:1px"></lynx-view> ``` By default, the --rpx-unit value is `1cqw` - Added support for transform `vw` and `vh` unit ([#2377](#2377)) Add `transform-vw` and `transform-vh` attributes and properties on `<lynx-view>`. For the following code ```html <view style="height:1vw"></view> ``` If the `transform-vw` is enabled `<lynx-view transform-vw="true">`, it will be transformed to ```html <view style="height:calc(1 * var(--vw-unit))"></view> ``` Therefore you could use any `<length>` value to replace the unit, for example: ```html <lynx-view style="--vw-unit:1px"></lynx-view> ``` ### Patch Changes - feat(web-core): add `is_bubble` parameter to `common_event_handler` to properly handle non-bubbling events like `window.Event('click', { bubbles: false })`. ([#2399](#2399)) - chore: update readme ([#2380](#2380)) - fix: the output format should be module ([#2388](#2388)) - opt: use opt-level 3 to compile wasm ([#2371](#2371)) - fix(web-core): avoid partial bundle loading and double fetching when fetchBundle is called concurrently for the same url. ([#2386](#2386)) - fix(web-core): fallback to the original export chunk when `processEvalResult` is absent during `queryComponent` execution ([#2399](#2399)) - fix: tokenizing inline style values correctly to support rpx and ppx unit conversion ([#2381](#2381)) This fixes an issue where the `transform_inline_style_key_value_vec` API bypassed the CSS tokenizer, preventing dimension units like `rpx` or `ppx` from being successfully transformed into `calc` strings when specified via inline styles. - feat: add mts lynx.querySelectorAll API ([#2382](#2382)) - fix: mts in lazy component ([#2375](#2375)) - fix: enableJSDataProcessor not work ([#2372](#2372)) - feat: add `ppx` unit support for CSS, transforming to `calc(... * var(--ppx-unit))` directly. ([#2381](#2381)) - Updated dependencies \[]: - @lynx-js/web-worker-rpc@0.20.0 ## @lynx-js/externals-loading-webpack-plugin@0.1.0 ### Minor Changes - **BREAKING CHANGE**: ([#2370](#2370)) Simplify the API for external bundle builds by `externalsPresets` and `externalsPresetDefinitions`. ## @lynx-js/devtool-connector@0.1.1 ### Patch Changes - fix: align GlobalKeys with Android DevToolSettings keys and filter global switch responses ([#2392](#2392)) ## @lynx-js/devtool-mcp-server@0.5.1 ### Patch Changes - Updated dependencies \[[`95fff27`](95fff27)]: - @lynx-js/devtool-connector@0.1.1 ## @lynx-js/react@0.117.1 ### Patch Changes - Update preact version to simplify `setProperty` implementation ([#2367](#2367)) ## @lynx-js/react-umd@0.117.1 ### Patch Changes - Add a new `entry` export to `@lynx-js/react-umd` for reuse by wrapper libraries of `@lynx-js/react`. ([#2370](#2370)) ## create-rspeedy@0.14.0 ### Patch Changes - Add optional Lynx DevTool skill. ([#2421](#2421)) - move Vitest integration to create-rstack extraTools and merge the Vitest templates into a single incremental overlay ([#2408](#2408)) ## @lynx-js/kitten-lynx-test-infra@0.1.2 ### Patch Changes - Updated dependencies \[[`95fff27`](95fff27)]: - @lynx-js/devtool-connector@0.1.1 ## @lynx-js/template-webpack-plugin@0.10.7 ### Patch Changes - use path.posix.format instead of path.format to ensure consistent path separators across platforms ([#2359](#2359)) - Updated dependencies \[[`75960cd`](75960cd), [`518c310`](518c310), [`863469e`](863469e), [`dc18c5c`](dc18c5c), [`7d242f3`](7d242f3), [`62bebcf`](62bebcf), [`75960cd`](75960cd), [`182f568`](182f568), [`1aa051d`](1aa051d), [`6b46f7e`](6b46f7e), [`fcda36a`](fcda36a), [`182f568`](182f568), [`138f727`](138f727), [`138f727`](138f727)]: - @lynx-js/web-core@0.20.0 ## @lynx-js/react-alias-rsbuild-plugin@0.14.0 ## upgrade-rspeedy@0.14.0 ## @lynx-js/web-rsbuild-server-middleware@0.20.0 ## @lynx-js/web-worker-rpc@0.20.0 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Checklist