fix(devtool-connector): align global switch keys and filter responses#2392
Conversation
🦋 Changeset detectedLatest commit: 04875a8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe pull request extends the devtool connector to support additional global configuration keys and adds response filtering to global switch operations through new type guards, aligning the implementation with Android DevToolSettings keys. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Merging this PR will degrade performance by 10.09%
Performance Changes
Comparing Footnotes
|
Web Explorer#8481 Bundle Size — 728.55KiB (0%).04875a8(current) vs 6b3cc12 main#8480(baseline) Bundle metrics
|
| Current #8481 |
Baseline #8480 |
|
|---|---|---|
43.29KiB |
43.29KiB |
|
2.16KiB |
2.16KiB |
|
0% |
0% |
|
8 |
8 |
|
10 |
10 |
|
149 |
149 |
|
11 |
11 |
|
34.69% |
34.69% |
|
3 |
3 |
|
0 |
0 |
Bundle size by type no changes
| Current #8481 |
Baseline #8480 |
|
|---|---|---|
384.4KiB |
384.4KiB |
|
342KiB |
342KiB |
|
2.16KiB |
2.16KiB |
Bundle analysis report Branch colinaaa:colin/devtool-connector... Project dashboard
Generated by RelativeCI Documentation Report issue
React MTF Example#37 Bundle Size — 207.47KiB (0%).04875a8(current) vs 6b3cc12 main#36(baseline) Bundle metrics
|
| Current #37 |
Baseline #36 |
|
|---|---|---|
0B |
0B |
|
0B |
0B |
|
0% |
0% |
|
0 |
0 |
|
3 |
3 |
|
174 |
174 |
|
68 |
68 |
|
46.09% |
46.09% |
|
2 |
2 |
|
0 |
0 |
Bundle size by type no changes
| Current #37 |
Baseline #36 |
|
|---|---|---|
111.23KiB |
111.23KiB |
|
96.24KiB |
96.24KiB |
Bundle analysis report Branch colinaaa:colin/devtool-connector... Project dashboard
Generated by RelativeCI Documentation Report issue
React Example#6903 Bundle Size — 237.89KiB (0%).04875a8(current) vs 6b3cc12 main#6902(baseline) Bundle metrics
|
| Current #6903 |
Baseline #6902 |
|
|---|---|---|
0B |
0B |
|
0B |
0B |
|
0% |
0% |
|
0 |
0 |
|
4 |
4 |
|
180 |
180 |
|
71 |
71 |
|
46.4% |
46.4% |
|
2 |
2 |
|
0 |
0 |
Bundle size by type no changes
| Current #6903 |
Baseline #6902 |
|
|---|---|---|
145.76KiB |
145.76KiB |
|
92.13KiB |
92.13KiB |
Bundle analysis report Branch colinaaa:colin/devtool-connector... Project dashboard
Generated by RelativeCI Documentation Report issue
Summary
GlobalKeysin devtool connector with the full AndroidDevToolSettingskey listGetGlobalSwitchandSetGlobalSwitchto avoid consuming unrelated customized events@lynx-js/devtool-connectorpatch releaseVerification
pnpm --filter @lynx-js/devtool-connector buildSummary by CodeRabbit
Release Notes
Bug Fixes
New Features