Skip to content

chore(ci): rename windows runner#2326

Merged
deanjingshui merged 1 commit intomainfrom
p/deanjingshui/update-windows-runner
Mar 10, 2026
Merged

chore(ci): rename windows runner#2326
deanjingshui merged 1 commit intomainfrom
p/deanjingshui/update-windows-runner

Conversation

@deanjingshui
Copy link
Copy Markdown
Collaborator

@deanjingshui deanjingshui commented Mar 10, 2026

delete the verify suffix of windows runner

Summary by CodeRabbit

  • Chores
    • Updated CI/CD runner configurations across build pipelines.

delete the verify suffix of windows runner
Copilot AI review requested due to automatic review settings March 10, 2026 07:44
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 10, 2026

⚠️ No Changeset found

Latest commit: 59f6687

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 50d38a01-6274-4a43-aa04-d43235867ba4

📥 Commits

Reviewing files that changed from the base of the PR and between d034dae and 59f6687.

📒 Files selected for processing (3)
  • .github/workflows/rust.yml
  • .github/workflows/test.yml
  • .github/workflows/workflow-build.yml

📝 Walkthrough

Walkthrough

This PR updates the Windows runner label across three GitHub Actions workflow files from "lynx-windows-2022-large-verify" to "lynx-windows-2022-large". All changes are minimal configuration updates with no functional or control-flow modifications.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow Updates
.github/workflows/rust.yml, .github/workflows/test.yml, .github/workflows/workflow-build.yml
Updated Windows runner label in matrix configurations from lynx-windows-2022-large-verify to lynx-windows-2022-large across all three workflow files.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • colinaaa
  • HuJean

Poem

🐰 A runner's label, simplified with care,
"Verify" removed, the label now spare,
Three workflows aligned, in harmony they sing,
Small changes, big purpose—the updates take wing! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: renaming the Windows runner by removing the 'verify' suffix across CI workflow files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch p/deanjingshui/update-windows-runner

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Renames the Windows self-hosted runner label used in CI workflows by removing the -verify suffix, keeping runner naming consistent across the repo.

Changes:

  • Update Windows runner label in the Build workflow matrix.
  • Update Windows runner label in the Vitest job matrix.
  • Update the (commented) Windows runner label in the Rust workflow for consistency.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
.github/workflows/workflow-build.yml Updates Windows matrix runner label to the new name.
.github/workflows/test.yml Updates Vitest Windows matrix runner label to the new name.
.github/workflows/rust.yml Updates the commented Windows runner label reference to the new name.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 10, 2026

Merging this PR will degrade performance by 13.04%

❌ 1 regressed benchmark
✅ 71 untouched benchmarks
⏩ 3 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
transform 1000 view elements 40.4 ms 46.5 ms -13.04%

Comparing p/deanjingshui/update-windows-runner (59f6687) with main (d034dae)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@relativeci
Copy link
Copy Markdown

relativeci bot commented Mar 10, 2026

Web Explorer

#8086 Bundle Size — 384.5KiB (0%).

59f6687(current) vs d034dae main#8076(baseline)

Bundle metrics  Change 1 change
                 Current
#8086
     Baseline
#8076
No change  Initial JS 155.59KiB 155.59KiB
No change  Initial CSS 35.1KiB 35.1KiB
No change  Cache Invalidation 0% 0%
No change  Chunks 8 8
No change  Assets 8 8
Change  Modules 238(-0.42%) 239
No change  Duplicate Modules 16 16
No change  Duplicate Code 2.98% 2.98%
No change  Packages 4 4
No change  Duplicate Packages 0 0
Bundle size by type  no changes
                 Current
#8086
     Baseline
#8076
No change  JS 253.55KiB 253.55KiB
No change  Other 95.85KiB 95.85KiB
No change  CSS 35.1KiB 35.1KiB

Bundle analysis reportBranch p/deanjingshui/update-windows-ru...Project dashboard


Generated by RelativeCIDocumentationReport issue

@deanjingshui deanjingshui merged commit c11c4c4 into main Mar 10, 2026
80 of 83 checks passed
@deanjingshui deanjingshui deleted the p/deanjingshui/update-windows-runner branch March 10, 2026 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants