Skip to content

chore: change windows runner label#1990

Merged
deanjingshui merged 1 commit intolynx-family:mainfrom
deanjingshui:p/deanjingshui/change-windows-runner-label
Dec 8, 2025
Merged

chore: change windows runner label#1990
deanjingshui merged 1 commit intolynx-family:mainfrom
deanjingshui:p/deanjingshui/change-windows-runner-label

Conversation

@deanjingshui
Copy link
Copy Markdown
Collaborator

@deanjingshui deanjingshui commented Dec 8, 2025

use new label for windows runner

Summary by CodeRabbit

  • Chores
    • Updated CI/CD pipeline configurations for testing and build infrastructure.

✏️ Tip: You can customize this high-level summary in your review settings.

use new label for windows runner
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Dec 8, 2025

⚠️ No Changeset found

Latest commit: 5200ee4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Dec 8, 2025

📝 Walkthrough

Walkthrough

Windows runner labels in GitHub workflows are updated from lynx-windows-2022-large to lynx-windows-2022-large-verify across multiple CI/CD configuration files, affecting runner selection for Windows jobs without changing control flow or logic.

Changes

Cohort / File(s) Summary
GitHub Workflow Runner Updates
\\.github/workflows/rust.yml, \\.github/workflows/test.yml, \\.github/workflows/workflow-build.yml
Windows runner label changed from lynx-windows-2022-large to lynx-windows-2022-large-verify in matrix configurations. No logic or control flow modifications; purely declarative matrix updates affecting runner image selection.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Homogeneous, repetitive changes across all files (identical pattern)
  • Declarative configuration updates with no logic implications
  • Single-line edits per file with consistent pattern

Suggested reviewers

  • PupilTong
  • colinaaa

Poem

🐰 A rabbit hops through workflows fast,
Labels updated, runners recast,
From large to verify, the path now gleams,
Windows jobs run on verified dreams!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: change windows runner label' accurately describes the main change—updating Windows runner labels across three workflow files from lynx-windows-2022-large to lynx-windows-2022-large-verify.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f782057 and 5200ee4.

📒 Files selected for processing (3)
  • .github/workflows/rust.yml (1 hunks)
  • .github/workflows/test.yml (1 hunks)
  • .github/workflows/workflow-build.yml (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-12T09:43:04.847Z
Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, empty changeset files (containing only `---\n\n---`) are used for internal changes that modify src/** files but don't require meaningful release notes, such as private package changes or testing-only modifications. This satisfies CI requirements without generating user-facing release notes.

Applied to files:

  • .github/workflows/rust.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: build / Build (Ubuntu)
  • GitHub Check: build / Build (Windows)
  • GitHub Check: test-rust / Test (Ubuntu)
🔇 Additional comments (3)
.github/workflows/rust.yml (1)

30-31: Label update is consistent; Windows job remains disabled.

The Windows runner label has been updated in the commented-out matrix entry, which is consistent with updates in other workflows. This preserves the current behavior while preparing for potential future enablement of Windows Rust testing.

.github/workflows/workflow-build.yml (1)

75-76: Windows runner label updated in active job.

The label change is straightforward and will take effect immediately for the build-all job. Ensure the new label lynx-windows-2022-large-verify is provisioned and accessible to avoid build failures.

.github/workflows/test.yml (1)

215-216: Ensure the lynx-windows-2022-large-verify runner label exists in your GitHub Actions runner configuration.

The label change from lynx-windows-2022-large to lynx-windows-2022-large-verify is syntactically correct and will be properly interpolated into the job configuration on line 221. Confirm that the new label is provisioned and available in your GitHub runner pool before merging this change, as the workflow will fail at runtime if the label does not exist.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Dec 8, 2025

CodSpeed Performance Report

Merging #1990 will degrade performances by 5.47%

Comparing deanjingshui:p/deanjingshui/change-windows-runner-label (5200ee4) with main (6400f87)1

Summary

❌ 2 regressions
✅ 61 untouched
⏩ 3 skipped2

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
transform 1000 view elements 44 ms 46.5 ms -5.47%
basic-performance-small-css 6.8 ms 7.2 ms -5.22%

Footnotes

  1. No successful run was found on main (f782057) during the generation of this report, so 6400f87 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@relativeci
Copy link
Copy Markdown

relativeci bot commented Dec 8, 2025

Web Explorer

#6538 Bundle Size — 372.73KiB (0%).

5200ee4(current) vs 6400f87 main#6520(baseline)

Bundle metrics  no changes
                 Current
#6538
     Baseline
#6520
No change  Initial JS 146.31KiB 146.31KiB
No change  Initial CSS 32.4KiB 32.4KiB
Change  Cache Invalidation 0% 11.74%
No change  Chunks 8 8
No change  Assets 8 8
No change  Modules 230 230
No change  Duplicate Modules 16 16
No change  Duplicate Code 2.97% 2.97%
No change  Packages 4 4
No change  Duplicate Packages 0 0
Bundle size by type  no changes
                 Current
#6538
     Baseline
#6520
No change  JS 243.35KiB 243.35KiB
No change  Other 96.98KiB 96.98KiB
No change  CSS 32.4KiB 32.4KiB

Bundle analysis reportBranch deanjingshui:p/deanjingshui/chan...Project dashboard


Generated by RelativeCIDocumentationReport issue

@relativeci
Copy link
Copy Markdown

relativeci bot commented Dec 8, 2025

React Example

#6378 Bundle Size — 236.9KiB (0%).

5200ee4(current) vs 6400f87 main#6360(baseline)

Bundle metrics  no changes
                 Current
#6378
     Baseline
#6360
No change  Initial JS 0B 0B
No change  Initial CSS 0B 0B
No change  Cache Invalidation 0% 0%
No change  Chunks 0 0
No change  Assets 4 4
No change  Modules 162 162
No change  Duplicate Modules 65 65
No change  Duplicate Code 46.75% 46.75%
No change  Packages 2 2
No change  Duplicate Packages 0 0
Bundle size by type  no changes
                 Current
#6378
     Baseline
#6360
No change  IMG 145.76KiB 145.76KiB
No change  Other 91.14KiB 91.14KiB

Bundle analysis reportBranch deanjingshui:p/deanjingshui/chan...Project dashboard


Generated by RelativeCIDocumentationReport issue

@deanjingshui deanjingshui merged commit c16859d into lynx-family:main Dec 8, 2025
51 of 52 checks passed
f0rdream pushed a commit to f0rdream/lynx-stack that referenced this pull request Dec 18, 2025
use new label for windows runner

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Chores**
* Updated CI/CD pipeline configurations for testing and build
infrastructure.

<sub>✏️ Tip: You can customize this high-level summary in your review
settings.</sub>

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants