Skip to content

test(webpack/react): remove experimental.layers#1986

Merged
colinaaa merged 2 commits intolynx-family:mainfrom
colinaaa:colin/1207/layers
Dec 10, 2025
Merged

test(webpack/react): remove experimental.layers#1986
colinaaa merged 2 commits intolynx-family:mainfrom
colinaaa:colin/1207/layers

Conversation

@colinaaa
Copy link
Copy Markdown
Collaborator

@colinaaa colinaaa commented Dec 7, 2025

Summary by CodeRabbit

  • Chores
    • Added changeset documentation for version tracking
    • Updated webpack build configuration to remove experimental feature flag

✏️ Tip: You can customize this high-level summary in your review settings.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).
  • Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Dec 7, 2025

🦋 Changeset detected

Latest commit: c911f4f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Dec 7, 2025

📝 Walkthrough

Walkthrough

A new changeset document is added to document the changes, and the experiments.layers configuration is removed from the React webpack plugin's test configuration file. No other configuration paths or functionality are altered.

Changes

Cohort / File(s) Summary
Changeset
\.changeset/icy-berries-shop\.md
New changeset document added with standard Markdown formatting
React Webpack Plugin Test Configuration
packages/webpack/react-webpack-plugin/test/create-react-config\.js
Removed experiments.layers: true configuration block from the test config; module rules, resolve, and plugins remain unchanged

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Straightforward removal of an experimental configuration flag
  • Changeset is a standard template addition
  • No logic density or complex interdependencies

Possibly related PRs

Suggested labels

framework:React

Suggested reviewers

  • upupming
  • luhc228

Poem

A changeset blooms, so light and small,
Experiments fade—one layer falls,
The webpack config breathes anew,
No layers needed, just the true! 🐰✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: removing the experimental.layers configuration from the React webpack plugin test file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@colinaaa colinaaa requested a review from upupming as a code owner December 10, 2025 06:11
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Dec 10, 2025

CodSpeed Performance Report

Merging #1986 will not alter performance

Comparing colinaaa:colin/1207/layers (c911f4f) with main (f7256d5)

Summary

✅ 63 untouched
⏩ 3 skipped1

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@relativeci
Copy link
Copy Markdown

relativeci bot commented Dec 10, 2025

Web Explorer

#6584 Bundle Size — 372.9KiB (0%).

c911f4f(current) vs f7256d5 main#6568(baseline)

Bundle metrics  no changes
                 Current
#6584
     Baseline
#6568
No change  Initial JS 146.32KiB 146.32KiB
No change  Initial CSS 32.4KiB 32.4KiB
Change  Cache Invalidation 0% 48.3%
No change  Chunks 8 8
No change  Assets 8 8
No change  Modules 230 230
No change  Duplicate Modules 16 16
No change  Duplicate Code 2.97% 2.97%
No change  Packages 4 4
No change  Duplicate Packages 0 0
Bundle size by type  no changes
                 Current
#6584
     Baseline
#6568
No change  JS 243.52KiB 243.52KiB
No change  Other 96.98KiB 96.98KiB
No change  CSS 32.4KiB 32.4KiB

Bundle analysis reportBranch colinaaa:colin/1207/layersProject dashboard


Generated by RelativeCIDocumentationReport issue

@relativeci
Copy link
Copy Markdown

relativeci bot commented Dec 10, 2025

React Example

#6424 Bundle Size — 236.9KiB (0%).

c911f4f(current) vs f7256d5 main#6408(baseline)

Bundle metrics  no changes
                 Current
#6424
     Baseline
#6408
No change  Initial JS 0B 0B
No change  Initial CSS 0B 0B
No change  Cache Invalidation 0% 0%
No change  Chunks 0 0
No change  Assets 4 4
No change  Modules 162 162
No change  Duplicate Modules 65 65
No change  Duplicate Code 46.74% 46.74%
No change  Packages 2 2
No change  Duplicate Packages 0 0
Bundle size by type  no changes
                 Current
#6424
     Baseline
#6408
No change  IMG 145.76KiB 145.76KiB
No change  Other 91.14KiB 91.14KiB

Bundle analysis reportBranch colinaaa:colin/1207/layersProject dashboard


Generated by RelativeCIDocumentationReport issue

@colinaaa colinaaa merged commit 47cc2bc into lynx-family:main Dec 10, 2025
112 of 118 checks passed
@colinaaa colinaaa deleted the colin/1207/layers branch December 10, 2025 07:31
f0rdream pushed a commit to f0rdream/lynx-stack that referenced this pull request Dec 18, 2025
<!--
  Thank you for submitting a pull request!

We appreciate the time and effort you have invested in making these
changes. Please ensure that you provide enough information to allow
others to review your pull request.

Upon submission, your pull request will be automatically assigned with
reviewers.

If you want to learn more about contributing to this project, please
visit:
https://github.com/lynx-family/lynx-stack/blob/main/CONTRIBUTING.md.
-->

<!-- The AI summary below will be auto-generated - feel free to replace
it with your own. -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Chores**
  * Added changeset documentation for version tracking
* Updated webpack build configuration to remove experimental feature
flag

<sub>✏️ Tip: You can customize this high-level summary in your review
settings.</sub>
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

## Checklist

<!--- Check and mark with an "x" -->

- [ ] Tests updated (or not required).
- [ ] Documentation updated (or not required).
- [ ] Changeset added, and when a BREAKING CHANGE occurs, it needs to be
clearly marked (or not required).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants