feat(rspeedy/core)!: remove webpack support #1432

colinaaa · 2025-08-05T08:01:46Z

Summary by CodeRabbit

Chores
- Removed the experimental provider option from configuration settings.
- Cleaned up related documentation and example comments.
- Deleted dependencies related to Webpack from development environments.
Tests
- Removed test cases and suites specific to the Webpack provider to reflect updated configuration options.

This would help us:

Upgrade TypeScript (chore(deps): update dependency typescript to v5.9.2 - autoclosed #1417)
Upgrade Rsbuild plugins (chore(deps): update rsbuild #1414)

But this does not seem to fix the error in #1418, which should be caused by upgrading Webpack.

Checklist

Tests updated (or not required).
Documentation updated (or not required).
Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

changeset-bot · 2025-08-05T08:01:50Z

🦋 Changeset detected

Latest commit: c26f9bb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@lynx-js/rspeedy	Patch
create-rspeedy	Patch
upgrade-rspeedy	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2025-08-05T08:01:53Z

📝 Walkthrough

Walkthrough

This change removes the experimental provider option from the @lynx-js/rspeedy package. All related code, documentation, and tests referencing the provider property—particularly those supporting the Webpack provider—have been deleted. Associated dependencies on @rsbuild/webpack have also been removed from relevant package files.

Changes

Cohort / File(s)	Change Summary
Remove provider option from core config and API `packages/rspeedy/core/src/config/index.ts`, `packages/rspeedy/core/etc/rspeedy.api.md`	Removed the `provider` property and documentation from the `Config` interface and API docs.
Remove provider logic from Rsbuild config `packages/rspeedy/core/src/config/rsbuild/index.ts`	Removed the `provider` property from the object returned by `toRsbuildConfig`.
Remove provider-related tests `packages/rspeedy/core/test/plugins/chunkLoading.plugin.test.ts`, `packages/rspeedy/plugin-react/test/css.test.ts`, `packages/rspeedy/plugin-react/test/swc-config.test.ts`	Deleted tests related to the Webpack provider and its plugins.
Remove @rsbuild/webpack dependency `packages/rspeedy/core/package.json`, `packages/rspeedy/plugin-react/package.json`	Removed `@rsbuild/webpack` from `devDependencies` in both core and plugin-react packages.
Remove changeset documentation `.changeset/better-candies-type.md`	Removed documentation referencing the experimental provider option.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

hzy

Poem

A bunny hopped through fields of code,
Removing "provider" from every node.
No more Webpack tests to run,
The Rspeedy core is now more fun!
With dependencies trimmed and docs made neat,
This change is tidy, clean, and sweet.
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dc8d49a and 18a09bd.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (1)

packages/rspeedy/core/package.json (0 hunks)

💤 Files with no reviewable changes (1)

packages/rspeedy/core/package.json

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

GitHub Check: build / Build (Windows)
GitHub Check: build / Build (Ubuntu)
GitHub Check: CodeQL Analyze (javascript-typescript)

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-08-05T08:15:21Z

❌ 6 Tests Failed:

Tests completed	Failed	Passed	Skipped
3242	6	3236	81

View the top 3 failed test(s) by shortest run time

react.spec.ts::reactlynx3 tests › basic › basic-mts-bindtouchstart

Stack Traces | 5.35s run time

react.spec.ts:352:5 basic-mts-bindtouchstart

react.spec.ts::reactlynx3 tests › basic › basic-mts-mainthread-nested-ref

Stack Traces | 30.5s run time

react.spec.ts:390:5 basic-mts-mainthread-nested-ref

react.spec.ts::reactlynx3 tests › basic › basic-mts-run-on-background

Stack Traces | 150s run time

react.spec.ts:406:5 basic-mts-run-on-background

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

codspeed-hq · 2025-08-05T08:20:01Z

CodSpeed Performance Report

Merging #1432 will not alter performance

_{Comparing colinaaa:colin/0805/remove-webpack (c26f9bb) with main (29434ae)}

Summary

✅ 10 untouched benchmarks

relativeci · 2025-08-05T08:34:45Z

React Example

#3732 Bundle Size — 235.14KiB (-0.05%).

c26f9bb(current) vs 7032f42 main#3731(baseline)

Bundle metrics

4 changes

1 improvement

	Current #3732	Baseline #3731
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`38.04%`	`0%`
Chunks	`0`	`0`
Assets	`4`	`4`
Modules	`156`(`-1.89%`)	`159`
Duplicate Modules	`63`(`-1.56%`)	`64`
Duplicate Code	`45.94%`(`+0.28%`)	`45.81%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type

1 change

1 improvement

	Current #3732	Baseline #3731
IMG	`145.76KiB`	`145.76KiB`
Other	`89.38KiB` (`-0.14%`)	`89.5KiB`

Bundle analysis report Branch colinaaa:colin/0805/remove-webpa... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2025-08-05T08:34:50Z

Web Explorer

#3722 Bundle Size — 342.52KiB (0%).

c26f9bb(current) vs 6657da6 main#3714(baseline)

Bundle metrics

1 change

	Current #3722	Baseline #3714
Initial JS	`142.05KiB`	`142.05KiB`
Initial CSS	`31.84KiB`	`31.84KiB`
Cache Invalidation	`0%`	`0%`
Chunks	`7`	`7`
Assets	`7`	`7`
Modules	`212`(`+0.47%`)	`211`
Duplicate Modules	`17`	`17`
Duplicate Code	`3.96%`	`3.96%`
Packages	`4`	`4`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #3722	Baseline #3714
JS	`227.57KiB`	`227.57KiB`
Other	`83.11KiB`	`83.11KiB`
CSS	`31.84KiB`	`31.84KiB`

Bundle analysis report Branch colinaaa:colin/0805/remove-webpa... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

…ebpack

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @lynx-js/[email protected] ### Patch Changes - Supports `recyclable` attribute in `<list-item>` to control whether the list item is recyclable. The `recyclable` attribute depends on Lynx Engine 3.4 or later. ([#1388](#1388)) ```jsx <list-item recyclable={false} /> ``` - feat: Support using a host element as direct child of Suspense ([#1455](#1455)) - Add profile in production build: ([#1336](#1336)) 1. `diff:__COMPONENT_NAME__`: how long ReactLynx diff took. 2. `render:__COMPONENT_NAME__`: how long your render function took. 3. `setState`: an instant trace event, indicate when your setState was called. NOTE: `__COMPONENT_NAME__` may be unreadable when minified, setting `displayName` may help. - Add `onBackgroundSnapshotInstanceUpdateId` event on dev for Preact Devtools to keep the correct snapshotInstanceId info. ([#1173](#1173)) - fix: Prevent error when spreading component props onto an element ([#1459](#1459)) - fix: Correctly check for the existence of background functions in MTS ([#1416](#1416)) ```ts function handleTap() { "main thread"; // The following check always returned false before this fix if (myHandleTap) { runOnBackground(myHandleTap)(); } } ``` ## @lynx-js/[email protected] ### Patch Changes - Remove the experimental `provider` option. ([#1432](#1432)) - Add `output.filename.wasm` and `output.filename.assets` options. ([#1449](#1449)) - fix deno compatibility ([#1412](#1412)) - Should call the `api.onCloseBuild` hook after the build finished. ([#1446](#1446)) - Bump Rsbuild v1.4.15. ([#1423](#1423)) - Support using function in `output.filename.*`. ([#1449](#1449)) ## [email protected] ### Patch Changes - Support ESLint for ReactLynx templates ([#1274](#1274)) ## @lynx-js/[email protected] ### Patch Changes - Updated dependencies \[[`c8ce6aa`](c8ce6aa)]: - @lynx-js/[email protected] - @lynx-js/[email protected] - @lynx-js/[email protected] - @lynx-js/[email protected] ## @lynx-js/[email protected] ### Patch Changes - Fix the `Package subpath './compat' is not defined by "exports"` error. ([#1460](#1460)) ## @lynx-js/[email protected] ### Patch Changes - Fix `GlobalEventEmitter` type definition, the `emit(eventName: string, data: unknown)` function should recevie an array typed `data` and pass as param list of listeners. ([#1479](#1479)) ## @lynx-js/[email protected] ### Patch Changes - fix: load main-thread chunk in ESM format ([#1437](#1437)) See [nodejs/node#59362](nodejs/node#59362) for more details. - feat: support path() for `createQuerySelector` ([#1456](#1456)) - Added `getPathInfo` API to `NativeApp` and its cross-thread handler for retrieving the path from a DOM node to the root. - Implemented endpoint and handler registration in both background and UI threads. - Implemented `nativeApp.getPathInfo()` - Updated dependencies \[]: - @lynx-js/[email protected] ## @lynx-js/[email protected] ### Patch Changes - fix: load main-thread chunk in ESM format ([#1437](#1437)) See [nodejs/node#59362](nodejs/node#59362) for more details. - feat: support path() for `createQuerySelector` ([#1456](#1456)) - Added `getPathInfo` API to `NativeApp` and its cross-thread handler for retrieving the path from a DOM node to the root. - Implemented endpoint and handler registration in both background and UI threads. - Implemented `nativeApp.getPathInfo()` - fix: when `onNativeModulesCall` is delayed in mounting, the NativeModules execution result may be undefined. ([#1457](#1457)) - fix: `onNativeModulesCall` && `onNapiModulesCall` use getter to get. ([#1466](#1466)) - Updated dependencies \[[`29434ae`](29434ae), [`fb7096b`](fb7096b)]: - @lynx-js/[email protected] - @lynx-js/[email protected] - @lynx-js/[email protected] - @lynx-js/[email protected] ## @lynx-js/[email protected] ### Patch Changes - fix: load main-thread chunk in ESM format ([#1437](#1437)) See [nodejs/node#59362](nodejs/node#59362) for more details. ## @lynx-js/[email protected] ### Patch Changes - feat: add autocomplete attribute support for x-input component ([#1444](#1444)) Implements autocomplete attribute forwarding from the x-input custom element to the internal HTML input element in the shadow DOM. This enables standard browser autocomplete functionality for x-input elements. - Add referrerpolicy attribute support to x-image web component ([#1420](#1420)) - Updated dependencies \[]: - @lynx-js/[email protected] ## @lynx-js/[email protected] ### Patch Changes - fix: load main-thread chunk in ESM format ([#1437](#1437)) See [nodejs/node#59362](nodejs/node#59362) for more details. - Updated dependencies \[[`29434ae`](29434ae), [`fb7096b`](fb7096b)]: - @lynx-js/[email protected] - @lynx-js/[email protected] ## @lynx-js/[email protected] ### Patch Changes - feat: support path() for `createQuerySelector` ([#1456](#1456)) - Added `getPathInfo` API to `NativeApp` and its cross-thread handler for retrieving the path from a DOM node to the root. - Implemented endpoint and handler registration in both background and UI threads. - Implemented `nativeApp.getPathInfo()` - Updated dependencies \[[`29434ae`](29434ae), [`fb7096b`](fb7096b)]: - @lynx-js/[email protected] - @lynx-js/[email protected] - @lynx-js/[email protected] ## [email protected] ## @lynx-js/[email protected] ## @lynx-js/[email protected] ## @lynx-js/[email protected] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

feat(rspeedy/core)!: remove webpack support

483ea76

colinaaa marked this pull request as ready for review August 5, 2025 09:06

Merge remote-tracking branch 'upstream/main' into colin/0805/remove-w…

dc8d49a

…ebpack

colinaaa requested a review from luhc228 August 5, 2025 12:43

Merge remote-tracking branch 'upstream/main' into colin/0805/remove-w…

18a09bd

…ebpack

luhc228 approved these changes Aug 6, 2025

View reviewed changes

Merge branch 'main' into colin/0805/remove-webpack

c26f9bb

colinaaa merged commit 08d972e into lynx-family:main Aug 6, 2025
70 of 72 checks passed

colinaaa deleted the colin/0805/remove-webpack branch August 6, 2025 04:03

github-actions bot mentioned this pull request Aug 6, 2025

chore: Release 2025-08-09 04:27:19 #1434

Merged

coderabbitai bot mentioned this pull request Aug 11, 2025

feat: support rstest in testing library #1305

Open

2 tasks

This was referenced Sep 8, 2025

feat(rspeedy/core): support resolve.dedupe #1671

Merged

feat(web-platform): migrate environment.web output format and update tests for runtime wrapper plugin #1677

Open

fix(web-platform): remove special lightning css&chunk split settings … #1732

Merged

coderabbitai bot mentioned this pull request Sep 19, 2025

fix(rspeedy/core): use chunkLoading: 'lynx' for Web #1737

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(rspeedy/core)!: remove webpack support #1432

feat(rspeedy/core)!: remove webpack support #1432

Uh oh!

colinaaa commented Aug 5, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Aug 5, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Aug 5, 2025 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

codecov bot commented Aug 5, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Aug 5, 2025 •

edited

Loading

Uh oh!

relativeci bot commented Aug 5, 2025 •

edited

Loading

Uh oh!

relativeci bot commented Aug 5, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

feat(rspeedy/core)!: remove webpack support #1432

feat(rspeedy/core)!: remove webpack support #1432

Uh oh!

Conversation

colinaaa commented Aug 5, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Summary by CodeRabbit

Checklist

Uh oh!

changeset-bot bot commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai bot commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

codecov bot commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 6 Tests Failed:

Uh oh!

codspeed-hq bot commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #1432 will not alter performance

Summary

Uh oh!

relativeci bot commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React Example

#3732 Bundle Size — 235.14KiB (-0.05%).

Uh oh!

relativeci bot commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Web Explorer

#3722 Bundle Size — 342.52KiB (0%).

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

colinaaa commented Aug 5, 2025 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Aug 5, 2025 •

edited

Loading

coderabbitai bot commented Aug 5, 2025 •

edited

Loading

codecov bot commented Aug 5, 2025 •

edited

Loading

codspeed-hq bot commented Aug 5, 2025 •

edited

Loading

relativeci bot commented Aug 5, 2025 •

edited

Loading

relativeci bot commented Aug 5, 2025 •

edited

Loading