fix(rspeedy/react): should allow @lynx-js/react 0.115.0 by colinaaa · Pull Request #1981 · lynx-family/lynx-stack

colinaaa · 2025-12-04T06:58:44Z

Summary by CodeRabbit

Chores
- Expanded compatibility with core dependencies to support additional versions, enhancing flexibility for plugin installations.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Fix an regression of #1899

Checklist

Tests updated (or not required).
Documentation updated (or not required).
Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

changeset-bot · 2025-12-04T06:58:48Z

⚠️ No Changeset found

Latest commit: e101273

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-12-04T06:59:06Z

📝 Walkthrough

Walkthrough

Updated the peer dependency version range for @lynx-js/react in the React plugin package by appending support for version ^0.115.0 to the existing compatible version chain.

Changes

Cohort / File(s)	Summary
Dependency Version Expansion `packages/rspeedy/plugin-react/package.json`	Extended peerDependencies for `@lynx-js/react` by adding `^0.115.0` to the existing version chain

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Single file change with no logic alterations
Straightforward version range expansion following established pattern

Possibly related PRs

feat(react/runtime): delay the timing of runOnMainThread() #1667: Modifies the same @lynx-js/react peer dependency entry to extend the allowed version range
fix(rspeedy/react): update peerDependencies #1781: Similarly extends the @lynx-js/react peer dependency version range in the same package.json file

Suggested labels

framework:React

Suggested reviewers

upupming
gaoachao
HuJean

Poem

🐰 Hop hop, version bump so spry!
Our lynx-js-react can now reach the sky,
0.115 joins the merry chain,
Compatibility blooms like clover again! 🍀

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly and clearly summarizes the main change: expanding peer dependency compatibility for @lynx-js/react to version 0.115.0.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/rspeedy/plugin-react/package.json (1)

68-68: Consider consolidating the peer dependency pattern.

The peer dependency now includes 13 explicit minor versions. While the explicit listing is correct per this monorepo's conventions, consider whether the maintenance burden of adding each minor version individually is sustainable. A future refactor could explore grouping or documenting this pattern.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 736b832 and e101273.

📒 Files selected for processing (1)

packages/rspeedy/plugin-react/package.json (1 hunks)

🧰 Additional context used

🧠 Learnings (10)

📓 Common learnings

Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, private packages (marked with "private": true in package.json) like lynx-js/react-transform don't require meaningful changeset entries even when their public APIs change, since they are not published externally and only affect internal development.

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1454
File: pnpm-workspace.yaml:46-46
Timestamp: 2025-08-07T04:00:59.645Z
Learning: In the lynx-family/lynx-stack repository, the webpack patch (patches/webpack5.101.0.patch) was created to fix issues with webpack5.99.9 but only takes effect on webpack5.100.0 and later versions. The patchedDependencies entry should use "webpack@^5.100.0" to ensure the patch applies to the correct version range.

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1917
File: packages/mcp-servers/devtool-mcp-server/tsconfig.json:8-8
Timestamp: 2025-11-06T01:19:23.670Z
Learning: The lynx-js/devtool-mcp-server package in lynx-family/lynx-stack targets Node.js >=18.19 (specified in its package.json engines), which is different from the root project's requirement of Node.js ^22 || ^24. The package uses "lib": ["ES2024.Promise"] in its tsconfig.json because it manually includes polyfills for Promise.withResolvers while maintaining compatibility with Node.js v18.

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1558
File: .changeset/solid-squids-fall.md:2-2
Timestamp: 2025-08-19T11:25:36.127Z
Learning: In the lynx-family/lynx-stack repository, changesets should use the exact package name from package.json#name, not generic or unscoped names. Each package has its own specific scoped name (e.g., "lynx-js/react-transform" for packages/react/transform).

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1523
File: vitest.config.ts:52-72
Timestamp: 2025-08-13T11:36:12.075Z
Learning: The lynx-stack project requires Node.js >=22 as specified in package.json engines, so Node.js compatibility fallbacks for features introduced before v22 are unnecessary.

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1453
File: vitest.config.ts:49-61
Timestamp: 2025-08-06T13:28:57.182Z
Learning: In the lynx-family/lynx-stack repository, the file `packages/rspeedy/create-rspeedy/template-react-vitest-rltl-js/vitest.config.js` is a template file for scaffolding new Rspeedy projects, not a test configuration that should be included in the main vitest projects array.

Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1370
File: .changeset/brave-melons-add.md:1-7
Timestamp: 2025-08-14T12:54:51.143Z
Learning: In the lynx-family/lynx-stack repository, packages use 0.x.x versioning where minor version bumps indicate breaking changes (not major bumps), following pre-1.0 semantic versioning conventions.

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1566
File: package.json:53-53
Timestamp: 2025-08-20T04:56:36.011Z
Learning: In lynx-stack, Node.js v24 is the preferred/default version for development (established in PR #1557), but Node.js v22 compatibility is maintained specifically for external CI systems like rspack-ecosystem-ci. The engines.node specification uses "^22 || ^24" to support both versions while keeping v24 as the primary target.

📚 Learning: 2025-09-12T09:43:04.847Z

Learnt from: gaoachao
Repo: lynx-family/lynx-stack PR: 1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, private packages (marked with "private": true in package.json) like lynx-js/react-transform don't require meaningful changeset entries even when their public APIs change, since they are not published externally and only affect internal development.

Applied to files:

packages/rspeedy/plugin-react/package.json

📚 Learning: 2025-08-07T04:00:59.645Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1454
File: pnpm-workspace.yaml:46-46
Timestamp: 2025-08-07T04:00:59.645Z
Learning: In the lynx-family/lynx-stack repository, the webpack patch (patches/webpack5.101.0.patch) was created to fix issues with webpack5.99.9 but only takes effect on webpack5.100.0 and later versions. The patchedDependencies entry should use "webpack@^5.100.0" to ensure the patch applies to the correct version range.

Applied to files:

packages/rspeedy/plugin-react/package.json

📚 Learning: 2025-08-19T11:25:36.127Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1558
File: .changeset/solid-squids-fall.md:2-2
Timestamp: 2025-08-19T11:25:36.127Z
Learning: In the lynx-family/lynx-stack repository, changesets should use the exact package name from package.json#name, not generic or unscoped names. Each package has its own specific scoped name (e.g., "lynx-js/react-transform" for packages/react/transform).

Applied to files:

packages/rspeedy/plugin-react/package.json

📚 Learning: 2025-11-06T01:19:23.670Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1917
File: packages/mcp-servers/devtool-mcp-server/tsconfig.json:8-8
Timestamp: 2025-11-06T01:19:23.670Z
Learning: The lynx-js/devtool-mcp-server package in lynx-family/lynx-stack targets Node.js >=18.19 (specified in its package.json engines), which is different from the root project's requirement of Node.js ^22 || ^24. The package uses "lib": ["ES2024.Promise"] in its tsconfig.json because it manually includes polyfills for Promise.withResolvers while maintaining compatibility with Node.js v18.

Applied to files:

packages/rspeedy/plugin-react/package.json

📚 Learning: 2025-08-14T12:54:51.143Z

Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1370
File: .changeset/brave-melons-add.md:1-7
Timestamp: 2025-08-14T12:54:51.143Z
Learning: In the lynx-family/lynx-stack repository, packages use 0.x.x versioning where minor version bumps indicate breaking changes (not major bumps), following pre-1.0 semantic versioning conventions.

Applied to files:

packages/rspeedy/plugin-react/package.json

📚 Learning: 2025-08-13T11:36:12.075Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1523
File: vitest.config.ts:52-72
Timestamp: 2025-08-13T11:36:12.075Z
Learning: The lynx-stack project requires Node.js >=22 as specified in package.json engines, so Node.js compatibility fallbacks for features introduced before v22 are unnecessary.

Applied to files:

packages/rspeedy/plugin-react/package.json

📚 Learning: 2025-08-20T04:56:36.011Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1566
File: package.json:53-53
Timestamp: 2025-08-20T04:56:36.011Z
Learning: In lynx-stack, Node.js v24 is the preferred/default version for development (established in PR #1557), but Node.js v22 compatibility is maintained specifically for external CI systems like rspack-ecosystem-ci. The engines.node specification uses "^22 || ^24" to support both versions while keeping v24 as the primary target.

Applied to files:

packages/rspeedy/plugin-react/package.json

📚 Learning: 2025-08-11T05:59:28.530Z

Learnt from: upupming
Repo: lynx-family/lynx-stack PR: 1305
File: packages/react/testing-library/src/plugins/vitest.ts:4-6
Timestamp: 2025-08-11T05:59:28.530Z
Learning: In the lynx-family/lynx-stack repository, the `packages/react/testing-library` package does not have `vite` as a direct dependency. It relies on `vitest` being available from the monorepo root and accesses Vite types through re-exports from `vitest/node`. Direct imports from `vite` should not be suggested for this package.

Applied to files:

packages/rspeedy/plugin-react/package.json

📚 Learning: 2025-08-27T08:10:09.932Z

Learnt from: colinaaa
Repo: lynx-family/lynx-stack PR: 1612
File: packages/rspeedy/create-rspeedy/template-react-vitest-rltl-ts/src/tsconfig.json:3-13
Timestamp: 2025-08-27T08:10:09.932Z
Learning: In the lynx-family/lynx-stack repository, Rspeedy templates use `lynx-js/rspeedy/client` types via `rspeedy-env.d.ts` instead of `vite/client` types. Rspeedy provides its own client-side environment type definitions and doesn't require direct Vite type references.

Applied to files:

packages/rspeedy/plugin-react/package.json

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

GitHub Check: build / Build (Windows)
GitHub Check: build / Build (Ubuntu)
GitHub Check: test-rust / clippy
GitHub Check: test-rust / Test (Ubuntu)

🔇 Additional comments (2)

packages/rspeedy/plugin-react/package.json (2)

68-68: Peer dependency update is correctly formatted.

The addition of ^0.115.0 follows the established pattern and correctly updates the peer dependency range to support the new version.

1-89: ⚠️ Verify changeset file for peer dependency updates.

Unable to access the repository to confirm whether a changeset file exists. Since @lynx-js/react-rsbuild-plugin is a published package, if this PR contains user-facing changes (such as peer dependency updates), a changeset file should be created to document the change for consumers.

codecov · 2025-12-04T07:04:15Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

codspeed-hq · 2025-12-04T07:12:33Z

CodSpeed Performance Report

Merging #1981 will not alter performance

_{Comparing colinaaa:colin/1204/peer (e101273) with main (736b832)}

Summary

✅ 63 untouched
⏩ 3 skipped¹

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

relativeci · 2025-12-04T07:23:24Z

React Example

#6350 Bundle Size — 236.9KiB (0%).

e101273(current) vs 736b832 main#6349(baseline)

Bundle metrics no changes

	Current #6350	Baseline #6349
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`0%`	`38.32%`
Chunks	`0`	`0`
Assets	`4`	`4`
Modules	`162`	`162`
Duplicate Modules	`65`	`65`
Duplicate Code	`46.75%`	`46.75%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #6350	Baseline #6349
IMG	`145.76KiB`	`145.76KiB`
Other	`91.14KiB`	`91.14KiB`

Bundle analysis report Branch colinaaa:colin/1204/peer Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2025-12-04T07:23:26Z

Web Explorer

#6510 Bundle Size — 377.67KiB (0%).

e101273(current) vs 736b832 main#6509(baseline)

Bundle metrics

1 change

	Current #6510	Baseline #6509
Initial JS	`146.31KiB`	`146.31KiB`
Initial CSS	`32.38KiB`	`32.38KiB`
Cache Invalidation	`0%`	`0%`
Chunks	`8`	`8`
Assets	`8`	`8`
Modules	`229`(`-0.43%`)	`230`
Duplicate Modules	`16`	`16`
Duplicate Code	`2.95%`	`2.95%`
Packages	`4`	`4`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #6510	Baseline #6509
JS	`243.35KiB`	`243.35KiB`
Other	`101.94KiB`	`101.94KiB`
CSS	`32.38KiB`	`32.38KiB`

Bundle analysis report Branch colinaaa:colin/1204/peer Project dashboard

^{Generated by RelativeCI Documentation Report issue}

…1981)  ## Summary by CodeRabbit * **Chores** * Expanded compatibility with core dependencies to support additional versions, enhancing flexibility for plugin installations. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub>  Fix an regression of lynx-family#1899 ## Checklist  - [ ] Tests updated (or not required). - [ ] Documentation updated (or not required). - [ ] Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

fix(rspeedy/react): should allow @lynx-js/react 0.115.0

e101273

coderabbitai bot added the framework:React label Dec 4, 2025

coderabbitai bot reviewed Dec 4, 2025

View reviewed changes

colinaaa merged commit c475c1e into lynx-family:main Dec 4, 2025
41 of 52 checks passed

colinaaa deleted the colin/1204/peer branch December 4, 2025 07:27

coderabbitai bot mentioned this pull request Jan 16, 2026

chore: update peer dependencies #2117

Merged

3 tasks

This was referenced Apr 7, 2026

chore: missing changeset #2432

Merged

feat(react-transform): add removeCall support #2423

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(rspeedy/react): should allow @lynx-js/react 0.115.0#1981

fix(rspeedy/react): should allow @lynx-js/react 0.115.0#1981
colinaaa merged 1 commit intolynx-family:mainfrom
colinaaa:colin/1204/peer

colinaaa commented Dec 4, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Dec 4, 2025

Uh oh!

coderabbitai bot commented Dec 4, 2025 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Uh oh!

coderabbitai bot left a comment

Uh oh!

codecov bot commented Dec 4, 2025

Uh oh!

codspeed-hq bot commented Dec 4, 2025

Uh oh!

relativeci bot commented Dec 4, 2025

Uh oh!

relativeci bot commented Dec 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

colinaaa commented Dec 4, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Checklist

Uh oh!

changeset-bot bot commented Dec 4, 2025

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Dec 4, 2025

Codecov Report

Uh oh!

codspeed-hq bot commented Dec 4, 2025

CodSpeed Performance Report

Merging #1981 will not alter performance

Summary

Footnotes

Uh oh!

relativeci bot commented Dec 4, 2025

React Example

#6350 Bundle Size — 236.9KiB (0%).

Uh oh!

relativeci bot commented Dec 4, 2025

Web Explorer

#6510 Bundle Size — 377.67KiB (0%).

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

colinaaa commented Dec 4, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 4, 2025 •

edited

Loading