Skip to content

Conversation

@colinaaa
Copy link
Collaborator

@colinaaa colinaaa commented Sep 18, 2025

We forgot to update peerDependencies in #1771

Summary by CodeRabbit

  • New Features

    • Expanded compatibility to support @lynx-js/react v0.114.0 for the React Rsbuild plugin.
  • Chores

    • Prepared a patch release entry to reflect the updated compatibility range.
    • Updated peer dependency constraints to include @lynx-js/react v0.114.0 without changing runtime behavior.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).
  • Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

@changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2025

🦋 Changeset detected

Latest commit: ae33f06

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@lynx-js/react-rsbuild-plugin Patch
@lynx-js/react-alias-rsbuild-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 18, 2025

📝 Walkthrough

Walkthrough

Updates peerDependency in packages/rspeedy/plugin-react/package.json to include @lynx-js/react ^0.114.0 and adds a changeset file marking a patch release for @lynx-js/react-rsbuild-plugin. No runtime or public API changes.

Changes

Cohort / File(s) Summary of change
Release metadata
\.changeset/chilly-carrots-marry.md
Adds a changeset declaring a patch release and noting compatibility with @lynx-js/react v0.114.0.
Peer dependency update
packages/rspeedy/plugin-react/package.json
Expands peerDependencies for @lynx-js/react to include ^0.114.0 alongside existing range; no code or API changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

framework:React

Suggested reviewers

  • gaoachao
  • hzy

Poem

A hop, a bop, I tweak the lock—
Peer deps nudge to the latest stock.
Patch notes whisper, “all aligned!”
Carrot commits, cleanly signed. 🥕
Onward I bound, with tidy cheer,
Versions snug, the path is clear.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "fix(rspeedy/react): update peerDependencies" succinctly and accurately summarizes the primary change—updating peerDependencies for the rspeedy/react package—and aligns with the changeset and package.json modification in the PR, making it clear and useful for teammates scanning history.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@colinaaa colinaaa merged commit 7cb4d97 into lynx-family:main Sep 18, 2025
13 of 14 checks passed
@colinaaa colinaaa deleted the colin/0918/peer branch September 18, 2025 13:26
@codecov
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.changeset/chilly-carrots-marry.md (1)

1-6: Changeset present and targets the correct package — LGTM.

Matches package name "@lynx-js/react-rsbuild-plugin" and correctly marks a patch for the peer range update.

Polish the note for clarity (optional).

Apply this diff to make the release note more explicit and user-facing:

 ---
 "@lynx-js/react-rsbuild-plugin": patch
 ---
 
-Be compat with `@lynx-js/react` v0.114.0
+Broaden peer compatibility to include `@lynx-js/react` ^0.114.0.
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9c8321c and ae33f06.

📒 Files selected for processing (2)
  • .changeset/chilly-carrots-marry.md (1 hunks)
  • packages/rspeedy/plugin-react/package.json (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/*.md

📄 CodeRabbit inference engine (AGENTS.md)

For contributions, always generate a changeset and commit the resulting markdown file(s)

Files:

  • .changeset/chilly-carrots-marry.md
🧠 Learnings (7)
📓 Common learnings
Learnt from: gaoachao
PR: lynx-family/lynx-stack#1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, private packages (marked with "private": true in package.json) like lynx-js/react-transform don't require meaningful changeset entries even when their public APIs change, since they are not published externally and only affect internal development.
Learnt from: colinaaa
PR: lynx-family/lynx-stack#1454
File: pnpm-workspace.yaml:46-46
Timestamp: 2025-08-07T04:00:59.645Z
Learning: In the lynx-family/lynx-stack repository, the webpack patch (patches/webpack5.101.0.patch) was created to fix issues with webpack5.99.9 but only takes effect on webpack5.100.0 and later versions. The patchedDependencies entry should use "webpack@^5.100.0" to ensure the patch applies to the correct version range.
Learnt from: colinaaa
PR: lynx-family/lynx-stack#1558
File: .changeset/solid-squids-fall.md:2-2
Timestamp: 2025-08-19T11:25:36.127Z
Learning: In the lynx-family/lynx-stack repository, changesets should use the exact package name from package.json#name, not generic or unscoped names. Each package has its own specific scoped name (e.g., "lynx-js/react-transform" for packages/react/transform).
📚 Learning: 2025-09-12T09:43:04.847Z
Learnt from: gaoachao
PR: lynx-family/lynx-stack#1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, empty changeset files (containing only `---\n\n---`) are used for internal changes that modify src/** files but don't require meaningful release notes, such as private package changes or testing-only modifications. This satisfies CI requirements without generating user-facing release notes.

Applied to files:

  • .changeset/chilly-carrots-marry.md
📚 Learning: 2025-09-12T09:43:04.847Z
Learnt from: gaoachao
PR: lynx-family/lynx-stack#1736
File: .changeset/spotty-experts-smoke.md:1-3
Timestamp: 2025-09-12T09:43:04.847Z
Learning: In the lynx-family/lynx-stack repository, private packages (marked with "private": true in package.json) like lynx-js/react-transform don't require meaningful changeset entries even when their public APIs change, since they are not published externally and only affect internal development.

Applied to files:

  • .changeset/chilly-carrots-marry.md
  • packages/rspeedy/plugin-react/package.json
📚 Learning: 2025-07-22T09:26:16.722Z
Learnt from: colinaaa
PR: lynx-family/lynx-stack#1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:26:16.722Z
Learning: In the lynx-family/lynx-stack repository, CI checks require changesets when files matching the pattern "src/**" are modified (as configured in .changeset/config.json). For internal changes that don't need meaningful changesets, an empty changeset file is used to satisfy the CI requirement while not generating any release notes.

Applied to files:

  • .changeset/chilly-carrots-marry.md
📚 Learning: 2025-07-22T09:23:07.797Z
Learnt from: colinaaa
PR: lynx-family/lynx-stack#1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:23:07.797Z
Learning: In the lynx-family/lynx-stack repository, changesets are only required for meaningful changes to end-users such as bugfixes and features. Internal/development changes like chores, refactoring, or removing debug info do not need changeset entries.

Applied to files:

  • .changeset/chilly-carrots-marry.md
📚 Learning: 2025-08-19T11:25:36.127Z
Learnt from: colinaaa
PR: lynx-family/lynx-stack#1558
File: .changeset/solid-squids-fall.md:2-2
Timestamp: 2025-08-19T11:25:36.127Z
Learning: In the lynx-family/lynx-stack repository, changesets should use the exact package name from package.json#name, not generic or unscoped names. Each package has its own specific scoped name (e.g., "lynx-js/react-transform" for packages/react/transform).

Applied to files:

  • .changeset/chilly-carrots-marry.md
  • packages/rspeedy/plugin-react/package.json
📚 Learning: 2025-08-07T04:00:59.645Z
Learnt from: colinaaa
PR: lynx-family/lynx-stack#1454
File: pnpm-workspace.yaml:46-46
Timestamp: 2025-08-07T04:00:59.645Z
Learning: In the lynx-family/lynx-stack repository, the webpack patch (patches/webpack5.101.0.patch) was created to fix issues with webpack5.99.9 but only takes effect on webpack5.100.0 and later versions. The patchedDependencies entry should use "webpack@^5.100.0" to ensure the patch applies to the correct version range.

Applied to files:

  • .changeset/chilly-carrots-marry.md
  • packages/rspeedy/plugin-react/package.json
🔇 Additional comments (1)
packages/rspeedy/plugin-react/package.json (1)

67-67: Manual verification required — confirm all peerDependencies on @lynx-js/react include ^0.114.0

Sandbox scan failed with a /dev/fd error; cannot verify repo-wide. Run this locally to list package.json files that declare @lynx-js/react but do NOT include ^0.114.0:

find . -type f -name package.json -not -path '*/node_modules/*' -not -path '*/dist/*' -not -path '*/build/*' -exec sh -c '
  for f; do
    v=$(jq -r "try .peerDependencies[\"@lynx-js/react\"] // empty" "$f" 2>/dev/null || true)
    if [ -n "$v" ] && ! printf "%s" "$v" | grep -q "\^0\.114\.0"; then
      printf "%s:%s\n" "$f" "$v"
    fi
  done
' _ {} +

@relativeci
Copy link

relativeci bot commented Sep 18, 2025

React Example

#5347 Bundle Size — 237.66KiB (0%).

ae33f06(current) vs 9c8321c main#5345(baseline)

Bundle metrics  no changes
                 Current
#5347
     Baseline
#5345
No change  Initial JS 0B 0B
No change  Initial CSS 0B 0B
Change  Cache Invalidation 0% 38.69%
No change  Chunks 0 0
No change  Assets 4 4
No change  Modules 165 165
No change  Duplicate Modules 67 67
No change  Duplicate Code 46.76% 46.76%
No change  Packages 2 2
No change  Duplicate Packages 0 0
Bundle size by type  no changes
                 Current
#5347
     Baseline
#5345
No change  IMG 145.76KiB 145.76KiB
No change  Other 91.91KiB 91.91KiB

Bundle analysis reportBranch colinaaa:colin/0918/peerProject dashboard


Generated by RelativeCIDocumentationReport issue

@relativeci
Copy link

relativeci bot commented Sep 18, 2025

Web Explorer

#5340 Bundle Size — 365.35KiB (0%).

ae33f06(current) vs 9c8321c main#5338(baseline)

Bundle metrics  Change 1 change
                 Current
#5340
     Baseline
#5338
No change  Initial JS 145.65KiB 145.65KiB
No change  Initial CSS 32KiB 32KiB
No change  Cache Invalidation 0% 0%
No change  Chunks 8 8
No change  Assets 8 8
Change  Modules 219(+0.46%) 218
No change  Duplicate Modules 16 16
No change  Duplicate Code 3.37% 3.37%
No change  Packages 4 4
No change  Duplicate Packages 0 0
Bundle size by type  no changes
                 Current
#5340
     Baseline
#5338
No change  JS 239.34KiB 239.34KiB
No change  Other 94.02KiB 94.02KiB
No change  CSS 32KiB 32KiB

Bundle analysis reportBranch colinaaa:colin/0918/peerProject dashboard


Generated by RelativeCIDocumentationReport issue

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 18, 2025

CodSpeed Performance Report

Merging #1781 will degrade performances by 5.9%

Comparing colinaaa:colin/0918/peer (ae33f06) with main (9c8321c)

🎉 Hooray! codspeed-cpp just leveled up to 1.2.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

⚡ 1 improvement
❌ 1 regression
✅ 51 untouched
⏩ 3 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
transform 1000 view elements 46.6 ms 39.8 ms +16.97%
basic-performance-div-10000 386.3 ms 410.5 ms -5.9%

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

colinaaa pushed a commit that referenced this pull request Sep 21, 2025
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @lynx-js/[email protected]

### Minor Changes

- Partially fix the "cannot read property 'update' of undefined" error.
([#1771](#1771))

This error happens when rendering a JSX expression in a
[background-only](https://lynxjs.org/react/thinking-in-reactlynx.html)
context.

See
[#894](#894)
for more details.

### Patch Changes

- Reduce extra snapshot when children are pure text
([#1562](#1562))

- feat: Support `SelectorQuery` `animation` APIs
([#1768](#1768))

- Fix spread props inside list-item caused redundant snapshot patch
([#1760](#1760))

- fix: `ref is not initialized` error on template reload
([#1757](#1757))

## @lynx-js/[email protected]

### Minor Changes

- **BREAKING CHANGE:** Remove the `enableParallelElement` and
`pipelineSchedulerConfig` options.
([#1705](#1705))

Since the thread element resolution is still in experimental stage and
may have stability risks, it will be disabled by default after this
change.

- **BREAKING CHANGE**: Remove the `enableICU` option.
([#1800](#1800))

### Patch Changes

- Be compat with `@lynx-js/react` v0.114.0
([#1781](#1781))

- Updated dependencies
\[[`24100ab`](24100ab),
[`24100ab`](24100ab),
[`d0ef559`](d0ef559)]:
    -   @lynx-js/[email protected]
    -   @lynx-js/[email protected]
    -   @lynx-js/[email protected]
    -   @lynx-js/[email protected]
    -   @lynx-js/[email protected]
    -   @lynx-js/[email protected]

## @lynx-js/[email protected]

### Minor Changes

- Enable `lynxUIPlugins` (incl. `uiVariants`) by default. Fills the gap
left by missing pseudo- and data-attribute selectors in Lynx, offering
state and structural variants out of the box.
([#1774](#1774))

    Opt-out globally or per plugin:

    ```ts
    // disable all UI plugins
    createLynxPreset({ lynxUIPlugins: false });
    // or disable one plugin
    createLynxPreset({ lynxUIPlugins: { uiVariants: false } });
    ```

### Patch Changes

- Fixed transform-related CSS variables previously defined on `:root`;
they are now reset on `*` to prevent inheritance between parent and
child elements.
([#1773](#1773))

## @lynx-js/[email protected]

### Minor Changes

- break(web): temporary remove support for chunk split
([#1739](#1739))

Since the global variables cannot be accessed in the splited chunk, we
temporary remove supporting for chunk spliting

Developers could easily remove the chunk Split settings in Rspeedy for
migration

        import { defineConfig } from '@lynx-js/rspeedy'

        export default defineConfig({
          performance: {
            chunkSplit: {
              strategy: 'all-in-one',
            },
          },
        })

### Patch Changes

- fix: lazy component load error
([#1794](#1794))

Some special version template may have chunk loading error. We fixed it.

- fix: avoid duplicate style transformation
([#1748](#1748))

    After this commit, we use DAG methods to handle the styleInfos

- fix: add sandbox attribute to iframe for enhanced security
([#1709](#1709))

- fix: the default template loader won't fetch twice for one url
([#1709](#1709))

- Updated dependencies
\[[`721635d`](721635d),
[`93d707b`](93d707b),
[`d150ed4`](d150ed4)]:
    -   @lynx-js/[email protected]
    -   @lynx-js/[email protected]
    -   @lynx-js/[email protected]
    -   @lynx-js/[email protected]

## @lynx-js/[email protected]

### Minor Changes

- **BREAKING CHANGE:** Remove the `enableParallelElement` and
`pipelineSchedulerConfig` options.
([#1705](#1705))

Since the thread element resolution is still in experimental stage and
may have stability risks, it will be disabled by default after this
change.

- **BREAKING CHANGE**: Remove the `enableICU` option.
([#1800](#1800))

## @lynx-js/[email protected]

### Patch Changes

- Use `output.chunkLoading: 'lynx'` for `environments.web`.
([#1737](#1737))

- Support `resolve.extensions`
([#1759](#1759))

- Set the default value of `output.cssModules.localIdentName` to
`[local]-[hash:base64:6]`.
([#1783](#1783))

## @lynx-js/[email protected]

### Patch Changes

- fix: avoid duplicate style transformation
([#1748](#1748))

    After this commit, we use DAG methods to handle the styleInfos

-   Updated dependencies \[]:
    -   @lynx-js/[email protected]

## @lynx-js/[email protected]

### Patch Changes

- The img within svg does not inherit the position
([#1769](#1769))

-   Updated dependencies \[]:
    -   @lynx-js/[email protected]

## @lynx-js/[email protected]

### Patch Changes

- fix: \_\_QueryComponentImpl in mts should execute only once for same
url ([#1763](#1763))

- fix: avoid duplicate style transformation
([#1748](#1748))

    After this commit, we use DAG methods to handle the styleInfos

- feat: support lazy bundle with CSSOG(`enableCSSSelector: false`).
([#1770](#1770))

- Updated dependencies
\[[`93d707b`](93d707b)]:
    -   @lynx-js/[email protected]
    -   @lynx-js/[email protected]

## @lynx-js/[email protected]

### Patch Changes

- Updated dependencies
\[[`721635d`](721635d),
[`93d707b`](93d707b),
[`d150ed4`](d150ed4)]:
    -   @lynx-js/[email protected]
    -   @lynx-js/[email protected]
    -   @lynx-js/[email protected]

## @lynx-js/[email protected]

### Patch Changes

- Supports `@lynx-js/template-webpack-plugin` 0.9.0.
([#1705](#1705))

## @lynx-js/[email protected]

### Patch Changes

- Supports `@lynx-js/template-webpack-plugin` 0.9.0.
([#1705](#1705))

## [email protected]



## @lynx-js/[email protected]



## [email protected]



## @lynx-js/[email protected]



## @lynx-js/[email protected]



## @lynx-js/[email protected]



## @lynx-js/[email protected]

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant