Skip to content

refactor(rspeedy/react): remove default output.inlineScripts#1952

Merged
gaoachao merged 1 commit intolynx-family:mainfrom
colinaaa:colin/1124/todos
Nov 26, 2025
Merged

refactor(rspeedy/react): remove default output.inlineScripts#1952
gaoachao merged 1 commit intolynx-family:mainfrom
colinaaa:colin/1124/todos

Conversation

@colinaaa
Copy link
Copy Markdown
Collaborator

@colinaaa colinaaa commented Nov 24, 2025

Summary by CodeRabbit

  • Chores
    • Removed automatic inlineScripts configuration override; now relies on existing defaults
    • Cleaned up configuration comments

✏️ Tip: You can customize this high-level summary in your review settings.

Since we are bumping the required @lynx-js/rspeedy version in #1951, we can resolve some TODOs to simplify the plugin.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).
  • Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Nov 24, 2025

🦋 Changeset detected

Latest commit: bf86c1e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Nov 24, 2025

📝 Walkthrough

Walkthrough

This PR removes a backward-compatibility default for output.inlineScripts in the React plugin and removes a comment line from the SWC configuration. A new changeset file is added to document these changes.

Changes

Cohort / File(s) Summary
Changeset Documentation
.changeset/deep-ideas-grin.md
Added new changeset file with YAML front-matter markers
React Plugin Config
packages/rspeedy/plugin-react/src/pluginReactLynx.ts, packages/rspeedy/plugin-react/src/swc.ts
Removed backward-compatibility block that defaulted output.inlineScripts to true; removed comment from SWC transform config

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • Key attention area: Verify that removing the output.inlineScripts default doesn't break existing configs that relied on this implicit behavior. Ensure that the new default behavior (when undefined) is documented or handled appropriately in rsbuild configuration.

Possibly related PRs

Suggested labels

framework:React

Suggested reviewers

  • gaoachao

Poem

🐰 Hoppy times ahead, we say!
Old defaults hop away,
Comments cleaned, configs aligned,
A cleaner path the team will find! 🎀

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing the default output.inlineScripts behavior from the rspeedy/react plugin, which aligns with the primary modification in pluginReactLynx.ts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Nov 24, 2025

CodSpeed Performance Report

Merging #1952 will degrade performances by 6.86%

Comparing colinaaa:colin/1124/todos (bf86c1e) with main (4695100)

Summary

❌ 1 regression
✅ 62 untouched
⏩ 3 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
basic-performance-small-css 6.9 ms 7.4 ms -6.86%

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@relativeci
Copy link
Copy Markdown

relativeci bot commented Nov 24, 2025

Web Explorer

#6326 Bundle Size — 377.49KiB (0%).

bf86c1e(current) vs 4695100 main#6283(baseline)

Bundle metrics  no changes
                 Current
#6326
     Baseline
#6283
No change  Initial JS 146.32KiB 146.32KiB
No change  Initial CSS 32.37KiB 32.37KiB
No change  Cache Invalidation 0% 0%
No change  Chunks 8 8
No change  Assets 8 8
No change  Modules 230 230
No change  Duplicate Modules 16 16
No change  Duplicate Code 2.95% 2.95%
No change  Packages 4 4
No change  Duplicate Packages 0 0
Bundle size by type  no changes
                 Current
#6326
     Baseline
#6283
No change  JS 243.18KiB 243.18KiB
No change  Other 101.94KiB 101.94KiB
No change  CSS 32.37KiB 32.37KiB

Bundle analysis reportBranch colinaaa:colin/1124/todosProject dashboard


Generated by RelativeCIDocumentationReport issue

@gaoachao gaoachao merged commit 95a33f5 into lynx-family:main Nov 26, 2025
176 of 186 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants