Skip to content

refactor(rspeedy/react): remove default output.inlineScripts #1952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaoachao merged 1 commit into from
Nov 26, 2025
Merged

refactor(rspeedy/react): remove default output.inlineScripts #1952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changeset/deep-ideas-grin.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---

---
12 changes: 0 additions & 12 deletions packages/rspeedy/plugin-react/src/pluginReactLynx.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,19 +348,7 @@ export function pluginReactLynx(
})
}

// This is used for compat with `@lynx-js/rspeedy` <= 0.9.6
// where the default value of `output.inlineScripts` is `false`.
// TODO: remove this when required Rspeedy version bumped to ^0.9.7
if (typeof userConfig.output?.inlineScripts === 'undefined') {
config = mergeRsbuildConfig(config, {
output: {
inlineScripts: true,
},
})
}

// This is used to avoid the IIFE in main-thread.js, which would cause memory leak.
// TODO: remove this when required Rspeedy version bumped to ^0.10.0
config = mergeRsbuildConfig({
tools: {
rspack: { output: { iife: false } },
Expand Down
1 change: 0 additions & 1 deletion packages/rspeedy/plugin-react/src/swc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ export function applySWC(api: RsbuildPluginAPI): void {
swc: {
jsc: {
transform: {
// TODO: remove this in the next minor version
useDefineForClassFields: false,
optimizer: {
simplify: true,
Expand Down
Loading