Skip to content

test(rspeedy/qrcode): remove the expect.poll.timeout#1507

Merged
colinaaa merged 1 commit intolynx-family:mainfrom
colinaaa:colin/0812/timeout
Aug 12, 2025
Merged

test(rspeedy/qrcode): remove the expect.poll.timeout#1507
colinaaa merged 1 commit intolynx-family:mainfrom
colinaaa:colin/0812/timeout

Conversation

@colinaaa
Copy link
Copy Markdown
Collaborator

@colinaaa colinaaa commented Aug 12, 2025

Summary by CodeRabbit

  • Tests
    • Standardized test polling behavior by removing a custom timeout override for QR code-related tests, aligning with default settings to improve consistency and reduce flakiness.
    • No impact on application behavior or user experience; production functionality remains unchanged.

Fixes #1496 (comment)

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).
  • Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Aug 12, 2025

⚠️ No Changeset found

Latest commit: c3b8e41

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Aug 12, 2025

📝 Walkthrough

Walkthrough

Removed the expect.poll timeout override from packages/rspeedy/plugin-qrcode/vitest.config.ts, reverting to default Vitest polling behavior. No other changes were made, and exported/public signatures remain unaffected.

Changes

Cohort / File(s) Summary of changes
Vitest config cleanup
packages/rspeedy/plugin-qrcode/vitest.config.ts
Deleted expect.poll timeout configuration (timeout: 3000), leaving default polling behavior. No other config changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • ci: fix flaky test #1496 — Adjusts Vitest expect.poll timeout at CI level; related to this PR’s removal of a package-level override.

Suggested reviewers

  • gaoachao

Poem

A twitch of nose, a flip of ear,
I nibbled code to make it clear—
No extra ticks, no timeout bloat,
Default winds now steer the boat.
Hop-hop! The tests shall lightly roll,
As carrots count each polling goal. 🥕🐇


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b8b060b and c3b8e41.

📒 Files selected for processing (1)
  • packages/rspeedy/plugin-qrcode/vitest.config.ts (0 hunks)
💤 Files with no reviewable changes (1)
  • packages/rspeedy/plugin-qrcode/vitest.config.ts
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Aug 12, 2025

CodSpeed Performance Report

Merging #1507 will not alter performance

Comparing colinaaa:colin/0812/timeout (c3b8e41) with main (b8b060b)

Summary

✅ 10 untouched benchmarks

@relativeci
Copy link
Copy Markdown

relativeci Bot commented Aug 12, 2025

React Example

#4122 Bundle Size — 236.88KiB (0%).

c3b8e41(current) vs b8b060b main#4103(baseline)

Bundle metrics  no changes
                 Current
#4122
     Baseline
#4103
No change  Initial JS 0B 0B
No change  Initial CSS 0B 0B
No change  Cache Invalidation 0% 0%
No change  Chunks 0 0
No change  Assets 4 4
No change  Modules 158 158
No change  Duplicate Modules 64 64
No change  Duplicate Code 45.85% 45.85%
No change  Packages 2 2
No change  Duplicate Packages 0 0
Bundle size by type  no changes
                 Current
#4122
     Baseline
#4103
No change  IMG 145.76KiB 145.76KiB
No change  Other 91.12KiB 91.12KiB

Bundle analysis reportBranch colinaaa:colin/0812/timeoutProject dashboard


Generated by RelativeCIDocumentationReport issue

@relativeci
Copy link
Copy Markdown

relativeci Bot commented Aug 12, 2025

Web Explorer

#4116 Bundle Size — 344.15KiB (0%).

c3b8e41(current) vs b8b060b main#4099(baseline)

Bundle metrics  Change 1 change
                 Current
#4116
     Baseline
#4099
No change  Initial JS 143.27KiB 143.27KiB
No change  Initial CSS 31.84KiB 31.84KiB
Change  Cache Invalidation 0% 6.72%
No change  Chunks 7 7
No change  Assets 7 7
Change  Modules 211(-0.47%) 212
No change  Duplicate Modules 17 17
No change  Duplicate Code 3.96% 3.96%
No change  Packages 4 4
No change  Duplicate Packages 0 0
Bundle size by type  no changes
                 Current
#4116
     Baseline
#4099
No change  JS 229.35KiB 229.35KiB
No change  Other 82.95KiB 82.95KiB
No change  CSS 31.84KiB 31.84KiB

Bundle analysis reportBranch colinaaa:colin/0812/timeoutProject dashboard


Generated by RelativeCIDocumentationReport issue

@colinaaa colinaaa merged commit 1148d15 into lynx-family:main Aug 12, 2025
111 of 123 checks passed
@colinaaa colinaaa deleted the colin/0812/timeout branch August 12, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant