ci: fix flaky test by colinaaa · Pull Request #1496 · lynx-family/lynx-stack

colinaaa · 2025-08-12T06:41:05Z

Summary by CodeRabbit

New Features
- No user-facing changes in this release.
Tests
- Improved reliability of async checks by adjusting test polling timeouts.
Chores
- Streamlined build pipeline by removing a pre-run dependency verification step, reducing overhead and speeding up workflows.

See: https://github.com/lynx-family/lynx-stack/actions/runs/16899390188/job/47875887456

Also see: https://app.codecov.io/gh/lynx-family/lynx-stack/tests/main

Checklist

Tests updated (or not required).
Documentation updated (or not required).
Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

changeset-bot · 2025-08-12T06:41:09Z

⚠️ No Changeset found

Latest commit: 5406b7b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-08-12T06:41:12Z

📝 Walkthrough

Walkthrough

This change updates the CI test workflow to include a Vitest expect poll timeout flag and modifies pnpm workspace defaults by removing verifyDepsBeforeRun from the @pnpm/plugin-better-defaults configuration.

Changes

Cohort / File(s)	Change summary
CI workflow update `.github/workflows/test.yml`	Added Vitest flag `--expect.poll.timeout=5000` to test invocation in the test-vitest job; no other workflow changes.
Workspace config update `pnpm-workspace.yaml`	Removed `verifyDepsBeforeRun: "install"` from `@pnpm/plugin-better-defaults`; other settings unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Poem

I twitch my ears at ticking clocks,
CI hums and Vitest knocks—⏱️
Five-second patience in our burrow,
PNPM hops a lighter furrow.
Carrots crunched, configs neat,
Another merge—so swift, so sweet. 🥕

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

Visit our Status Page to check the current availability of CodeRabbit.
Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-08-12T06:51:13Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

codspeed-hq · 2025-08-12T06:53:24Z

CodSpeed Performance Report

Merging #1496 will not alter performance

_{Comparing colinaaa:colin/0812/flaky-test (5406b7b) with main (a77b840)}

Summary

✅ 10 untouched benchmarks

relativeci · 2025-08-12T06:55:32Z

React Example

#4065 Bundle Size — 236.88KiB (0%).

5406b7b(current) vs a77b840 main#4057(baseline)

Bundle metrics no changes

	Current #4065	Baseline #4057
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`0%`	`0%`
Chunks	`0`	`0`
Assets	`4`	`4`
Modules	`158`	`158`
Duplicate Modules	`64`	`64`
Duplicate Code	`45.85%`	`45.85%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #4065	Baseline #4057
IMG	`145.76KiB`	`145.76KiB`
Other	`91.12KiB`	`91.12KiB`

Bundle analysis report Branch colinaaa:colin/0812/flaky-test Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2025-08-12T06:55:35Z

Web Explorer

#4060 Bundle Size — 344.11KiB (0%).

5406b7b(current) vs a77b840 main#4052(baseline)

Bundle metrics no changes

	Current #4060	Baseline #4052
Initial JS	`143.27KiB`	`143.27KiB`
Initial CSS	`31.84KiB`	`31.84KiB`
Cache Invalidation	`0%`	`0%`
Chunks	`7`	`7`
Assets	`7`	`7`
Modules	`211`	`211`
Duplicate Modules	`17`	`17`
Duplicate Code	`3.96%`	`3.96%`
Packages	`4`	`4`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #4060	Baseline #4052
JS	`229.31KiB`	`229.31KiB`
Other	`82.95KiB`	`82.95KiB`
CSS	`31.84KiB`	`31.84KiB`

Bundle analysis report Branch colinaaa:colin/0812/flaky-test Project dashboard

^{Generated by RelativeCI Documentation Report issue}

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a77b840 and 5406b7b.

📒 Files selected for processing (2)

.github/workflows/test.yml (1 hunks)
pnpm-workspace.yaml (0 hunks)

💤 Files with no reviewable changes (1)

pnpm-workspace.yaml

## Summary by CodeRabbit * **Tests** * Standardized test polling behavior by removing a custom timeout override for QR code-related tests, aligning with default settings to improve consistency and reduce flakiness. * No impact on application behavior or user experience; production functionality remains unchanged.  Fixes #1496 (comment) ## Checklist  - [ ] Tests updated (or not required). - [ ] Documentation updated (or not required). - [ ] Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

ci: fix flaky test

5406b7b

colinaaa marked this pull request as ready for review August 12, 2025 07:13

colinaaa requested a review from gaoachao August 12, 2025 07:18

coderabbitai Bot reviewed Aug 12, 2025

View reviewed changes

Comment thread .github/workflows/test.yml

colinaaa merged commit 517ac33 into lynx-family:main Aug 12, 2025
46 checks passed

colinaaa deleted the colin/0812/flaky-test branch August 12, 2025 07:48

colinaaa mentioned this pull request Aug 12, 2025

test(rspeedy/qrcode): remove the expect.poll.timeout #1507

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: fix flaky test#1496

ci: fix flaky test#1496
colinaaa merged 1 commit intolynx-family:mainfrom
colinaaa:colin/0812/flaky-test

colinaaa commented Aug 12, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

changeset-bot Bot commented Aug 12, 2025

Uh oh!

coderabbitai Bot commented Aug 12, 2025 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

Status, Documentation and Community

Uh oh!

codecov Bot commented Aug 12, 2025 •

edited

Loading

Uh oh!

codspeed-hq Bot commented Aug 12, 2025

Uh oh!

relativeci Bot commented Aug 12, 2025

Uh oh!

relativeci Bot commented Aug 12, 2025

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

colinaaa commented Aug 12, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Checklist

Uh oh!

changeset-bot Bot commented Aug 12, 2025

⚠️ No Changeset found

Uh oh!

coderabbitai Bot commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

Status, Documentation and Community

Uh oh!

codecov Bot commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codspeed-hq Bot commented Aug 12, 2025

CodSpeed Performance Report

Merging #1496 will not alter performance

Summary

Uh oh!

relativeci Bot commented Aug 12, 2025

React Example

#4065 Bundle Size — 236.88KiB (0%).

Uh oh!

relativeci Bot commented Aug 12, 2025

Web Explorer

#4060 Bundle Size — 344.11KiB (0%).

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

colinaaa commented Aug 12, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Aug 12, 2025 •

edited

Loading

codecov Bot commented Aug 12, 2025 •

edited

Loading