fix: legacy browser x-swiper layout issue #1376

PupilTong · 2025-07-30T07:12:58Z

Summary by CodeRabbit

Bug Fixes
- Resolved a layout issue with the swiper component to ensure proper display in legacy browsers.

changeset-bot · 2025-07-30T07:13:03Z

🦋 Changeset detected

Latest commit: 0a2a0e9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@lynx-js/web-elements-template	Patch
@lynx-js/web-elements	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2025-07-30T07:13:05Z

📝 Walkthrough

Walkthrough

This change updates the @lynx-js/web-elements-template and @lynx-js/web-elements packages to address a layout issue with the x-swiper component in legacy browsers. Specifically, the #content element within the swiper template now explicitly sets its width to 100%.

Changes

Cohort / File(s)	Change Summary
Changelog & Metadata `.changeset/sixty-files-hear.md`	Documents the patch updates for two packages and describes the fix for the `x-swiper` layout issue in legacy browsers.
Swiper Template Style Update `packages/web-platform/web-elements-template/src/index.ts`	Adds `width: 100%;` to the `#content` CSS rule within the `templateXSwiper` template to resolve layout inconsistencies.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A swiper in browsers of old
Was stubborn and wouldn’t unfold,
But with width set anew,
The content flows through—
Now legacy tales are retold!
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 92445ad and 0a2a0e9.

📒 Files selected for processing (2)

.changeset/sixty-files-hear.md (1 hunks)
packages/web-platform/web-elements-template/src/index.ts (1 hunks)

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: PupilTong
PR: lynx-family/lynx-stack#1029
File: packages/web-platform/web-core/src/uiThread/createRenderAllOnUI.ts:95-99
Timestamp: 2025-07-16T06:28:26.463Z
Learning: In the lynx-stack codebase, CSS selectors in SSR hydration are generated by their own packages, ensuring a predictable format that makes simple string manipulation safe and preferable over regex for performance reasons.

Learnt from: PupilTong
PR: lynx-family/lynx-stack#1029
File: packages/web-platform/web-core/src/uiThread/createRenderAllOnUI.ts:95-99
Timestamp: 2025-07-16T05:57:29.837Z
Learning: In the lynx-stack codebase, PupilTong prefers avoiding regex for parsing in performance-critical code paths like SSR hydration, preferring simple string manipulation operations even if they're less robust, when the input format is predictable and controlled.

.changeset/sixty-files-hear.md (3)

Learnt from: colinaaa
PR: #1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:23:07.797Z
Learning: In the lynx-family/lynx-stack repository, changesets are only required for meaningful changes to end-users such as bugfixes and features. Internal/development changes like chores, refactoring, or removing debug info do not need changeset entries.

Learnt from: colinaaa
PR: #1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:26:16.722Z
Learning: In the lynx-family/lynx-stack repository, CI checks require changesets when files matching the pattern "src/**" are modified (as configured in .changeset/config.json). For internal changes that don't need meaningful changesets, an empty changeset file is used to satisfy the CI requirement while not generating any release notes.

Learnt from: PupilTong
PR: #1029
File: packages/web-platform/web-core/src/uiThread/createRenderAllOnUI.ts:95-99
Timestamp: 2025-07-16T06:28:26.463Z
Learning: In the lynx-stack codebase, CSS selectors in SSR hydration are generated by their own packages, ensuring a predictable format that makes simple string manipulation safe and preferable over regex for performance reasons.

🔇 Additional comments (2)

packages/web-platform/web-elements-template/src/index.ts (1)

248-248: Explicit width fallback looks good, but check sibling templates for the same legacy quirk

width: 100% complements flex: 0 0 100% and safely works around old-browser flex bugs—nice catch.
The nearby templateXViewpageNg (Line 304-314) uses the same flex: 0 0 100% pattern but still lacks the explicit width. Please verify whether that template (or others) needs the same fix to keep behaviour consistent across components.

.changeset/sixty-files-hear.md (1)

1-7: Changeset looks correct

Patch bumps are appropriate and the summary is clear. No further action needed.

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codspeed-hq · 2025-07-30T07:35:22Z

CodSpeed Performance Report

Merging #1376 will not alter performance

_{Comparing PupilTong:p/hw/fix-legacy-browser-x-swiper (0a2a0e9) with main (92445ad)}

Summary

✅ 10 untouched benchmarks

relativeci · 2025-07-30T08:01:04Z

React Example

#3445 Bundle Size — 235.18KiB (0%).

0a2a0e9(current) vs 92445ad main#3436(baseline)

Bundle metrics no changes

	Current #3445	Baseline #3436
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`0%`	`0%`
Chunks	`0`	`0`
Assets	`4`	`4`
Modules	`156`	`156`
Duplicate Modules	`63`	`63`
Duplicate Code	`45.94%`	`45.94%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #3445	Baseline #3436
IMG	`145.76KiB`	`145.76KiB`
Other	`89.42KiB`	`89.42KiB`

Bundle analysis report Branch PupilTong:p/hw/fix-legacy-browse... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2025-07-30T08:01:07Z

Web Explorer

#3435 Bundle Size — 352.54KiB (~+0.01%).

0a2a0e9(current) vs 92445ad main#3426(baseline)

Bundle metrics

2 changes

1 regression

	Current #3435	Baseline #3426
Initial JS	`142.14KiB`(`+0.01%`)	`142.12KiB`
Initial CSS	`31.83KiB`	`31.83KiB`
Cache Invalidation	`40.31%`	`0%`
Chunks	`7`	`7`
Assets	`7`	`7`
Modules	`214`	`214`
Duplicate Modules	`17`	`17`
Duplicate Code	`3.94%`	`3.94%`
Packages	`4`	`4`
Duplicate Packages	`0`	`0`

Bundle size by type

1 change

1 regression

	Current #3435	Baseline #3426
JS	`226.42KiB` (`~+0.01%`)	`226.4KiB`
Other	`94.29KiB`	`94.29KiB`
CSS	`31.83KiB`	`31.83KiB`

Bundle analysis report Branch PupilTong:p/hw/fix-legacy-browse... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

fix: legacy browser x-swiper layout issue

0a2a0e9

PupilTong self-assigned this Jul 30, 2025

PupilTong added this to Lynx for Web Jul 30, 2025

PupilTong added the platform:Web label Jul 30, 2025

PupilTong closed this Jul 30, 2025

github-project-automation bot moved this to Done in Lynx for Web Jul 30, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: legacy browser x-swiper layout issue #1376

fix: legacy browser x-swiper layout issue #1376

Uh oh!

PupilTong commented Jul 30, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Jul 30, 2025

Uh oh!

coderabbitai bot commented Jul 30, 2025 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem