-
Notifications
You must be signed in to change notification settings - Fork 111
chore(testing-library): remove debug info #1330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 48489da The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis change removes all conditional debug logging statements from several files, including setup scripts and a plugin configuration. Additionally, a function parameter in one file was renamed from Changes
Estimated code review effort2 (~10–15 minutes) Suggested labels
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ERROR Cannot resolve version $@rspack/core in overrides. The direct dependencies don't have dependency "@rspack/core". ✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.changeset/olive-animals-attend.md(1 hunks)packages/react/testing-library/src/vitest-global-setup.js(0 hunks)packages/react/testing-library/src/vitest.config.js(0 hunks)packages/testing-library/testing-environment/src/index.ts(1 hunks)
💤 Files with no reviewable changes (2)
- packages/react/testing-library/src/vitest-global-setup.js
- packages/react/testing-library/src/vitest.config.js
🔇 Additional comments (1)
packages/testing-library/testing-environment/src/index.ts (1)
166-169: LGTM! Proper handling of unused parameter.The parameter rename from
optionsto_optionscorrectly indicates that this parameter is intentionally unused, which aligns with the removal of debug logging functionality.
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
CodSpeed Performance ReportMerging #1330 will not alter performanceComparing Summary
|
Web Explorer#3207 Bundle Size — 304.52KiB (0%).48489da(current) vs 2e659db main#3180(baseline) Bundle metrics
|
| Current #3207 |
Baseline #3180 |
|
|---|---|---|
140.65KiB |
140.65KiB |
|
31.83KiB |
31.83KiB |
|
0% |
0% |
|
4 |
4 |
|
5 |
5 |
|
206 |
206 |
|
17 |
17 |
|
4.22% |
4.22% |
|
3 |
3 |
|
0 |
0 |
Bundle size by type no changes
| Current #3207 |
Baseline #3180 |
|
|---|---|---|
221.88KiB |
221.88KiB |
|
50.82KiB |
50.82KiB |
|
31.83KiB |
31.83KiB |
Bundle analysis report Branch upupming:feat/remove-rltl-consol... Project dashboard
Generated by RelativeCI Documentation Report issue
React Example#3217 Bundle Size — 234.72KiB (0%).48489da(current) vs 2e659db main#3190(baseline) Bundle metrics
|
| Current #3217 |
Baseline #3190 |
|
|---|---|---|
0B |
0B |
|
0B |
0B |
|
0% |
0% |
|
0 |
0 |
|
4 |
4 |
|
160 |
160 |
|
65 |
65 |
|
45.98% |
45.98% |
|
2 |
2 |
|
0 |
0 |
Bundle size by type no changes
| Current #3217 |
Baseline #3190 |
|
|---|---|---|
145.76KiB |
145.76KiB |
|
88.96KiB |
88.96KiB |
Bundle analysis report Branch upupming:feat/remove-rltl-consol... Project dashboard
Generated by RelativeCI Documentation Report issue
Remove redundant log on CI:
Summary by CodeRabbit
No changes affecting user-facing features or functionality.
Checklist