-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated weights column checks through Mixin Class and capturing shared weight tests in generic test classes #239
Merged
Ritunjai-Sharma
merged 10 commits into
main
from
feature/automated_weights_column_checks
May 3, 2024
Merged
Automated weights column checks through Mixin Class and capturing shared weight tests in generic test classes #239
Ritunjai-Sharma
merged 10 commits into
main
from
feature/automated_weights_column_checks
May 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when calling fit method of all weighted transformers
…sts to generic testing classes
limlam96
reviewed
Apr 26, 2024
…d_set_weight method to WeightColumnMixin class and removed test_weight_arg_errors from test_BaseCappingTransformer.py
…o in test_OrdinalEncoderTransformer.py
FYI getting some conflicts :) |
can you update changelog plz :) |
limlam96
reviewed
May 1, 2024
limlam96
reviewed
May 1, 2024
…ethod and made some more updates
Yes! Done here: abdc10b |
limlam96
approved these changes
May 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, nice work RJ!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following work has been done as part of this PR:
WeightColumnMixin mixin class created in a new file mixins.py with check_weights_column method to replace check_weights_column method in base.py: Commit 4bff09e3. Note that post implementing this check_weights_column check for weighted transformers, some tests for nominal transformers failed since the testing data was using null values in weight column, which logically shouldn't be allowed. This testing data has been updated to not contain null values in weight column.
Refactored testing of weighted transformers to move shared tests in generic testing classes: Commit 43827aad. As part of this, the following work was done: