Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring MeanImputer in line with new testing setup #208

Closed
limlam96 opened this issue Apr 2, 2024 · 1 comment · Fixed by #250
Closed

Bring MeanImputer in line with new testing setup #208

limlam96 opened this issue Apr 2, 2024 · 1 comment · Fixed by #250
Assignees
Labels
good first issue Good for newcomers

Comments

@limlam96
Copy link
Contributor

limlam96 commented Apr 2, 2024

What?

There are a few required changes for this, summarised below from (#150)

  • Double check "minimal attribute dict" fixture has the correct set of minimal arguments required
  • Set up the TestInit TestFit, TestTransform, and TestOtherBaseBehaviour classes to inherit the appropriate test classes and then copy the setup_class class method into each test class, changing transformer_name to the transformer you are testing (examples linked) .
  • Extra tests specific to this class should be added, e.g. if this transformer also needed to check that when len(mappings)>2 then mappings is an ordered dict, you would add this to TestInit. Where extra tests would apply to all child classes, they should instead be added to the parent test class.
  • Delete any unnecessary tests from original transformer test file (i.e. tests testing inherited behaviour that is now tested by the inherited test classes). An example would be. In general asserting calls is a red flag, as this tests the applied process rather than the desired outcome.
  • Debug the failing tests from the base test suite.
  • Bring the test file in line with best practices by insuring there are no implementation tests (in this case looks like these will have been removed as part of the base test changes)
  • Bonus: If you identify any gaps in the testing, please set up new issues :)

Why?
Revamp tubular testing to make package more maintainable/modifiable

@limlam96
Copy link
Contributor Author

limlam96 commented Apr 3, 2024

There are some changes here here to the BaseImputer tests that will be useful to this, if this PR is not complete at time of picking up then would branch off of it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants