You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What?
Many transformers rely on a weights column, and many contain duplicated checks on this column. BaseTransformer implements a check_weights_column method, but this is not called by BaseTransformer.fit/transform - if there are no objections suggest automatically calling this when weight_column is provided. Can then capture appropriate tests in one of the generic test classes, and delete duplicated checks across transformers.
The text was updated successfully, but these errors were encountered:
Leaning towards having a light WeightedBaseTransformer class that inherits from BaseTransformer and handles this stuff. Transformers would then have to inherit from the appropriate parent class
What?
Many transformers rely on a weights column, and many contain duplicated checks on this column. BaseTransformer implements a check_weights_column method, but this is not called by BaseTransformer.fit/transform - if there are no objections suggest automatically calling this when weight_column is provided. Can then capture appropriate tests in one of the generic test classes, and delete duplicated checks across transformers.
The text was updated successfully, but these errors were encountered: