Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated tested approach for meanimputer #250

Merged
merged 2 commits into from
May 13, 2024
Merged

Conversation

Chip2916
Copy link
Collaborator

@Chip2916 Chip2916 commented May 13, 2024

As per issue here

Not much to do on this one, most of the refactor for imputers done as part of adding WeightMixin class & refactoring the median/mode imputers in earlier tickets.

  • Removed inherited tests from mean imputer test script.
  • Updated changelog.

@Chip2916 Chip2916 linked an issue May 13, 2024 that may be closed by this pull request
Copy link
Contributor

@davidhopkinson26 davidhopkinson26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant, thanks for this! A great example of how much more streamlined the new testing format is!

@davidhopkinson26 davidhopkinson26 merged commit f769001 into main May 13, 2024
12 checks passed
@davidhopkinson26 davidhopkinson26 deleted the meanimputer_testing branch May 13, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bring MeanImputer in line with new testing setup
2 participants