setup ArbitraryTransformer with new testing appraoch #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 3, 2024
lsumption
reviewed
Apr 8, 2024
lsumption
reviewed
Apr 8, 2024
|
Should we be adding type hints to the tests? |
|
Can we update the changelog with these changes? |
|
updated changelog here f5234c8 |
|
re type hints in tests.. maybe? But think that would be one to spin out into another issue as it doesn't currently seem to be done elsewhere |
|
Happy to leave the type hints for now. I think there's just an outstanding merge conflict then happy to approve! |
|
nice thanks :) should be resolved now! |
lsumption
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #207
Made changes to bring ArbitraryImputer in line with new test format, also refactored BaseImputer tests to ease the rest of the rollout across imputers.
Introduced new 'FITS' class attribute to simplify test inheritance process and turning on/off relevant tests, if the reviewer approves then suggest to rollout across transformers. Possibly default to True in BaseTransformer and set to False where needed in main transformers.