chore: Replace nova::bn256_grumpkin with halo2curves library #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- companion PR of lurk-lang/arecibo#135 - Replaced the usage of `nova::provider::bn256_grumpkin` with `halo2curves` in `src/lem/multiframe.rs`, `src/proof/nova.rs`, and `src/field.rs` since the nova module is now private, - Updated tests in `src/lem/multiframe.rs` to use the `halo2curves` library, - Replaced `bn256_grumpkin::bn256` with `Bn256Engine` and redefined `CurveCycleEquipped` for `Bn256Scalar` in `src/proof/nova.rs`. - Added `halo2curves` to the list of dependencies in `Cargo.toml` and updated the `LurkField` implementation in `src/field.rs`.
huitseeker
force-pushed
the
adapt_microsoft_267
branch
from
ea89ddf to
350c399
Compare
porcuquine
approved these changes
Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nova::provider::bn256_grumpkinwithhalo2curvesinsrc/lem/multiframe.rs,src/proof/nova.rs, andsrc/field.rssince the nova module is now private,src/lem/multiframe.rsto use thehalo2curveslibrary,bn256_grumpkin::bn256withBn256Engineand redefinedCurveCycleEquippedforBn256Scalarinsrc/proof/nova.rs.halo2curvesto the list of dependencies inCargo.tomland updated theLurkFieldimplementation insrc/field.rs.