More Nova forward ports #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
about 10% improvement for the non-release mode
* refactor: impl folding macro * refactor: generalize curve test * chore: rename impl_folding to impl_engine
huitseeker
added a commit
to huitseeker/lurk-rs
that referenced
this pull request
Nov 23, 2023
- companion PR of lurk-lang/arecibo#135 - Replaced the usage of `nova::provider::bn256_grumpkin` with `halo2curves` in `src/lem/multiframe.rs`, `src/proof/nova.rs`, and `src/field.rs` since the nova module is now private, - Updated tests in `src/lem/multiframe.rs` to use the `halo2curves` library, - Replaced `bn256_grumpkin::bn256` with `Bn256Engine` and redefined `CurveCycleEquipped` for `Bn256Scalar` in `src/proof/nova.rs`. - Added `halo2curves` to the list of dependencies in `Cargo.toml` and updated the `LurkField` implementation in `src/field.rs`.
|
Companion PR at Lurk : lurk-lab/lurk-beta#920 |
huitseeker
added a commit
to huitseeker/lurk-rs
that referenced
this pull request
Nov 23, 2023
- companion PR of lurk-lang/arecibo#135 - Replaced the usage of `nova::provider::bn256_grumpkin` with `halo2curves` in `src/lem/multiframe.rs`, `src/proof/nova.rs`, and `src/field.rs` since the nova module is now private, - Updated tests in `src/lem/multiframe.rs` to use the `halo2curves` library, - Replaced `bn256_grumpkin::bn256` with `Bn256Engine` and redefined `CurveCycleEquipped` for `Bn256Scalar` in `src/proof/nova.rs`. - Added `halo2curves` to the list of dependencies in `Cargo.toml` and updated the `LurkField` implementation in `src/field.rs`.
adr1anh
approved these changes
Nov 23, 2023
mpenciak
approved these changes
Nov 24, 2023
github-merge-queue bot
pushed a commit
to lurk-lab/lurk-beta
that referenced
this pull request
Nov 27, 2023
* chore: Replace bn256_grumpkin with halo2curves library - companion PR of lurk-lang/arecibo#135 - Replaced the usage of `nova::provider::bn256_grumpkin` with `halo2curves` in `src/lem/multiframe.rs`, `src/proof/nova.rs`, and `src/field.rs` since the nova module is now private, - Updated tests in `src/lem/multiframe.rs` to use the `halo2curves` library, - Replaced `bn256_grumpkin::bn256` with `Bn256Engine` and redefined `CurveCycleEquipped` for `Bn256Scalar` in `src/proof/nova.rs`. - Added `halo2curves` to the list of dependencies in `Cargo.toml` and updated the `LurkField` implementation in `src/field.rs`. * chore: re-align with arecibo dev branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports:
microsoft/Nova#264
microsoft/Nova#255
microsoft/Nova#267