[bazel] Add aspects to run clang-tidy #18537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmcardle
force-pushed
the
dmcardle/clang-tidy
branch
3 times, most recently
from
b9f411b to
395a187
Compare
Closed
dmcardle
force-pushed
the
dmcardle/clang-tidy
branch
2 times, most recently
from
b4486b3 to
0614f67
Compare
dmcardle
changed the title
dmcardle
force-pushed
the
dmcardle/clang-tidy
branch
from
0614f67 to
4d3aaee
Compare
|
Hey folks, PTAL when you get a chance! This is half-baked right now, but with Bazel's |
dmcardle
force-pushed
the
dmcardle/clang-tidy
branch
3 times, most recently
from
23853ce to
f7bc9c3
Compare
This commit adds "fix" and "check" aspects that run clang-tidy.
Example usage:
./bazelisk.sh build --config=clang_tidy_fix \
--config=riscv32 //sw/device/lib/base:memory
./bazelisk.sh build --config=clang_tidy_check \
--config=riscv32 //sw/device/lib/base:memory
This also adds a new target, //quality:clang_tidy_check, which runs
clang-tidy against a very incomplete list of hand-picked targets.
Signed-off-by: Dan McArdle <[email protected]>
dmcardle
force-pushed
the
dmcardle/clang-tidy
branch
from
f7bc9c3 to
9e554af
Compare
milesdai
approved these changes
May 18, 2023
| acquire_lock(args.lock_file) | ||
|
|
||
| compile_commands = Path("compile_commands.json") | ||
| cleanup_func = maybe_rename_path( |
There was a problem hiding this comment.
nit: no need to address in this PR, but this might be a good use case for a with context manager to handle the cleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds "fix" and "check" aspects that run clang-tidy.
Example usage:
This also adds a new target, //quality:clang_tidy_check, which runs
clang-tidy against a very incomplete list of hand-picked targets.