Snapshot

Author: dmcardle

sw/device/lib/crypto/include/drbg.h

@@ -94,7 +94,7 @@ crypto_status_t otcrypto_drbg_generate(crypto_uint8_buf_t additional_input,
  *
  * @return Result of the DRBG uninstantiate operation.
  */
-crypto_status_t otcrypto_drbg_uninstantiate();
+crypto_status_t otcrypto_drbg_uninstantiate(void);
 
 #ifdef __cplusplus
 }  // extern "C"

sw/device/lib/dif/dif_rv_core_ibex_unittest.cc

@@ -609,7 +609,7 @@ TEST_F(ParseCrashDumpTest, DoubleFault) {
       .previous_fault_state = {.mtval = 0x15555555, .mpec = 0x25555555},
       .double_fault = kDifToggleEnabled,
   };
-  dif_rv_core_ibex_crash_dump_info_t dump = {0};
+  dif_rv_core_ibex_crash_dump_info_t dump = {{0}};
 
   uint32_t
       cpu_info[sizeof(dif_rv_core_ibex_crash_dump_info_t) / sizeof(uint32_t)];
@@ -629,7 +629,7 @@ TEST_F(ParseCrashDumpTest, SingleFault) {
       .previous_fault_state = {.mtval = 0x15555555, .mpec = 0x25555555},
       .double_fault = kDifToggleDisabled,
   };
-  dif_rv_core_ibex_crash_dump_info_t dump = {0};
+  dif_rv_core_ibex_crash_dump_info_t dump = {{0}};
 
   uint32_t
       cpu_info[sizeof(dif_rv_core_ibex_crash_dump_info_t) / sizeof(uint32_t)];

sw/device/lib/testing/hmac_testutils.h

@@ -34,7 +34,7 @@
  *
  * single HMAC block compression takes 80 cycles.
  */
-static inline uint32_t compute_hmac_testutils_fifo_empty_usec() {
+static inline uint32_t compute_hmac_testutils_fifo_empty_usec(void) {
   uint64_t result = udiv64_slow((80 + 10) * 1000000, kClockFreqCpuHz, NULL) + 1;
   CHECK(result <= UINT32_MAX, "timeout must fit in uint32_t");
   return (uint32_t)result;
@@ -46,7 +46,7 @@ static inline uint32_t compute_hmac_testutils_fifo_empty_usec() {
  * Final hash calculation takes 360 cycles, which consists of one block
  * compression and extra HMAC computation.
  */
-static inline uint32_t compute_hmac_testutils_finish_timeout_usec() {
+static inline uint32_t compute_hmac_testutils_finish_timeout_usec(void) {
   uint64_t result =
       udiv64_slow((360 + 10) * 1000000, kClockFreqCpuHz, NULL) + 1;
   CHECK(result <= UINT32_MAX, "timeout must fit in uint32_t");

sw/device/lib/testing/profile.h

@@ -25,7 +25,7 @@ extern "C" {
  *
  * @return Ibex cycle count at start time.
  */
-uint64_t profile_start();
+uint64_t profile_start(void);
 
 /**
  * End a cycle-count timing profile.

sw/device/silicon_creator/lib/drivers/kmac_unittest.cc

@@ -27,9 +27,9 @@ class KmacTest : public rom_test::RomTest {
    */
   void ExpectPollState(uint32_t flag, bool err) {
     // Test assumption: the status flags idle/absorb/squeeze are bits 0..2.
-    static_assert(KMAC_STATUS_SHA3_IDLE_BIT < 3);
-    static_assert(KMAC_STATUS_SHA3_ABSORB_BIT < 3);
-    static_assert(KMAC_STATUS_SHA3_SQUEEZE_BIT < 3);
+    static_assert(KMAC_STATUS_SHA3_IDLE_BIT < 3, "");
+    static_assert(KMAC_STATUS_SHA3_ABSORB_BIT < 3, "");
+    static_assert(KMAC_STATUS_SHA3_SQUEEZE_BIT < 3, "");
 
     // Calculate the status flags that are not this flag.
     uint32_t other_status_flag1 = (flag + 1) % 3;

sw/device/tests/sim_dv/pwrmgr_sleep_all_wake_ups_impl.h

@@ -56,7 +56,7 @@ extern dif_sensor_ctrl_t sensor_ctrl;
 extern dif_sysrst_ctrl_t sysrst_ctrl;
 extern dif_usbdev_t usbdev;
 
-void init_units();
+void init_units(void);
 
 void check_wakeup_reason(uint32_t wakeup_source);