Skip to content

chore: bump packages/owletto pointer to 2ffdefa#1074

Merged
buremba merged 2 commits into
mainfrom
chore/bump-claim-consent-copy
May 26, 2026
Merged

chore: bump packages/owletto pointer to 2ffdefa#1074
buremba merged 2 commits into
mainfrom
chore/bump-claim-consent-copy

Conversation

@buremba
Copy link
Copy Markdown
Member

@buremba buremba commented May 26, 2026

Bumps packages/owletto pointer.

Before: b3d3a64
After:  2ffdefa

Picks up: fix(oauth): frame the device consent page as an access request when arriving via a link (#224)

Summary by CodeRabbit

  • Chores

    • Updated owletto package reference to point to a new subproject commit.
  • Tests

    • Updated OAuth discovery mocks used by email-login and OAuth parsing tests to adjust response formatting and the presence/structure of the email-claim endpoint, ensuring tests reflect the new discovery payload formats.

Review Change Stack

Picks up: fix(oauth): frame the device consent page as an access request when arriving via a link (#224)

Before: b3d3a64
After:  2ffdefa
@buremba buremba enabled auto-merge (squash) May 26, 2026 13:46
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: cceafa5e-935f-46ac-87ce-3e76cca46b4f

📥 Commits

Reviewing files that changed from the base of the PR and between 63ac521 and d3a308d.

📒 Files selected for processing (2)
  • packages/cli/src/__tests__/login-email.test.ts
  • packages/cli/src/internal/__tests__/oauth.test.ts
✅ Files skipped from review due to trivial changes (1)
  • packages/cli/src/internal/tests/oauth.test.ts

📝 Walkthrough

Walkthrough

This PR updates the packages/owletto subproject pointer to a new commit hash and reformats mocked OAuth discovery JSON in CLI unit tests that exercise email-claiming and discoverOAuth parsing.

Changes

Owletto Subproject Bump

Layer / File(s) Summary
Owletto subproject pointer update
packages/owletto
The subproject commit reference is updated from one Git hash to another.

CLI OAuth/mock test updates

Layer / File(s) Summary
login-email test discovery mock formatting
packages/cli/src/__tests__/login-email.test.ts
Mocks for .well-known/oauth-authorization-server in the “user_claimed” and “no claim endpoint” tests were reformatted: grant_types_supported becomes an array; agent_auth.claim_email_endpoint is present in the claimed case and omitted in the no-claim case.
discoverOAuth test mock formatting
packages/cli/src/internal/__tests__/oauth.test.ts
Reformatted agent_auth.claim_email_endpoint property representation in the discoverOAuth test without changing its value or assertions.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Poem

🐰 A hop, a tweak, a tidy test—
One hash steps up, mocks reshaped and dressed.
The rabbit winks, the CI hums along,
Small changes stitched into the dev-song. ✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The description includes the summary with before/after commit hashes and the change being picked up, but lacks the required Test plan section with validation checkboxes. Add the Test plan section from the template with checkboxes indicating which validation steps were run (e.g., bun run check:fix, typecheck, package validation).
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: bumping the packages/owletto pointer to a specific commit hash.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/bump-claim-consent-copy

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

These landed format-dirty via #1073 (the pre-commit --write didn't reach the
committed blob), turning the format-lint check red on main. Expand the inline
arrays/objects to match `biome format`. Verified clean with the exact CI
command (biome format --config-path config/biome.config.json .). No logic
change. Folded into this pointer-bump PR since it was blocked on the same red.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants