chore: bump owletto pointer (menubar org display + picker collapse fix)#1075
Closed
buremba wants to merge 3 commits into
Closed
chore: bump owletto pointer (menubar org display + picker collapse fix)#1075buremba wants to merge 3 commits into
buremba wants to merge 3 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesSubmodule pointer update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/owletto`:
- Line 1: The submodule pointer for packages/owletto is pinned to commit
c11d2c2135ffc30824d92a79e503ddf241d8d3ba which is not an ancestor of
owletto/main, causing the submodule drift deployment gate to fail; update the
submodule reference in packages/owletto to a commit that is reachable from
owletto/main — either wait for owletto#225 to be squash-merged into owletto/main
and then repin to the resulting main commit, or re-pin to the merge commit on
owletto/main that includes the changes (ensure the new commit is an ancestor of
origin/main so merge-base --is-ancestor passes).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
Member
Author
|
bug_free 88, simplicity 88, slop 18, bugs 0, 0 blockers Script-run typecheck/unit/integration all exit 0. Reviewed owletto submodule commits; verified commit is on origin/feat/menubar-show-org; ran xcodebuild Debug build for mac Owletto → succeeded. [env] Xcode emitted existing Swift warnings in OAuthClient.swift/WhatsAppLocalSyncService.swift. Suggested fixes
Full verdict JSON{
"bug_free_confidence": 88,
"bugs": 0,
"slop": 18,
"simplicity": 88,
"blockers": [],
"change_type": "feat",
"behavior_change_risk": "low",
"tests_adequate": true,
"suggested_fixes": [
{
"file": "packages/owletto/apps/mac/Owletto/MenuBarContent.swift",
"line": 31,
"change": "Update the comment to remove the stale claim that connection errors still force-expand the picker."
},
{
"file": "packages/owletto/apps/mac/Owletto/MenuBarContent.swift",
"line": 221,
"change": "Rewrite this doc comment to describe current uses of hasConnectionError, not removed auto-expansion behavior."
},
{
"file": "packages/owletto/apps/mac/Owletto/MenuBarContent.swift",
"line": 330,
"change": "Replace the long explanatory comment with a concise note like: \"Refresh contexts without changing the persisted picker disclosure state.\""
}
],
"notes": "Script-run typecheck/unit/integration all exit 0. Reviewed owletto submodule commits; verified commit is on origin/feat/menubar-show-org; ran xcodebuild Debug build for mac Owletto → succeeded. [env] Xcode emitted existing Swift warnings in OAuthClient.swift/WhatsAppLocalSyncService.swift.",
"categories": {
"src": 2,
"tests": 0,
"docs": 0,
"config": 0,
"deps": 0,
"migrations": 0,
"ci": 0,
"generated": 0
}
}Local review gate — branch protection can require the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the packages/owletto pointer to pick up lobu-ai/owletto#225 (menubar: show context org inline + keep picker collapse across opens).
Depends on owletto#225 — points at that branch's tip (c11d2c2, reachable). After #225 squash-merges, re-point this to owletto main's merge SHA (or just merge #225 first, then refresh the pointer here).
Summary by CodeRabbit