chore: bump owletto pointer (menu-bar deep-link + Terminal-launch fixes)#1019
Conversation
… Terminal-launch fixes)
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates the ChangesOwletto submodule update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/owletto`:
- Line 1: The submodule pointer in packages/owletto is pinned to commit
09852188e0c8c1ef6c38a3cbf46ea9fe591d08af which is not reachable from
owletto/main; to fix, either merge the PR lobu-ai/owletto#215 into owletto/main
so that commit becomes reachable or change the submodule pointer in
packages/owletto to a commit that is present on owletto/main (repin the
submodule to a reachable commit and update the gitlink accordingly), then update
the submodule reference in the parent repo so CI and git fetch succeed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
|
bug_free 82, simplicity 82, slop 10, bugs 1, 0 blockers [env] integration failed before exercising diff because DATABASE_URL points at postgres and the harness refused destructive setup. Typecheck/unit passed. Explored submodule diff, confirmed SHA is reachable on origin/feat/menubar-gaps, ran xcodebuild Owletto Debug macOS -> build OK with pre-existing Swift warnings. Suggested fixes
Full verdict JSON{
"bug_free_confidence": 82,
"bugs": 1,
"slop": 10,
"simplicity": 82,
"blockers": [],
"change_type": "fix",
"behavior_change_risk": "medium",
"tests_adequate": false,
"suggested_fixes": [
{
"file": "packages/owletto/apps/mac/Owletto/MenuBarContent.swift",
"line": 1325,
"change": "Before every `return false` after temp files may have been created, remove `mcpConfigFile`/`promptFile` (or `cleanupPaths`) so prompt/token temp files do not persist when script write or `open -a Terminal` fails."
},
{
"file": "packages/owletto/apps/mac/Owletto/MenuBarContent.swift",
"line": 1204,
"change": "Delete or update the stale heredoc comment; the prompt is now written to a temp file and read via `cat`, not embedded in a heredoc."
}
],
"notes": "[env] integration failed before exercising diff because DATABASE_URL points at postgres and the harness refused destructive setup. Typecheck/unit passed. Explored submodule diff, confirmed SHA is reachable on origin/feat/menubar-gaps, ran xcodebuild Owletto Debug macOS -> build OK with pre-existing Swift warnings.",
"categories": {
"src": 0,
"tests": 0,
"docs": 0,
"config": 0,
"deps": 2,
"migrations": 0,
"ci": 0,
"generated": 0
}
}Local review gate — branch protection can require the |
2 participants
Bumps the
packages/owlettosubmodule pointer to pick up lobu-ai/owletto#215.That PR fixes the macOS menu bar:
/<slug>/runs/<id>route ("Not Found") → now/<slug>/events?run_ids=<id>/api/exchange-token(no sign-in wall).command(heredoc-in-$()); now prompt is read from a tempfile viacatOwletto SHA
0985218is reachable on origin (pushed before this bump).Summary by CodeRabbit
Chores
Notes