test: skip flaky telemetry tests#2814
Merged
ashwinb merged 1 commit intollamastack:mainfrom Jul 21, 2025
Merged
Conversation
meta-cla
bot
added
the
CLA Signed
ehhuang
requested review from
ashwinb,
bbrowning,
hardikjshah,
leseb,
mattf,
raghotham,
reluctantfuturist,
terrytangyuan and
yanxi0830
as code owners
Contributor
|
I fixed the flakes here #2678 in "llama_stack/providers/utils/telemetry/sqlite_trace_store.py" |
Collaborator
|
I left a comment on your PR @Elbehery , I think some separation of concerns (mypy vs functional changes) here would be nice if possible, thanks! |
cdoern
approved these changes
Jul 18, 2025
cdoern
reviewed
Jul 18, 2025
| yield | ||
|
|
||
|
|
||
| @pytest.skip(reason="Skipping telemetry tests for now") |
Collaborator
There was a problem hiding this comment.
@pytest.mark.skip is the proper format here I think, pytest.skip skips the whole file
Suggested change
| @pytest.skip(reason="Skipping telemetry tests for now") | |
| @pytest.mark.skip |
# What does this PR do? ## Test Plan
Contributor
Contributor
Author
|
root caused in #2815 |
ashwinb
approved these changes
Jul 21, 2025
Contributor
ashwinb
left a comment
ashwinb
left a comment
There was a problem hiding this comment.
yes merging this first and then we can enable the test once the fixes are in
Elbehery
added a commit
to Elbehery/llama-stack
that referenced
this pull request
Jul 21, 2025
This reverts commit d0208df. Signed-off-by: Mustafa Elbehery <melbeher@redhat.com>
ehhuang
pushed a commit
that referenced
this pull request
Jul 22, 2025
# What does this PR do? <!-- Provide a short summary of what this PR does and why. Link to relevant issues if applicable. --> This PR fixes flaky telemetry tests <!-- If resolving an issue, uncomment and update the line below --> <!-- Closes #[issue-number] --> See #2814 ## Test Plan <!-- Describe the tests you ran to verify your changes with result summaries. *Provide clear instructions so the plan can be easily re-executed.* --> Signed-off-by: Mustafa Elbehery <melbeher@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
example error: https://github.com/meta-llama/llama-stack/actions/runs/16368394907/job/46250869773
Test Plan