Merged
Conversation
Elbehery
requested review from
ashwinb,
bbrowning,
ehhuang,
hardikjshah,
leseb,
raghotham,
reluctantfuturist,
terrytangyuan and
yanxi0830
as code owners
facebook-github-bot
added
the
CLA Signed
Contributor
Author
|
cc @leseb |
Elbehery
force-pushed
the
20250708_add_mypy_prompt_guard
branch
from
6a83d2d to
d7540d2
Compare
leseb
requested changes
Jul 10, 2025
Elbehery
force-pushed
the
20250708_add_mypy_prompt_guard
branch
from
d7540d2 to
9eb83dc
Compare
leseb
reviewed
Jul 10, 2025
llama_stack/providers/inline/safety/prompt_guard/prompt_guard.py
Outdated
Show resolved
Hide resolved
Elbehery
force-pushed
the
20250708_add_mypy_prompt_guard
branch
from
9eb83dc to
13df2f0
Compare
leseb
requested changes
Jul 10, 2025
llama_stack/providers/inline/safety/prompt_guard/prompt_guard.py
Outdated
Show resolved
Hide resolved
Elbehery
force-pushed
the
20250708_add_mypy_prompt_guard
branch
2 times, most recently
from
07e2234 to
b511967
Compare
Elbehery
force-pushed
the
20250708_add_mypy_prompt_guard
branch
from
b511967 to
51b179e
Compare
Contributor
Author
|
cc @leseb this is rebased now |
leseb
reviewed
Jul 18, 2025
Elbehery
force-pushed
the
20250708_add_mypy_prompt_guard
branch
4 times, most recently
from
d4ba02d to
b8df047
Compare
Contributor
Author
|
@ashwinb are more changes needed here ? |
Elbehery
force-pushed
the
20250708_add_mypy_prompt_guard
branch
2 times, most recently
from
ab9858c to
b0a5652
Compare
Contributor
Author
|
@leseb ptal 👍🏽 |
ashwinb
reviewed
Aug 5, 2025
ashwinb
reviewed
Aug 5, 2025
llama_stack/providers/remote/datasetio/huggingface/huggingface.py
Outdated
Show resolved
Hide resolved
Elbehery
force-pushed
the
20250708_add_mypy_prompt_guard
branch
from
b0a5652 to
f1bb9db
Compare
Contributor
Author
Elbehery
force-pushed
the
20250708_add_mypy_prompt_guard
branch
2 times, most recently
from
705d4ca to
851597a
Compare
leseb
previously approved these changes
Aug 6, 2025
Collaborator
leseb
left a comment
leseb
left a comment
There was a problem hiding this comment.
The postgres CI failure looks unrelated.
Contributor
|
Tests are failing... |
ashwinb
requested changes
Aug 6, 2025
llama_stack/providers/remote/datasetio/huggingface/huggingface.py
Outdated
Show resolved
Hide resolved
Elbehery
force-pushed
the
20250708_add_mypy_prompt_guard
branch
from
851597a to
5641437
Compare
Elbehery
commented
Aug 6, 2025
Elbehery
force-pushed
the
20250708_add_mypy_prompt_guard
branch
3 times, most recently
from
82a3354 to
eed8998
Compare
Elbehery
force-pushed
the
20250708_add_mypy_prompt_guard
branch
3 times, most recently
from
5d9353a to
19c47ec
Compare
Signed-off-by: Mustafa Elbehery <melbeher@redhat.com>
Elbehery
force-pushed
the
20250708_add_mypy_prompt_guard
branch
from
19c47ec to
94efa63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds static type coverage to
llama-stackPart of #2647
Test Plan