fix: make telemetry more resilient to missing data#2807
fix: make telemetry more resilient to missing data#2807cdoern wants to merge 1 commit intollamastack:mainfrom
Conversation
|
@cdoern can you share a failure example? |
it seems sometimes `row` is missing some data like `root_span_id`, omit these entries and log a warning Signed-off-by: Charlie Doern <cdoern@redhat.com>
ddf7323 to
0360e0d
Compare
|
@leseb : https://github.com/meta-llama/llama-stack/actions/runs/16368394907/job/46250869773 on the main branch, I can link this in the PR |
leseb
left a comment
There was a problem hiding this comment.
Rather than working around the error, can we investigate why root_span_id is missing in the first place? Thanks
|
Yes we should figure out why it's failing, as this should be deterministic. The only valid case where we'd be missing a With that span, root_span_id is NOT strictly required and validation requiring it is probably incorrect. See #2494 where some of this was fixed before, but I would expect this to either pass or fail consistently vs flake in this way. |
+1 I can disable the test again in the meantime |
What does this PR do?
it seems sometimes
rowis missing some data likeroot_span_id, omit these entries and log a warningexample failure: https://github.com/meta-llama/llama-stack/actions/runs/16368394907/job/46250869773
telemetry tests should now pass