Change useAgent to return undefined for nullable TrackReference values
#1224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce values This is being done to make them fit a bit better into the existing `trackRef` prop on a few components, which right now accepts `TrackReference | undefined`. I think given the history of how things evolved with `TrackReference`s it makes sense to do this, but I think it's a rather unfortunate change to make since null and undefined semantically tend to mean different things ([more info](https://kettanaito.com/blog/the-difference-between-null-and-undefined), [other interesting read](https://medium.com/@stephenthecurt/a-brief-history-of-null-and-undefined-in-javascript-c283caab662e)) and this case to me is semantically much more of a "null" (explicit absence of a value) than an "undefined" (value was never set).
🦋 Changeset detectedLatest commit: 33c710c The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1egoman
changed the title
undefined for nullable TrackReference valuesundefined for nullable TrackReference values
size-limit report 📦
|
1egoman
commented
Oct 23, 2025
Comment on lines
468
to
471
| // Clear inner values if no longer connected | ||
| cameraTrack: null, | ||
| microphoneTrack: null, | ||
| cameraTrack: undefined, | ||
| microphoneTrack: undefined, | ||
| }; |
There was a problem hiding this comment.
Just wanted to call out that I kept these key: undefined type entries here so that destructuring would continue to work coming out of useAgent - ie, const { cameraTrack, microphoneTrack } = useAgent(session). Otherwise this pattern would break down because cameraTrack + microphoneTrack wouldn't always be in the return value.
lukasIO
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is being done to make them fit a bit better into the existing
trackRefprop on a few components, which right now acceptsTrackReference | undefined.I think given the history of how things evolved with
TrackReferences it makes sense to do this, but I think it's a rather unfortunate change to make sincenullandundefinedsemantically tend to mean different things in javascript (more info, other interesting read) and this case to me is semantically much more of a "null" (explicit absence of a value) than an "undefined" (value was never set).Maybe it's something to litigate further as part of the next major version, however.