Avoid uncaught errors related to send/disconnect races #1674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: be8ab3c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
lukasIO
reviewed
Oct 2, 2025
|
|
||
| let streamController: ReadableStreamDefaultController<DataStream_Chunk>; | ||
| const outOfBandFailureRejectingFuture = new Future<never>(); | ||
| outOfBandFailureRejectingFuture.promise.catch((err) => { |
Contributor
There was a problem hiding this comment.
I think this is fine, it doesn't seem like it interferes with the existing logic, just logs a copy of any errors 👍
1egoman
approved these changes
Oct 2, 2025
lukasIO
approved these changes
Oct 2, 2025
Contributor
|
thanks for the contribution! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
catchin a few places to log instead of throwing uncaught errors.Fixes #1673
The RTCEngine change is prompted by the issue description, and is not awaited per #1673 (comment).
The
outOfBandFailureRejectingFuturecatch is prompted by a similar setup to this issue, where the promise can be rejected before anything even starts iterating the stream. In this case, I observed an uncaught "Participant ... unexpectedly disconnected in the middle of sending data" on Participant A when Participant B sends and disconnects concurrently. This probably needs a little extra review as it seems more subtle, but I think the approach is valid. I also confirmed it avoided the uncaught errors in my test app.No tests here as I didn't find any precedent for such.