Skip to content

Avoid uncaught errors related to send/disconnect races #1674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukasIO merged 3 commits into from
Oct 2, 2025
Merged

Avoid uncaught errors related to send/disconnect races #1674

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a700947
Avoid uncaught errors from negotiate
bryfox Oct 1, 2025
21b7d2c
Avoid uncaught errors when opening read streams
bryfox Oct 1, 2025
be8ab3c
Create giant-ligers-flow.md
lukasIO Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/room/RTCEngine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,9 @@ export default class RTCEngine extends (EventEmitter as new () => TypedEventEmit

// create offer
if (!this.subscriberPrimary || joinResponse.fastPublish) {
this.negotiate();
this.negotiate().catch((err) => {
log.error(err, this.logContext);
});
}

this.registerOnLineListener();
Expand Down Expand Up @@ -1338,7 +1340,9 @@ export default class RTCEngine extends (EventEmitter as new () => TypedEventEmit
}
if (needNegotiation) {
// start negotiation
this.negotiate();
this.negotiate().catch((err) => {
log.error(err, this.logContext);
});
}

const targetChannel = this.dataChannelForKind(kind, subscriber);
Expand Down
7 changes: 7 additions & 0 deletions src/room/data-stream/incoming/IncomingDataStreamManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,9 @@ export default class IncomingDataStreamManager {

let streamController: ReadableStreamDefaultController<DataStream_Chunk>;
const outOfBandFailureRejectingFuture = new Future<never>();
outOfBandFailureRejectingFuture.promise.catch((err) => {

@lukasIO lukasIO Oct 2, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@1egoman does this look reasonable to you?

@1egoman 1egoman Oct 2, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, it doesn't seem like it interferes with the existing logic, just logs a copy of any errors 👍

this.log.error(err);
});

const info: ByteStreamInfo = {
id: streamHeader.streamId,
Expand Down Expand Up @@ -178,6 +181,10 @@ export default class IncomingDataStreamManager {

let streamController: ReadableStreamDefaultController<DataStream_Chunk>;
const outOfBandFailureRejectingFuture = new Future<never>();
outOfBandFailureRejectingFuture.promise.catch((err) => {
this.log.error(err);
});

const info: TextStreamInfo = {
id: streamHeader.streamId,
mimeType: streamHeader.mimeType,
Expand Down
Loading