Skip to content

Conversation

@izaera
Copy link
Collaborator

@izaera izaera commented Feb 18, 2021

This is a rename of frontend-js-react-web and frontend-taglib which are the two critical packages.

Obsolete now: This PR needs liferay/liferay-frontend-projects#408 to be merged and released to work. I'm sending it only for review purposes (for now).

@izaera
Copy link
Collaborator Author

izaera commented Feb 18, 2021

ci:stop

@jbalsas
Copy link

jbalsas commented Feb 18, 2021

Screen Shot 2021-02-18 at 15 55 02

I thought you were joking when you said

This is a rename of frontend-js-react-web and frontend-taglib which are the two critical packages.

But it is indeed JUST those 2 modules! 😱

@izaera
Copy link
Collaborator Author

izaera commented Feb 18, 2021

Yes. When I started I thought we only needed to change things in package.json and npmscripts.config.js files 😅

@izaera
Copy link
Collaborator Author

izaera commented Feb 18, 2021

I'm not sure how we are gonna merge all the changes without conflicts 😬 .

Copy link

@wincent wincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how we are gonna merge all the changes without conflicts 😬 .

I was going to say, "It probably won't be as bad as you think. The changes are pretty well localized and we can give Brian a heads-up that this is on the way so that he can merge it quickly when he sees it." But then I realized that you haven't run SF yet, which is going to reorder a lot of those import statements and increase the number of touched lines by quite a bit.

If you're baby-sitting this for days before actually sending it then you are probably going to experience some pain rebasing in the meantime, even if you have done git config --global rerere.enabled.true. I hope you are able to doing this in a mostly automated find-and-replace kind of way that can be easily re-run.

As I was reading this, it occurred to me that these unpublished packages are going to look even more like published packages than they did before because of all those more legit-looking import statements, even though they're not published. But better that it's consistent (and probably necessary too).

@jbalsas
Copy link

jbalsas commented Feb 19, 2021

@izaera, we might want to rename the PR since this is not really "renaming all unpublished npm modules" after all, is it? 😂

@izaera
Copy link
Collaborator Author

izaera commented Feb 19, 2021

And the LPS too.

@izaera izaera changed the title LPS-127990 Rename all unpublished npm modules to move them to @liferay organization LPS-127990 Rename frontend-taglib and frontend-js-react-web npm modules to move them to @liferay organization Feb 19, 2021
@izaera
Copy link
Collaborator Author

izaera commented Feb 19, 2021

npm-scripts 37.1.0 is broken

I need to release more versions and push more commits

@jbalsas
Copy link

jbalsas commented Feb 19, 2021

I need to release more versions and push more commits

tmi

@jbalsas
Copy link

jbalsas commented Feb 19, 2021

Screen Shot 2021-02-19 at 14 25 02

ichooseyounadal

@izaera
Copy link
Collaborator Author

izaera commented Feb 22, 2021

ci:test:sf

@izaera
Copy link
Collaborator Author

izaera commented Feb 22, 2021

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 21 out of 33 jobs passed in 7 hours 6 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: bf41ac8d3aa2dbf64656fa7c0635882079d28f09

Upstream Comparison:

Branch GIT ID: bf41ac8d3aa2dbf64656fa7c0635882079d28f09
Jenkins Build URL: Acceptance Upstream DXP (master) #1575

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 21 out of 33 jobs PASSED

12 Failed Jobs:

21 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
    Job Results:

    9053 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=23,label_exp=!master #405528
      1. SearchRequestBuilderTest.testAddRescore
        org.junit.ComparisonFailure: {"from":0,"size":10000,"query":{"bool":{"must":[{"bool":{"must":[{"bool":{"should":[{"bool":{"must":[{"match":{"comments":{"query":"delta"}}}],"should":[{"match_phrase":{"comments":{"query":"delta","slop":50}}},{"match_phrase":{"comments":{"query":"delta","boost":2.0}}}]}},{"bool":{"must":[{"match":{"content":{"query":"delta"}}}],"should":[{"match_phrase":{"content":{"query":"delta","slop":50}}},{"match_phrase":{"content":{"query":"delta","boost":2.0}}}]}},{"bool":{"must":[{"match":{"description":{"query":"delta"}}}],"should":[{"match_phrase":{"description":{"query":"delta","slop":50}}},{"match_phrase":{"description":{"query":"delta","boost":2.0}}}]}},{"bool":{"should":[{"wildcard":{"properties":{"wildcard":"*delta*"}}}]}},{"bool":{"must":[{"bool":{"should":[{"match":{"title":{"query":"delta"}}},{"match_phrase_prefix":{"title":{"query":"delta"}}}]}}],"should":[{"match_phrase":{"title":{"query":"delta","boost":2.0}}}]}},{"bool":{"should":[{"match_phrase":{"url":{"query":"delta"}}},{"bool":{"should":[{"wildcard":{"url":{"wildcard":"*delta*"}}}]}},{"match_phrase_prefix":{"url":{"query":"delta","max_expansions":300}}}]}},{"bool":{"should":[{"wildcard":{"userName":{"wildcard":"*delta*"}}}]}},{"bool":{"must":[{"match":{"assetCategoryTitles_en_US":{"query":"delta"}}}],"should":[{"match_phrase":{"assetCategoryTitles_en_US":{"query":"delta","slop":50}}},{"match_phrase":{"assetCategoryTitles_en_US":{"query":"delta","boost":2.0}}}]}},{"bool":{"must":[{"bo...

Failures in common with acceptance upstream results at bf41ac8:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8/0
    Job Results:

    0 Tests Passed.
    2 Tests Failed.

    1. AXIS_VARIABLE=1,label_exp=!master #320309

      Please fix semantic versioning on izaera/fix-sec-2

           [exec] 
           [exec] > Task :apps:journal:journal-item-selector-web:compileJSP
           [exec] Note: /opt/dev/projects/github/liferay-portal/modules/apps/journal/journal-item-selector-web/build/jspc/org/apache/jsp/journal_005fimages_jsp.java uses unchecked or unsafe operations.
           [exec] Note: Recompile with -Xlint:unchecked for details.
           [exec] 
           [exec] > Task :apps:journal:journal-item-selector-web:jar
           [exec] > Task :apps:journal:journal-item-selector-web:autoUpdateXml SKIPPED
           [exec] > Task :apps:journal:journal-item-selector-web:baseline SKIPPED
           [exec] > Task :apps:journal:journal-item-selector-web:syncVersions
           [exec] 
           [exec] > Task :apps:journal:journal-content-web:generateJSPJava
           [exec] Compiling JSP files of project ':apps:journal:journal-content-web' with /opt/dev/projects/github/liferay-portal/bundles/tomcat-9.0.40/webapps/ROOT/WEB-INF/lib/util-taglib.jar as dependency in place of 'com.liferay.portal:com.liferay.util.taglib'
           [exec] 
           [exec] > Task :apps:journal:journal-content-web:compileJSP
           [exec] Note: Some input files use or override a deprecated API.
           [exec] Note: Recompile with -Xlint:deprecation for details.
           [exec] 
           [exec] > Task :apps:journal:journal-content-web:jar
           [exec] > Task :apps:journal:journal-content-web:autoUpdateXml SKIPPED
           [exec] > Task :apps:journal:journal-content-web:baseline SKIPPED
           [exec] > Task :apps:journal:journal-content-web:syncVersions
           [exec] Gradle build finished at 2021-02-24 12:58:50.003.
           [exec] 680 actionable tasks: 667 executed, 13 up-to-date
           [exec] 
           [exec] 
           [exec] FAILURE: Build completed with 2 failures.
           [exec] 
           [exec] 1: Task failed with an exception.
           [exec] -----------
           [exec] * What went wrong:
           [exec] Execution failed for task ':apps:frontend-taglib:frontend-taglib-react:baseline'.
           [exec] > A failure occurred while executing com.liferay.gradle.plugins.baseline.internal.work.BaselineWorkAction
           [exec]    > org.gradle.api.GradleException: Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/tools/sdk/dist/com.liferay.frontend.taglib.react-5.0.0.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay/com.liferay.frontend.taglib.react/4.1.2/ec050fd1c3aa0f51ab209177255ba6f126eabeef/com.liferay.frontend.taglib.react-4.1.2.jar

    2. AXIS_VARIABLE=0,label_exp=!master #320309

      Please fix semantic versioning on izaera/fix-sec-2

           [exec]   PACKAGE_NAME                                       DELTA      CUR_VER    BASE_VER   REC_VER    WARNINGS  
           [exec] = ================================================== ========== ========== ========== ========== ==========
           [exec] * com.liferay.data.engine.renderer                   MINOR      1.2.0      1.2.0      1.3.0      VERSION INCREASE REQUIRED
           [exec] 	<   class      com.liferay.data.engine.renderer.DataLayoutRendererContext
           [exec] 		+   method     getDefaultLanguageId()
           [exec] 			+   return     java.lang.String
           [exec] 		+   method     setDefaultLanguageId(java.lang.String)
           [exec] 			+   return     void
           [exec] [Baseline Report] Mode: diff (persisted)
           [exec] Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/tools/sdk/dist/com.liferay.data.engine.api-4.0.0.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay/com.liferay.data.engine.api/3.5.4/d054d179461a8661cbb9d98d7836ccd80a6c635d/com.liferay.data.engine.api-3.5.4.jar

  2. test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8/0
    Job Results:

    1 Test Passed.
    2 Tests Failed.

    1. AXIS_VARIABLE=1,label_exp=!master #489050
      	at hudson.remoting.Channel.close(Channel.java:1452)
      	at hudson.remoting.Channel.close(Channel.java:1405)
      	at hudson.slaves.SlaveComputer.closeChannel(SlaveComputer.java:832)
      	at hudson.slaves.SlaveComputer.access$800(SlaveComputer.java:105)
      	at hudson.slaves.SlaveComputer$3.run(SlaveComputer.java:741)
      	at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)
      	at jenkins.security.ImpersonatingExecutorService$1.run(ImpersonatingExecutorService.java:59)
      	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
      	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
      	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
      	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
      	at java.lang.Thread.run(Thread.java:745)
      ERROR: Step ???Publish JUnit test result report??? failed: no workspace for test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=1,label_exp=!master #489050
      ERROR: Step ???Cucumber reports??? failed: no workspace for test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=1,label_exp=!master #489050
      ERROR: Build step failed with exception
      java.lang.NullPointerException
      	at org.jenkinsci.plugins.postbuildscript.processor.Processor.<init>(Processor.java:51)
      	at org.jenkinsci.plugins.postbuildscript.processor.ProcessorFactory.createDefaultProcessor(ProcessorFactory.java:24)
      	at org.jenkinsci.plugins.postbuildscript.processor.ProcessorFactory.createMatrixProcessor(ProcessorFactory.java:35)
      	at org.jenkinsci.plugins.postbuildscript.PostBuildScript.createProcessor(PostBuildScript.java:213)
      	at org.jenkinsci.plugins.postbuildscript.PostBuildScript.perform(PostBuildScript.java:128)
      	at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
      	at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:744)
      	at hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:690)
      	at hudson.model.Build$BuildExecution.post2(Build.java:186)
      	at hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:635)
      	at hudson.model.Run.execute(Run.java:1841)
      	at hudson.matrix.MatrixRun.run(MatrixRun.java:153)
      	at hudson.model.ResourceController.execute(ResourceController.java:97)
      	at hudson.model.Executor.run(Executor.java:429)
      Build step 'Execute Scripts' marked build as failure
      Finished: FAILURE
    2. AXIS_VARIABLE=2,label_exp=!master #489050
      	at hudson.remoting.Channel.close(Channel.java:1452)
      	at hudson.remoting.Channel.close(Channel.java:1405)
      	at hudson.slaves.SlaveComputer.closeChannel(SlaveComputer.java:832)
      	at hudson.slaves.SlaveComputer.access$800(SlaveComputer.java:105)
      	at hudson.slaves.SlaveComputer$3.run(SlaveComputer.java:741)
      	at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)
      	at jenkins.security.ImpersonatingExecutorService$1.run(ImpersonatingExecutorService.java:59)
      	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
      	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
      	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
      	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
      	at java.lang.Thread.run(Thread.java:745)
      ERROR: Step ???Publish JUnit test result report??? failed: no workspace for test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=2,label_exp=!master #489050
      ERROR: Step ???Cucumber reports??? failed: no workspace for test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=2,label_exp=!master #489050
      ERROR: Build step failed with exception
      java.lang.NullPointerException
      	at org.jenkinsci.plugins.postbuildscript.processor.Processor.<init>(Processor.java:51)
      	at org.jenkinsci.plugins.postbuildscript.processor.ProcessorFactory.createDefaultProcessor(ProcessorFactory.java:24)
      	at org.jenkinsci.plugins.postbuildscript.processor.ProcessorFactory.createMatrixProcessor(ProcessorFactory.java:35)
      	at org.jenkinsci.plugins.postbuildscript.PostBuildScript.createProcessor(PostBuildScript.java:213)
      	at org.jenkinsci.plugins.postbuildscript.PostBuildScript.perform(PostBuildScript.java:128)
      	at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
      	at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:744)
      	at hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:690)
      	at hudson.model.Build$BuildExecution.post2(Build.java:186)
      	at hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:635)
      	at hudson.model.Run.execute(Run.java:1841)
      	at hudson.matrix.MatrixRun.run(MatrixRun.java:153)
      	at hudson.model.ResourceController.execute(ResourceController.java:97)
      	at hudson.model.Executor.run(Executor.java:429)
      Build step 'Execute Scripts' marked build as failure
      Finished: FAILURE
  3. ...

@calvinctvo
Copy link

Hi @izaera , I think it's safe to say that there's no unique failure for this PR. Every time ci:test:relevant runs, there's a different ci failures pops up. So I would say there's no blocker for this PR and you can manually forward.

@liferay-continuous-integration
Copy link
Collaborator

@wincent
Copy link

wincent commented Feb 25, 2021

ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 6 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 232b7029dbcc5cc632db42fdd9f88161634e3e96

Sender Branch:

Branch Name: fix-sec-2
Branch GIT ID: 53638f739d079c9b9856134d39eb1ec4ff6f4f3c

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

Copy link

@wincent wincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SF is green, so I'd say we can manually forward this based on:

I think it's safe to say that there's no unique failure for this PR. Every time ci:test:relevant runs, there's a different ci failures pops up. So I would say there's no blocker for this PR and you can manually forward.

link

and:

test passes in the currently running CI run:
https://testray.liferay.com/reports/production/logs/test-1-7/1614163073964/test-portal[…]modules-integration-mysql57-jdk8/1/0/jenkins-console.txt.gz

search for testGetPublishDateWithDisplayPage

I'd chalk this up as a fluke/flaky

link

@liferay-continuous-integration
Copy link
Collaborator

@izaera
Copy link
Collaborator Author

izaera commented Feb 25, 2021

Sent manually as brianchandotcom#99212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants