-
Notifications
You must be signed in to change notification settings - Fork 1
LPS-127990 Rename frontend-taglib and frontend-js-react-web npm modules to move them to @liferay organization #813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
ci:stop |
|
Yes. When I started I thought we only needed to change things in package.json and npmscripts.config.js files 😅 |
|
I'm not sure how we are gonna merge all the changes without conflicts 😬 . |
wincent
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how we are gonna merge all the changes without conflicts 😬 .
I was going to say, "It probably won't be as bad as you think. The changes are pretty well localized and we can give Brian a heads-up that this is on the way so that he can merge it quickly when he sees it." But then I realized that you haven't run SF yet, which is going to reorder a lot of those import statements and increase the number of touched lines by quite a bit.
If you're baby-sitting this for days before actually sending it then you are probably going to experience some pain rebasing in the meantime, even if you have done git config --global rerere.enabled.true. I hope you are able to doing this in a mostly automated find-and-replace kind of way that can be easily re-run.
As I was reading this, it occurred to me that these unpublished packages are going to look even more like published packages than they did before because of all those more legit-looking import statements, even though they're not published. But better that it's consistent (and probably necessary too).
...d-js/frontend-js-module-launcher/src/main/resources/META-INF/resources/webpack_federation.js
Show resolved
Hide resolved
|
@izaera, we might want to rename the PR since this is not really "renaming all unpublished npm modules" after all, is it? 😂 |
|
And the LPS too. |
|
npm-scripts 37.1.0 is broken I need to release more versions and push more commits |
|
ci:test:sf |
|
ci:test:relevant |
✔️ ci:test:stable - 9 out of 9 jobs passed❌ ci:test:relevant - 21 out of 33 jobs passed in 7 hours 6 minutesClick here for more details.Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: bf41ac8d3aa2dbf64656fa7c0635882079d28f09 ci:test:stable - 9 out of 9 jobs PASSED9 Successful Jobs:
ci:test:relevant - 21 out of 33 jobs PASSED12 Failed Jobs:
21 Successful Jobs:
For more details click here.Failures unique to this pull:
Failures in common with acceptance upstream results at bf41ac8:
|
|
Hi @izaera , I think it's safe to say that there's no unique failure for this PR. Every time |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#6766 |
Note this needs liferay/liferay-frontend-projects#408 to be merged to work.
|
ci:test:sf |
✔️ ci:test:sf - 1 out of 1 jobs passed in 6 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: fix-sec-2 1 Successful Jobs:For more details click here. |
wincent
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SF is green, so I'd say we can manually forward this based on:
I think it's safe to say that there's no unique failure for this PR. Every time
ci:test:relevantruns, there's a different ci failures pops up. So I would say there's no blocker for this PR and you can manually forward.
and:
test passes in the currently running CI run:
https://testray.liferay.com/reports/production/logs/test-1-7/1614163073964/test-portal[…]modules-integration-mysql57-jdk8/1/0/jenkins-console.txt.gzsearch for testGetPublishDateWithDisplayPage
I'd chalk this up as a fluke/flaky
|
Jenkins Build:test-portal-source-format#4738 |
|
Sent manually as brianchandotcom#99212 |




This is a rename of
frontend-js-react-webandfrontend-taglibwhich are the two critical packages.Obsolete now:
This PR needs liferay/liferay-frontend-projects#408 to be merged and released to work. I'm sending it only for review purposes (for now).